| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
With Rails 4 the default index page was moved from a static file `index.html` inside the `public/` folder to an internal controller/view inside of the railties gem. This was to allow use of erb in the default index page and to remove the requirement that new apps must delete a static file to make their index pages work. While this was a good change, the functionality was unexpected to developers who wish to get their apps running in production ASAP. They will create a new app `rails new my app`, start a server to verify it works, then immediately deploy the app to verify that it can start working in production. Unfortunately locally they see a page when they visit `localhost:3000` when they visit their production app they get an error page.
We initially anticipated this problem in the original pull request, but did not properly anticipate the severity or quantity of people who would like this functionality. Having a default index page serves as an excellent litmus test for a passed deploy on default apps, and it is very unexpected to have a page work locally, but not on production.
This change makes the default index page available in production if the developer has not over-written it by defining their own `root` path inside of routes.
|
| |
|
|
|
|
| |
rake task included in test:all rake task.
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 19ac034bdc9be175eff7cf54208ba14b43d97681.
And allows webservers to configure X-Sendfile-Type.
Closes #11440 thanks to [@MSch]
Conflicts:
railties/lib/rails/application.rb
|
|\
| |
| | |
Actionview api generation
|
| |
| |
| | |
CHANGELOG and LICENSE removed as suggested
|
|/ |
|
| |
|
|\
| |
| | |
#11381: Ignore config.eager_load=true for rake
|
| |
| |
| |
| | |
Closes #11381
|
|\ \
| |/
|/| |
Remove unnecessary string interpolation
|
| |
| |
| |
| | |
Removed from controller template of scaffold generator.
|
|\ \
| | |
| | | |
Creating a class to handle preparing ARGV.
|
| |/
| |
| |
| |
| |
| | |
Before the AppGenerator is started, ARGV needs to be modified to
correctly account for some things. I'm extracting these out into their
own class.
|
|/
|
|
|
| |
Instead of using the global constant ARGV, we're changing to using the
instance variable because it is more testable.
|
|\
| |
| | |
Creating a class for carrying out rails commands.
|
| |
| |
| |
| |
| |
| | |
This class encapsulates a lot of logic that wasn't very object oriented.
Helper methods have been created to try to make things more logical and
easy to read.
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Remove deprecated `ActiveRecord::Generators::ActiveModel#update_attribute`
|
| |
| |
| |
| | |
favor of `ActiveRecord::Generators::ActiveModel#update`
|
|/
|
|
| |
Thanks @egilburg.
|
|
|
|
|
| |
Given the recent security related patches to ruby and rails it is more
important than ever to know what patch level you are running.
|
|\
| |
| | |
Improved grammar and replaced 'dbs' slang with 'databases'
|
| | |
|
|\ \
| | |
| | | |
Making the rake file for tests easier to read.
|
| | |
| | |
| | |
| | |
| | | |
I'm defining a new class which modularizes how the `rake test` tasks are
defined and invoked.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Change Rails Migration generator module to use AS::Concern
|
| | | |
| | | |
| | | |
| | | | |
railties/lib/rails/generators/migration.rb file
|
|\ \ \ \
| |/ / /
|/| | | |
s/plugin_new/plugin
|
| | | |
| | | |
| | | |
| | | |
| | | | |
There are historical reasons that the `plugin` command was `plugin_new`, now those are no longer applicable, we should remove the naming edge case from the project. This PR is based off of comments from #11176
ATP Railties
|
|/ / /
| | |
| | |
| | |
| | | |
This change provides the ability to create a new application with a
configuration which can be specified.
|
|\ \ \
| | | |
| | | | |
Fix `rails plugin --help`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Right now if you run the `rails plugin --help` command it fails because rails expects a command in `railties/lib/rails/commands/plugin.rb` that does not exist because the file is named `plugin_new`. This is the error:
```
ruby-2.0.0-p0 ~/documents/projects/tmp/vanilla (master)
$ rails plugin --help
/Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `require': cannot load such file -- rails/commands/plugin (LoadError)
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `block in require'
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:213:in `load_dependency'
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `require'
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/railties-4.0.0/lib/rails/commands.rb:49:in `<top (required)>'
from bin/rails:4:in `require'
from bin/rails:4:in `<main>'
```
|
|/ / / |
|
|/ / |
|
| | |
|
|/
|
|
|
|
|
|
| |
The deprecation rake task is no longer useful because the deprecated
methods have already been removed.
The method for silencing stderr has been removed since it was only
useful for `rake test:uncommitted` which was deprecated and removed.
|
|
|
|
|
| |
The `rake test:recent` and `rake test:uncommitted` tasks were
deprecated and are now being removed.
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/layout.html.erb
|
| |
| |
| |
| | |
Add a mention about the helper's test file generated invoking the
controller generator in the USAGE file
|
| | |
|
|\ \
| | |
| | | |
Make "rails dbconsole" work with activerecord-postgis-adapter
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
In #11088, `#to_a` was added to remove a deprecation around using
`#all`. I merged, but it really should have been `#scoped` instead, as
that's the preferred replacement.
|