aboutsummaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #331 from sgrif/sg-in-should-not-break-queriesSean Griffin2014-10-241-1/+1
|\ | | | | `#not_in` with a range should respect proper precedence
| * `#not_in` with a range should respect proper precedenceSean Griffin2014-10-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, doing ```ruby relation[:id].not_eq(4).and(relation[:id].not_in(1..3)) ``` will generate ```sql "id" != 4 AND "id" < 1 OR "id" > 3 ``` Which would incorrectly include records with an id of 4, as the OR statement has higher precidence than the AND statement. The `or` method on `Node` properly groups the statement in parenthesis.
* | Binary nodes should not generate the same hash as nodes of other classesSean Griffin2014-10-241-1/+1
|/
* Completes 08e6491 in reusing `maybe_visit`claudiob2014-10-231-3/+3
| | | | | | | | | :sweat: I don't know why the tests did not fail, but to keep the same syntax as before, `collector =` is required. Maybe `visit` changes `collector` in-place, so the result is the same, but since I'm not sure about the side effects, I think this PR is needed to. Sorry! :sweat:
* Reuse `maybe_visit` methodclaudiob2014-10-232-18/+4
| | | | | This commit simply removes duplicated code by reusing the existing `maybe_visit` method.
* {Matches,DoesNotMatch} support the ESCAPE clauseTamir Duberstein2014-09-255-20/+46
|
* move the dispatch table to be per-instanceAaron Patterson2014-09-226-19/+37
| | | | | | | visitors are not shared among threads, so any mutations to the cache should be OK. The cache is also pre-populated on construction, but we should pull that out so we can share the cache among visitors in the future.
* connections should cache these values, so remove the cache in arelAaron Patterson2014-09-221-4/+3
|
* Merge pull request #167 from pparidans/informix-v9-supportRafael Mendonça França2014-09-171-1/+1
|\ | | | | Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT'
| * Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT'Pierre Paridans2014-09-161-1/+1
| | | | | | | | Still supported in versions 10+
* | Merge pull request #137 from dimko/visit_setRafael Mendonça França2014-09-173-0/+3
|\ \ | |/ |/| Added a visitor for Set objects
| * added a visitor for Set objectsDimko2012-09-183-0/+3
| |
* | Remove unused @alias, being referenced in hashing.Vipul A M2014-09-161-1/+1
| |
* | Wrap group_by sql with a subquery for limiting rows in Oracle.Chris Dinger2014-09-161-1/+1
| | | | | | | | Fixes #128
* | `Extract#as` should not mutate the receiverTamir Duberstein2014-09-132-18/+4
| | | | | | | | Fixes https://github.com/rails/rails/issues/16913
* | Merge pull request #306 from mxhold/masterRafael Mendonça França2014-09-121-0/+9
|\ \ | | | | | | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifier
| * | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifierMax Holder2014-08-301-0/+9
| | |
* | | Merge pull request #304 from bigxiang/fix_lt_and_lteq_errorRafael Mendonça França2014-09-121-6/+6
|\ \ \ | | | | | | | | Fix lt & lteq don't accept most of values.
| * | | Fix lt & lteq don't accept most of values.bigxiang2014-08-231-6/+6
| | | |
* | | | Merge pull request #277 from sergey-alekseev/wrap-nested-gropings-only-onceRafael Mendonça França2014-09-121-2/+6
|\ \ \ \ | |_|/ / |/| | | Wrap nested Nodes::Grouping in brackets only once
| * | | Wrap nested Nodes::Grouping in brackets only onceSergey Alekseev2014-05-261-2/+6
| | | |
* | | | Merge pull request #300 from jpcody/masterMatthew Draper2014-08-261-4/+5
|\ \ \ \ | |_|/ / |/| | | Allow for alias omission in aggregate expressions
| * | | Remove default aliases from aggregate functionsJoshua Cody2014-07-311-14/+8
| | | |
| * | | Allow for alias omission in aggregate expressionsJoshua Cody2014-07-261-8/+15
| | | |
* | | | Prepare to 6.0.0.beta1Rafael Mendonça França2014-08-171-1/+1
|/ / /
* | | Windowing: Calling #rows or #range should assign framing only once.Alexander Staubo2014-06-222-2/+12
| | |
* | | Windowing support for PARTITION BY clause.Alexander Staubo2014-06-203-2/+21
| | |
* | | Modify Visitors::Dot's API to use collectorsJiri Pospisil2014-06-142-3/+5
| | |
* | | Collectors: Introduce PlainString and make use of it in SQLStringJiri Pospisil2014-06-142-14/+21
| | |
* | | Merge pull request #290 from mekishizufu/fix_select_manager_as_subqueryRafael Mendonça França2014-06-131-1/+1
|\ \ \ | | | | | | | | Support passing of SelectManager to attribute methods
| * | | No need to check for SelectStatement as it's a descendant of NodeJiri Pospisil2014-06-121-1/+1
| | | |
| * | | Make sure Arel::SelectManager is not mistaken for an attributeJiri Pospisil2014-06-121-1/+1
| | | |
* | | | Make sure visit_Arel_Nodes_With works with collectorsJiri Pospisil2014-06-121-2/+3
|/ / /
* | | Merge pull request #284 from Octember/masterRafael Mendonça França2014-06-061-18/+22
|\ \ \ | | | | | | | | Cleaned up some edge cases with infinity in predications.rb
| * | | Cleaned up some edge cases with infinity, the logic seems more intuitive nowNoah Lindner2014-06-011-18/+22
| | | |
* | | | Merge pull request #281 from vipulnsward/remove-warningRafael Mendonça França2014-06-021-5/+1
|\ \ \ \ | | | | | | | | | | - Remove four year old deprecation
| * | | | - Remove four year old deprecationVipul A M2014-06-011-5/+1
| | | | |
* | | | | Merge pull request #283 from vipulnsward/rm-valuesCarlos Antonio da Silva2014-06-011-2/+0
|\ \ \ \ \ | |_|/ / / |/| | | | Remove unused values variable
| * | | | Remove unused values variableVipul A M2014-06-011-2/+0
| |/ / /
* / / / Arel doesn't depend on activesupport and doesn't have "String#blank?"Vipul A M2014-06-012-2/+2
|/ / / | | | | | | | | | Remove usage of `.blank?` to match empty strings with a regular expression instead.
* | | Merge pull request #276 from brocktimus/masterRafael Mendonça França2014-05-281-1/+1
|\ \ \ | | | | | | | | Fixing method signature for unsupported visits in the ToSQL Visitor
| * | | Fixing method signature for unsupported visits in the ToSQL VisitorBrock Trappitt2014-05-261-1/+1
| |/ /
* / / Fix typo `delegte` => `delegate`Vipul A M2014-05-251-1/+1
|/ /
* | Merge pull request #271 from jordansexton/patch-2Rafael Mendonça França2014-05-191-0/+8
|\ \ | | | | | | Added update and delete convenience methods
| * | Added #update_manager and #delete_manager convenience methods for consistencyJordan Sexton2014-05-171-0/+8
| | |
* | | Merge pull request #272 from jduff/rebased_outer_joinRafael Mendonça França2014-05-192-0/+8
|\ \ \ | | | | | | | | Add convenience #outer_join
| * | | convenience method for outer_joinBrian Hahn2014-05-182-0/+8
| |/ /
* | | Merge pull request #267 from jordansexton/patch-1Rafael Mendonça França2014-05-191-0/+1
|\ \ \ | |/ / |/| | Return self from distinct so it's chainable
| * | Return self from #distinct so it's chainableJordan Sexton2014-05-171-0/+1
| | |
* | | Remove old FIXME commentArthur Neves2014-05-071-3/+0
|/ / | | | | | | The comment was introducted on https://github.com/rails/arel/commit/d8de55cee197d887b478b134ec692776613bf998 , and the code has changed