aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2014-10-23 14:53:20 -0600
committerSean Griffin <sean@thoughtbot.com>2014-10-24 09:01:39 -0500
commit51f48f0ed9ec84fd12584b750609a2f7e945b945 (patch)
treefba26fe05d08294f4e08502cea32650aeede5220 /lib
parent0e6c7e6de73fdddaf7f1486657f4d9f8e8f5fde3 (diff)
downloadrails-51f48f0ed9ec84fd12584b750609a2f7e945b945.tar.gz
rails-51f48f0ed9ec84fd12584b750609a2f7e945b945.tar.bz2
rails-51f48f0ed9ec84fd12584b750609a2f7e945b945.zip
`#not_in` with a range should respect proper precedence
Currently, doing ```ruby relation[:id].not_eq(4).and(relation[:id].not_in(1..3)) ``` will generate ```sql "id" != 4 AND "id" < 1 OR "id" > 3 ``` Which would incorrectly include records with an id of 4, as the OR statement has higher precidence than the AND statement. The `or` method on `Node` properly groups the statement in parenthesis.
Diffstat (limited to 'lib')
-rw-r--r--lib/arel/predications.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/arel/predications.rb b/lib/arel/predications.rb
index 3050526a43..6f9a3c5f91 100644
--- a/lib/arel/predications.rb
+++ b/lib/arel/predications.rb
@@ -83,7 +83,7 @@ module Arel
else
right = Nodes::GreaterThan.new(self, Nodes.build_quoted(other.end, self))
end
- Nodes::Or.new left, right
+ left.or(right)
end
when Array
Nodes::NotIn.new self, other.map { |x| Nodes.build_quoted(x, self) }