Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | Fixing logger to work with Rails 5.2.0.alpha | Stanislav Gospodinov | 2017-07-15 | 1 | -3/+3 | |
| | | | ||||||
| * | | Merge pull request #53 from colorfulfool/error-messages | George Claghorn | 2017-07-14 | 2 | -2/+5 | |
| |\ \ | | | | | | | | | Useful error messages for two possible misconfigurations | |||||
| | * | | Fail early if no storage service is specified | colorfulfool | 2017-07-15 | 1 | -0/+3 | |
| | | | | ||||||
| | * | | Don't fail on boot because of missing S3 keys when S3 is not used | colorfulfool | 2017-07-15 | 1 | -2/+2 | |
| | |/ | ||||||
| * / | Revert back to the original implementaion with varaibles | dixpac | 2017-07-14 | 1 | -2/+8 | |
| |/ | | | | | | | | | | | Revert `exist? and url` to the original implementation. Since the new one doesn't provide any benefits and makes implementation harder to follow. | |||||
| * | Added rubocop / codeclimate config and fixed current offenses (#45) | Cristian Bica | 2017-07-14 | 7 | -12/+12 | |
| | | ||||||
| * | Remove few ivars from gcs_service implementation | dixpac | 2017-07-13 | 1 | -8/+2 | |
| | | ||||||
| * | Merge pull request #42 from quartzmo/gcs-site-url | George Claghorn | 2017-07-12 | 1 | -2/+2 | |
| |\ | | | | | | | Update GCSService#url | |||||
| | * | Update GCSService#url | Chris Smith | 2017-07-12 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | Update google-cloud-storage dependency to 1.3 Refactor arguments to Google::Cloud::Storage::File#signed_url | |||||
| * | | Revert "S3: slim down service implementation (#40)" (#41) | David Heinemeier Hansson | 2017-07-12 | 1 | -24/+36 | |
| |/ | | | | | This reverts commit 6d3962461fb8d35fc9538d685fee96267663acf2. | |||||
| * | S3: slim down service implementation (#40) | Jeremy Daer | 2017-07-11 | 1 | -36/+24 | |
| | | | | | | | | | | | | | | * Use simple core API for duck-type compat with other clients * initialize: accept an existing client * initialize: accept arbitrary client args instead of a fixed, required set * download: use native get_object streaming, no need to implement range requests * exists?: use head_object (which returns immediately) rather than waiting for existence | |||||
| * | Expose chunked downloads | George Claghorn | 2017-07-10 | 2 | -6/+6 | |
| | | ||||||
* | | Very incomplete first stab | David Heinemeier Hansson | 2017-07-11 | 5 | -24/+112 | |
|/ | ||||||
* | Accept sgids for existing blobs created via direct upload as an attachable | David Heinemeier Hansson | 2017-07-09 | 1 | -0/+4 | |
| | ||||||
* | Direct uploads for S3 | David Heinemeier Hansson | 2017-07-09 | 7 | -2/+42 | |
| | ||||||
* | Copypasta comments | David Heinemeier Hansson | 2017-07-09 | 1 | -3/+0 | |
| | | | | | | | | | | # Conflicts: # lib/active_storage/engine.rb # lib/active_storage/service.rb # lib/active_storage/service/disk_service.rb # lib/active_storage/service/s3_service.rb # test/service/s3_service_test.rb # test/test_helper.rb | |||||
* | Instrument and log the services | David Heinemeier Hansson | 2017-07-09 | 6 | -32/+168 | |
| | ||||||
* | Merge pull request #27 from dixpac/fix_configuration_keys_symbolization | David Heinemeier Hansson | 2017-07-09 | 1 | -1/+1 | |
|\ | | | | | Symbolize all keys inside configuration nested hash | |||||
| * | Symbolize all keys inside configuration nested hash | dixpac | 2017-07-09 | 1 | -1/+1 | |
| | | | | | | | | | | Since configuration is a nested hash we need to symbolize all keys of the hash. Othervise fetcing will fail on start | |||||
* | | Ensure binary encoding for downloading | David Heinemeier Hansson | 2017-07-09 | 1 | -1/+1 | |
|/ | ||||||
* | Use class methods scope now that we have multiple | David Heinemeier Hansson | 2017-07-09 | 1 | -14/+16 | |
| | ||||||
* | Clarify how a service can build other composed services | Jeremy Daer | 2017-07-09 | 3 | -34/+36 | |
| | | | | | | | | | * Service.build takes the literal YAML config hash for the service and a reference to the Configurator that's doing the building. * Services that compose additional services can use the Configurator to look them up and build them by name. See MirrorService for an example. References #23 | |||||
* | Service: clarify Service.build arguments | Jeremy Daer | 2017-07-09 | 2 | -5/+5 | |
| | | | | | | | First arg is config for the service we're instantiating. Second arg is service configurations so we can look up and configure other services by name. | |||||
* | Configure services that reference other services | Jeremy Daer | 2017-07-08 | 5 | -28/+69 | |
| | | | | | | | | * Move service configuration from the Engine to Service * Delegate configuration mechanics to internal Service::Configurator * Delegate service building to the concrete Service classes, allowing them to configure composed services. * Implement for the Mirror service. | |||||
* | Mirror: explicit primary service and list of mirrors | Jeremy Daer | 2017-07-08 | 1 | -10/+9 | |
| | | | | | | | | | | | | Pass separate primary service and list of mirrors rather than treating the first of the services list as the primary. Nice fit for keyword args, and something we've long wanted in the equivalent Basecamp file repository. Upload returns the results of the underlying service uploads rather than the io.rewind result. Rewind before uploading rather than afterward, and demonstrate that behavior with a test. Test that more than one mirror works. | |||||
* | Merge pull request #21 from jeremy/disk-binary-io | David Heinemeier Hansson | 2017-07-09 | 1 | -8/+4 | |
|\ | | | | | Disk service: use binary IO throughout, not UTF-8 | |||||
| * | Disk service: use binary IO throughout, not UTF-8 | Jeremy Daer | 2017-07-08 | 1 | -8/+4 | |
| | | ||||||
* | | Disk storage: ensure URLs end with the blob filename since some user agents ↵ | Jeremy Daer | 2017-07-08 | 3 | -5/+5 | |
|/ | | | | don't respect Content-Disposition filename | |||||
* | Merge pull request #15 from robin850/documentation | David Heinemeier Hansson | 2017-07-08 | 6 | -5/+100 | |
|\ | | | | | Add some documentation | |||||
| * | Add some documentation | Robin Dupret | 2017-07-07 | 6 | -5/+100 | |
| | | ||||||
* | | Change type of created_at columns from time to datetime | George Claghorn | 2017-07-07 | 1 | -8/+8 | |
| | | | | | | | | We intend to store a date and time, not merely a time. | |||||
* | | It is an engine (because of tasks) not a railtie | David Heinemeier Hansson | 2017-07-07 | 2 | -2/+2 | |
|/ | ||||||
* | Create db/migrate if it doesn't exist | George Claghorn | 2017-07-06 | 1 | -0/+1 | |
| | ||||||
* | Merge pull request #8 from robin850/fix-migrations | George Claghorn | 2017-07-06 | 1 | -1/+1 | |
|\ | | | | | Fix the migration class name | |||||
| * | Fix the migration class name | Robin Dupret | 2017-07-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | Due to Active Support auto loading feature, the migration class shouldn't be name-spaced under the `ActiveStorage` constant, otherwise, running the migrations would throw an error. | |||||
* | | Use safe navigation | George Claghorn | 2017-07-06 | 1 | -1/+1 | |
| | | ||||||
* | | Remove unnecessary method delegations | George Claghorn | 2017-07-06 | 1 | -1/+1 | |
|/ | ||||||
* | Fix test | George Claghorn | 2017-07-06 | 1 | -0/+2 | |
| | | | | | | | * S3 fails fast if the Content-MD5 header on an upload request is an invalid checksum. Send a valid but incorrect checksum. * Rescue the service-specific exception and raise the generic one. | |||||
* | Merge branch 'master' into s3_integrity | John Williams | 2017-07-06 | 1 | -2/+3 | |
|\ | ||||||
| * | Style | George Claghorn | 2017-07-06 | 1 | -5/+3 | |
| | | ||||||
| * | Adding server side integrity check for GCS Service | Stanislav Gospodinov | 2017-07-06 | 1 | -2/+5 | |
| | | ||||||
* | | Send checksum to S3 to verify file integrity | John Williams | 2017-07-06 | 1 | -2/+1 | |
|/ | ||||||
* | Fix hash usage consistency. | Ra'Shaun Stovall | 2017-07-06 | 1 | -1/+1 | |
| | | | | | | | Unless this was intentional, being consistent with: https://github.com/rails/activestorage/blob/master/lib/active_storage/service/s3_service.rb#L8 Just showin' a lil' <3 while perusing the repo @dhh | |||||
* | Check integrity after uploads | David Heinemeier Hansson | 2017-07-06 | 6 | -7/+19 | |
| | ||||||
* | Dropped from the interface | David Heinemeier Hansson | 2017-07-06 | 1 | -9/+0 | |
| | ||||||
* | Need the byte helpers | David Heinemeier Hansson | 2017-07-06 | 2 | -0/+2 | |
| | ||||||
* | Compute checksum and byte_size client side | David Heinemeier Hansson | 2017-07-06 | 4 | -37/+15 | |
| | | | | | Then we can add integrity checks on uploads to prevent errors in transport. | |||||
* | Remember to add streaming | David Heinemeier Hansson | 2017-07-06 | 1 | -0/+1 | |
| | ||||||
* | This is even more explaining and upload/download don't have some inherent ↵ | David Heinemeier Hansson | 2017-07-06 | 1 | -4/+2 | |
| | | | | need to synchronize chunk sizes anyway | |||||
* | We have the technology! | David Heinemeier Hansson | 2017-07-06 | 1 | -1/+1 | |
| |