aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorDavid Heinemeier Hansson <david@loudthinking.com>2017-07-06 15:35:48 +0200
committerDavid Heinemeier Hansson <david@loudthinking.com>2017-07-06 15:35:48 +0200
commit0ed18d9671ea7189e737be3d9f7b9f915c31c390 (patch)
treebe8b6a1c177c79ebef7b3213571484931daba424 /lib
parent89e8b8654621dae37266e4fa6b38627122f66a56 (diff)
downloadrails-0ed18d9671ea7189e737be3d9f7b9f915c31c390.tar.gz
rails-0ed18d9671ea7189e737be3d9f7b9f915c31c390.tar.bz2
rails-0ed18d9671ea7189e737be3d9f7b9f915c31c390.zip
This is even more explaining and upload/download don't have some inherent need to synchronize chunk sizes anyway
Diffstat (limited to 'lib')
-rw-r--r--lib/active_storage/service/disk_service.rb6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/active_storage/service/disk_service.rb b/lib/active_storage/service/disk_service.rb
index dc7491310b..7981226a1e 100644
--- a/lib/active_storage/service/disk_service.rb
+++ b/lib/active_storage/service/disk_service.rb
@@ -2,8 +2,6 @@ require "fileutils"
require "pathname"
class ActiveStorage::Service::DiskService < ActiveStorage::Service
- CHUNK_SIZE = 65536
-
attr_reader :root
def initialize(root:)
@@ -12,7 +10,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service
def upload(key, io)
File.open(make_path_for(key), "wb") do |file|
- while chunk = io.read(CHUNK_SIZE)
+ while chunk = io.read(64.kilobytes)
file.write(chunk)
end
end
@@ -21,7 +19,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service
def download(key)
if block_given?
File.open(path_for(key)) do |file|
- while data = file.read(CHUNK_SIZE)
+ while data = file.read(64.kilobytes)
yield data
end
end