Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Allow a type caster to be given to the `Arel::Table` object | Sean Griffin | 2014-12-29 | 1 | -1/+22 |
| | | | | | | | | | This will allow most consuming code to avoid the deprecation introduced in 008445d6fd5f825d9b445ac75a7be67f0f7ab52c. The only code which will be affected is code that is building the `Arel::Table` object manually, rather than calling `arel_table` on an Active Record class. Hopefully this case will be rare enough that we don't need to introduce any additional APIs to work around it. | ||||
* | remove extra space before 'ORDER BY' | Nihad Abbasov | 2014-11-26 | 1 | -1/+0 |
| | |||||
* | Add order to BindParams in the ToSql collector | Sean Griffin | 2014-11-17 | 1 | -2/+3 |
| | | | | | | | | | | | | This removes the need for us to do the re-ordering by walking the AST in ActiveRecord. We're using a block to communicate with the collector, since the collector needs to be the thing which knows about the index, while the visitor is the thing that needs to know the syntax. The BindParam needs to know about neither of these things, so it's been changed to stop being a subclass of SqlLiteral I could also see an alternative implementation using format strings if for some reason blocks cause a problem. | ||||
* | Completes 08e6491 in reusing `maybe_visit` | claudiob | 2014-10-23 | 1 | -3/+3 |
| | | | | | | | | | :sweat: I don't know why the tests did not fail, but to keep the same syntax as before, `collector =` is required. Maybe `visit` changes `collector` in-place, so the result is the same, but since I'm not sure about the side effects, I think this PR is needed to. Sorry! :sweat: | ||||
* | Reuse `maybe_visit` method | claudiob | 2014-10-23 | 1 | -12/+3 |
| | | | | | This commit simply removes duplicated code by reusing the existing `maybe_visit` method. | ||||
* | {Matches,DoesNotMatch} support the ESCAPE clause | Tamir Duberstein | 2014-09-25 | 1 | -2/+14 |
| | |||||
* | move the dispatch table to be per-instance | Aaron Patterson | 2014-09-22 | 1 | -3/+7 |
| | | | | | | | visitors are not shared among threads, so any mutations to the cache should be OK. The cache is also pre-populated on construction, but we should pull that out so we can share the cache among visitors in the future. | ||||
* | connections should cache these values, so remove the cache in arel | Aaron Patterson | 2014-09-22 | 1 | -4/+3 |
| | |||||
* | Merge pull request #137 from dimko/visit_set | Rafael Mendonça França | 2014-09-17 | 1 | -0/+1 |
|\ | | | | | Added a visitor for Set objects | ||||
| * | added a visitor for Set objects | Dimko | 2012-09-18 | 1 | -0/+1 |
| | | |||||
* | | `Extract#as` should not mutate the receiver | Tamir Duberstein | 2014-09-13 | 1 | -8/+1 |
| | | | | | | | | Fixes https://github.com/rails/rails/issues/16913 | ||||
* | | Merge pull request #277 from sergey-alekseev/wrap-nested-gropings-only-once | Rafael Mendonça França | 2014-09-12 | 1 | -2/+6 |
|\ \ | | | | | | | Wrap nested Nodes::Grouping in brackets only once | ||||
| * | | Wrap nested Nodes::Grouping in brackets only once | Sergey Alekseev | 2014-05-26 | 1 | -2/+6 |
| | | | |||||
* | | | Windowing: Calling #rows or #range should assign framing only once. | Alexander Staubo | 2014-06-22 | 1 | -0/+2 |
| | | | |||||
* | | | Windowing support for PARTITION BY clause. | Alexander Staubo | 2014-06-20 | 1 | -0/+6 |
| | | | |||||
* | | | Make sure visit_Arel_Nodes_With works with collectors | Jiri Pospisil | 2014-06-12 | 1 | -2/+3 |
| | | | |||||
* | | | Remove unused values variable | Vipul A M | 2014-06-01 | 1 | -2/+0 |
| | | | |||||
* | | | Fixing method signature for unsupported visits in the ToSQL Visitor | Brock Trappitt | 2014-05-26 | 1 | -1/+1 |
|/ / | |||||
* | | Allow INSERT INTO <table> SELECT queries | Jean Boussier | 2014-04-10 | 1 | -1/+7 |
| | | |||||
* | | rhs bind parameters should be visited | Aaron Patterson | 2014-04-09 | 1 | -1/+1 |
| | | |||||
* | | fix bind values in insert statements | Aaron Patterson | 2014-04-09 | 1 | -4/+8 |
| | | |||||
* | | adding a bind value collector | Aaron Patterson | 2014-04-09 | 1 | -1/+4 |
| | | |||||
* | | add a compile method for some backwards compatibility | Aaron Patterson | 2014-04-09 | 1 | -0/+4 |
| | | |||||
* | | fixing BINARY tests | Aaron Patterson | 2014-04-08 | 1 | -2/+2 |
| | | |||||
* | | fixing EXTRACT | Aaron Patterson | 2014-04-08 | 1 | -2/+10 |
| | | |||||
* | | fixing OVER | Aaron Patterson | 2014-04-08 | 1 | -9/+9 |
| | | |||||
* | | fixing insert manager | Aaron Patterson | 2014-04-08 | 1 | -5/+9 |
| | | |||||
* | | fixing test_table.rb | Aaron Patterson | 2014-04-08 | 1 | -9/+9 |
| | | |||||
* | | informix is working | Aaron Patterson | 2014-04-08 | 1 | -2/+1 |
| | | |||||
* | | postgresql visitor is working | Aaron Patterson | 2014-04-08 | 1 | -2/+2 |
| | | |||||
* | | push reduction visitors to a reduction base class | Aaron Patterson | 2014-04-08 | 1 | -1/+2 |
| | | | | | | | | this lets our old depth first and dot visitors to work normally | ||||
* | | select manager tests are passing | Aaron Patterson | 2014-04-08 | 1 | -14/+25 |
| | | |||||
* | | more select manager tests passing | Aaron Patterson | 2014-04-08 | 1 | -11/+22 |
| | | |||||
* | | making some of the sql manager tests pass | Aaron Patterson | 2014-04-08 | 1 | -46/+88 |
| | | |||||
* | | Merge branch 'master' into collector | Aaron Patterson | 2014-04-08 | 1 | -2/+18 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: remove order_clauses since we do not use it fix whitespace and unsupported method args Add Regexp and NotRegexp nodes for PostgreSQL Revert "Merge pull request #253 from corrupt952/master" flatten object.children in visit_Arel_Node_And Added right and full outer joins Conflicts: lib/arel/visitors/to_sql.rb lib/arel/visitors/visitor.rb | ||||
| * \ | Merge pull request #248 from chewi/master | Aaron Patterson | 2014-04-07 | 1 | -0/+8 |
| |\ \ | | | | | | | | | Add Regexp and NotRegexp nodes for PostgreSQL | ||||
| | * | | Add Regexp and NotRegexp nodes for PostgreSQL | James Le Cuirot | 2014-04-08 | 1 | -0/+8 |
| | | | | |||||
| * | | | fix whitespace and unsupported method args | Aaron Patterson | 2014-04-07 | 1 | -1/+1 |
| |/ / | |||||
| * | | Revert "Merge pull request #253 from corrupt952/master" | Aaron Patterson | 2014-04-07 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | This reverts commit 6d3ed6d96c4a3ac85b97d81bad95b7254b2aa2d4, reversing changes made to a35fede61ac1a2fcff519ad052f2fcb8808922b9. | ||||
| * | | flatten object.children in visit_Arel_Node_And | Kazuki Hasegawa | 2014-04-03 | 1 | -1/+1 |
| | | | |||||
| * | | Added right and full outer joins | Stephen Prater & Fire-Dragon-DoL | 2014-03-30 | 1 | -0/+8 |
| | | | |||||
* | | | to_sql is passing | Aaron Patterson | 2014-04-08 | 1 | -57/+97 |
| | | | |||||
* | | | fixing some tests in to_sql | Aaron Patterson | 2014-04-08 | 1 | -67/+112 |
| | | | |||||
* | | | bind visitor working with collector object | Aaron Patterson | 2014-04-08 | 1 | -2/+3 |
|/ / | |||||
* | | Removed all the fiels in lib/arel/visitors/ which needs dependency on 'a' ↵ | Alex Lin | 2014-03-24 | 1 | -170/+159 |
| | | | | | | | | also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a. | ||||
* | | add the casting node to the AST at build time | Aaron Patterson | 2014-03-24 | 1 | -14/+26 |
| | | | | | | | | | | If we add the casting node to the ast at build time, then we can avoid doing the lookup at visit time. | ||||
* | | Merge pull request #246 from cmohanprasath/assign_value_from_attribute_test | Aaron Patterson | 2014-02-24 | 1 | -2/+7 |
|\ \ | | | | | | | Assign value from attribute test | ||||
| * | | Allow assignment right member to reference columns | Loic Nageleisen | 2014-02-11 | 1 | -2/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Such queries become possible for mortals: ```ruby table.where(table[:qux].eq 'zomg').compile_update(table[:foo] => table[:bar]) ``` Arguably much more sane than using `engine.connection.quote_column_name` or `engine.connection.visitor.accept` on the right hand (bar), which is totally leaking the abstraction. | ||||
* | | | Remove deprecated Arel::SqlLiteral | Rafael Mendonça França | 2014-02-10 | 1 | -1/+0 |
|/ / | |||||
* | | Documented the case-insensitive nature of the match feature. | Robb Shecter | 2013-12-05 | 1 | -0/+4 |
| | | | | | | Documenting the library's behavior. People and other libraries (cf. Squeel) have come to depend on this behavior, and so am submitting this pull request to specify it authoritatively. |