aboutsummaryrefslogtreecommitdiffstats
path: root/lib/arel/visitors/to_sql.rb
diff options
context:
space:
mode:
authorTamir Duberstein <tamird@squareup.com>2014-09-13 19:35:34 -0700
committerTamir Duberstein <tamird@squareup.com>2014-09-13 20:04:34 -0700
commit8c73dad0761980061ce45018172034cad34cd585 (patch)
tree12f140e8dcece55f591591f6da95d15b17db0780 /lib/arel/visitors/to_sql.rb
parentd23df0ec8a50b50024f8d4dc5d91a47509df9b1f (diff)
downloadrails-8c73dad0761980061ce45018172034cad34cd585.tar.gz
rails-8c73dad0761980061ce45018172034cad34cd585.tar.bz2
rails-8c73dad0761980061ce45018172034cad34cd585.zip
`Extract#as` should not mutate the receiver
Fixes https://github.com/rails/rails/issues/16913
Diffstat (limited to 'lib/arel/visitors/to_sql.rb')
-rw-r--r--lib/arel/visitors/to_sql.rb9
1 files changed, 1 insertions, 8 deletions
diff --git a/lib/arel/visitors/to_sql.rb b/lib/arel/visitors/to_sql.rb
index ae1b7930af..ca09373b64 100644
--- a/lib/arel/visitors/to_sql.rb
+++ b/lib/arel/visitors/to_sql.rb
@@ -475,14 +475,7 @@ module Arel
def visit_Arel_Nodes_Extract o, collector
collector << "EXTRACT(#{o.field.to_s.upcase} FROM "
- collector = visit o.expr, collector
- collector << ")"
- if o.alias
- collector << " AS "
- visit o.alias, collector
- else
- collector
- end
+ visit(o.expr, collector) << ")"
end
def visit_Arel_Nodes_Count o, collector