| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
guides [ci skip]
Guides should be updated because ActionDispatch::LoadInterlock was replaced with
ActionDispatch::Executor at #23807.
|
| |
|
|\
| |
| | |
Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip]
|
| | |
|
|/
|
|
|
|
|
| |
- Only ones left are from the upgrading guide, and command line guide explicit section about rake
Follow up of https://github.com/rails/rails/pull/23119
[ci skip]
|
|
|
|
|
|
|
|
| |
Should use `public_file_server.enabled` instead.
Clarified that static files will be served from the public directory, where it made sense.
Also removed occurrence of the deprecated `static_cache_control`.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 37423e4ff883ad5584bab983aceb4b2b759a1fd8.
Jeremy is right that we shouldn't remove this. The fact is that many
engines are depending on this middleware to be in the default stack.
This ties our hands and forces us to keep the middleware in the stack so
that engines will work. To be extremely clear, I think this is another
smell of "the rack stack" that we have in place. When manipulating
middleware, we should have meaningful names for places in the req / res
lifecycle **not** have engines depend on a particular constant be in a
particular place in the stack. This is a weakness of the API that we
have to figure out a way to address before removing the constant.
As far as timing attacks are concerned, we can reduce the granularity
such that it isn't useful information for hackers, but is still useful
for developers.
|
|\
| |
| | |
use class to specify the middleware [ci skip]
|
| |
| |
| |
| | |
using string for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a
|
|/
|
|
|
|
|
|
|
|
|
|
| |
The runtime header is a potential target for timing attacks since it
returns the amount of time spent on the server (eliminating network
speed). Total time is also not accurate for streaming responses.
The middleware can be added back via:
```ruby
config.middleware.ues ::Rack::Runtime
```
|
|
|
|
|
| |
This can still be added to the middleware stack, but is really not
necessary. I'll follow up with a commit that deprecates the constant
|
|
|
|
|
|
|
|
|
|
|
| |
As of 56903585, the Rack::ContentLength middleware isn't included by
default anymore.
The only remaining middleware is Rack::Lock ; since it's only included
when using WEBrick, it's certainly not worth documenting it in the
guides.
[ci skip]
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/configuring.md
|
| |
| |
| | |
[ci skip]
|
|/
|
|
| |
Rails::Rack::Debugger was removed in 93559da4826546d07014f8cfa399b64b4a143127
|
| |
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
|
|
|
|
| |
bebugger doesn't work with Ruby 2.2 so we don't need to support it
anymore
|
|
|
|
| |
References #18148.
|
|
|
|
|
|
| |
Allow static asset serving from env variable (enhanced!)
Conflicts:
railties/CHANGELOG.md
|
| |
|
|
|
|
| |
cc #17719
|
|
|
|
|
| |
ActionDispatch::Callbacks dose not run the prepare callbacks,
so change with comment on ActionDispatch::Callbacks.
|
|
|
|
|
|
|
|
|
| |
Add a section in the guide to explain that Rails can't auto-reload
a middleware on code change.
Fix #16806
[ci skip]
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
| |
References to ``AppName::Application` removed in favour of ``Rails.application``
as generated with a new rails 4.1 app.
[ci skip]
|
|
|
| |
[ci skip]
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
| |
[ci skip] Enumerable.instance_methods &
Rails::Configuration::MiddlewareStackProxy.instance_methods # =>
[:as_json]
MiddlewareStackProxy does not share any notable methods with Enumerable.
|
| |
|
| |
|
| |
|
| |
|
|\ |
|
| | |
|
|/
|
|
|
|
|
|
| |
Replaced <br /> with <br> for consistency; Added note about
singular/plural distinction (which was previously confusing to a Rails
noob); Rephrased explanation of how form is routed to controller, again
to reduce confusion; and added explanation to replace incorrect link.
[ci skip]
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Rack::Lock actually sets rack.multithread to `false`, not `true`.
Presumably because once inside the mutex, the app can function as if it were single threaded.
|
| |
|
|
|
|
|
| |
We have three or four different introduction sentences to the guides.
After this commit, we use the same one everywhere.
|
|
|
|
| |
Talked with @fxn about this. Bullet points should have periods at the ends.
|
|
|
| |
Specifically, remove `ActionDispatch::Head` in favor of `Rack::Head`.
|