aboutsummaryrefslogtreecommitdiffstats
path: root/guides/source/rails_on_rack.md
diff options
context:
space:
mode:
authorAaron Patterson <aaron.patterson@gmail.com>2015-10-03 14:21:31 -0700
committerAaron Patterson <aaron.patterson@gmail.com>2015-10-03 14:21:31 -0700
commit24f9c03d52ad4c7f081cc7a9561946109b3ad500 (patch)
tree32545119b6321671e890e5c8139bbbf99729430f /guides/source/rails_on_rack.md
parent99392112c5367f0556225fd84f9e41da88e3277e (diff)
downloadrails-24f9c03d52ad4c7f081cc7a9561946109b3ad500.tar.gz
rails-24f9c03d52ad4c7f081cc7a9561946109b3ad500.tar.bz2
rails-24f9c03d52ad4c7f081cc7a9561946109b3ad500.zip
Revert "removing Rack::Runtime from the default stack."
This reverts commit 37423e4ff883ad5584bab983aceb4b2b759a1fd8. Jeremy is right that we shouldn't remove this. The fact is that many engines are depending on this middleware to be in the default stack. This ties our hands and forces us to keep the middleware in the stack so that engines will work. To be extremely clear, I think this is another smell of "the rack stack" that we have in place. When manipulating middleware, we should have meaningful names for places in the req / res lifecycle **not** have engines depend on a particular constant be in a particular place in the stack. This is a weakness of the API that we have to figure out a way to address before removing the constant. As far as timing attacks are concerned, we can reduce the granularity such that it isn't useful information for hackers, but is still useful for developers.
Diffstat (limited to 'guides/source/rails_on_rack.md')
-rw-r--r--guides/source/rails_on_rack.md1
1 files changed, 1 insertions, 0 deletions
diff --git a/guides/source/rails_on_rack.md b/guides/source/rails_on_rack.md
index 1479e6f263..87f869aff3 100644
--- a/guides/source/rails_on_rack.md
+++ b/guides/source/rails_on_rack.md
@@ -106,6 +106,7 @@ use Rack::Sendfile
use ActionDispatch::Static
use Rack::Lock
use #<ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x000000029a0838>
+use Rack::Runtime
use Rack::MethodOverride
use ActionDispatch::RequestId
use Rails::Rack::Logger