aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #16232 from egilburg/activesupport_coverageRafael Mendonça França2014-07-2111-4/+114
|\ | | | | Added some missing activesupport test coverage
| * missing activesupport test coverageEugene Gilburg2014-07-1911-4/+114
| |
* | Remove not-required file class/subclassesAkshay Vishnoi2014-07-211-1/+0
|/
* Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-192-5/+2
|\ | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * Stop requiring mocha automaticallyRafael Mendonça França2014-07-192-5/+2
| | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | Prefer to pass block when logging.Guo Xiang Tan2014-07-181-1/+1
| | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
* | fix thread safety issuesAaron Patterson2014-07-171-4/+7
| | | | | | | | | | this test case had a race condition where it could download data multiple times. We'll download the data once at class load.
* | Fix typos in string_ext_test.rb [ci skip]Jon Atack2014-07-161-4/+4
| |
* | Merge pull request #16190 from oss92/word_truncationMatthew Draper2014-07-173-0/+49
|\ \ | | | | | | | | | Word truncation
| * | Added truncate_words method to activesupport stringsroot2014-07-163-0/+45
|/ /
* | Move uuid_v5 and uuid_v3 to Digest::UUIDRafael Mendonça França2014-07-155-76/+76
| | | | | | | | | | These methods are not random so they should not belings to SecureRandom module.
* | Add CHANGELOG entry for #13392 [ci skip]Rafael Mendonça França2014-07-151-0/+7
| |
* | Keep quietly and capture undeprecated on your suiteRafael Mendonça França2014-07-152-19/+34
| |
* | Deprecate reporting methods for silencing output as they aren't thread safeTom Meier2014-07-151-0/+10
| |
* | Fix tests broken in https://github.com/rails/rails/pull/16149Erik Michaels-Ober2014-07-121-1/+1
| |
* | Return an Enumerator if no block is givenErik Michaels-Ober2014-07-124-1/+49
| |
* | Don't construct a Proc if no block is givenErik Michaels-Ober2014-07-121-1/+1
| |
* | Silence the output downloading a fileRobin Dupret2014-07-111-1/+0
|/ | | | | This output isn't used anywhere for assertions so we can simply remove it. The introducing commit was f238d495.
* Fix ActiveSupport::Callbacks #set_callback docs.Nick Pellant2014-07-071-1/+1
| | | | | | A minor version breakage due to a rewrite of the callbacks code now requires an explicit block to be passed to #set_callback. This amends the documentation.
* Don't fail if unicode.org isn't talking to usMatthew Draper2014-07-051-1/+3
|
* :fire: these are lambdas now [ci skip]Godfrey Chan2014-07-031-9/+2
| | | This has changed since around 2b1500d6
* The hex escape sequence can be of any lengthGodfrey Chan2014-07-021-1/+1
|
* Fix escape_once double-escaping hex-encoded entitiesJohn F. Douthat2014-07-021-1/+1
| | | | (This is a manual merge of #9102)
* `DateTime#to_f` now preserves fractional seconds.John Paul Ashenfelter2014-07-023-2/+10
| | | | | | | Previously this method always returns `.0` in the fractional part. This commit changes it to preserve the fractional seconds instead. Fixes #15994.
* Add `Hash#map_values` to ActiveSupportSean Griffin2014-06-294-0/+76
| | | | | Didn't get a chance to convert existing code, I'll skim through the code base to make use of this later this afternoon.
* Tiny documentation fixes [ci skip]Robin Dupret2014-06-291-1/+1
|
* Quick pass through Active Support and guides CHANGELOGRobin Dupret2014-06-291-0/+2
| | | | [ci skip]
* Merge pull request #15943 from wagenet/cache-instrumentationRafael Mendonça França2014-06-272-11/+17
|\ | | | | | | Always instrument ActiveSupport::Cache
| * Always instrument ActiveSupport::CachePeter Wagenet2014-06-271-11/+10
| | | | | | | | | | | | | | | | The current approach is broken because it uses a thread local value which means on multi-threaded environments it has to be turned on per thread. Secondly, ActiveSupport::Notifications does not instrument items when there are not subscribers so this flag is unnecessary.
* | Update documentation for run_callbacksjamesprior2014-06-271-1/+2
| | | | | | In some cases run_callbacks will return nil. I'm attempting to update the documentation for the method to clarify.
* | Merge pull request #14247 from robin850/inflections-with-uncountablesRafael Mendonça França2014-06-263-5/+18
|\ \ | |/ |/| Make the apply_inflections method case-sensitive
| * Make the apply_inflections method case-sensitiveRobin Dupret2014-06-263-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since d3071db1, the apply_inflections method check if the downcased version of a string is contained inside the "whitelist" of uncountable words. However, if the word is composed of capital letters, it won't be matched in the list while it should. We can't simply revert to the previous behavior as there is a performance concern (benchmarked over /usr/share/dict/words): Before d3071db1 135.610000 0.290000 135.900000 (137.807081) Since d3071db1 22.170000 0.020000 22.190000 ( 22.530005) With the patch 22.060000 0.020000 22.080000 ( 22.125771) Benchmarked with http://git.io/aFnWig This way, the solution is to put the down-case version of words inside the @uncountables array.
* | :nodoc: our SecureRandom patches [ci skip]Godfrey Chan2014-06-261-4/+4
| | | | | | | | | | | | | | These methods shouldn't be added to `SecureRandom`, as they are neither secure nor random. The more appropriate place for this seems to be `Digest`, so we should move them there. (Pull request welcomed!) Marking this `:nodoc:` for now, so we don't accidentally ship it as public API. See https://github.com/rails/rails/pull/15306/files#r13055862 for details.
* | Merge pull request #15845 from robin850/jruby-isolationRafael Mendonça França2014-06-261-6/+16
|\ \ | |/ |/| Make the isolated tests run on JRuby
| * Make the isolated tests run on JRubyRobin Dupret2014-06-211-6/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As there is no forking on JRuby, we need to spawn sub-processes to make the tests run in isolation. Previously, we were defining globally env variables and running the test file through backticks and delete these variables once the test ran. Now, we simply rely on IO.popen as this is cross-platform and the env variables are available during the child-process execution only so there are no race conditions. [Ben Browning & Robin Dupret]
* | docs, fix BacktraceCleaner code example. Closes #15911. [ci skip]Yves Senn2014-06-251-1/+1
| |
* | Fix a bug where NameError#name returns a qualified name in stringYuki Nishijima2014-06-242-5/+5
| | | | | | | | | | | | | | Ruby's original behaviour is that : * It only returns a const name, not a qualified aname * It returns a symbol, not a string
* | Create with_env helper for tests.Zuhao Wan2014-06-221-14/+13
| |
* | Merge pull request #15856 from zuhao/refactor_activesupport_decoding_testYves Senn2014-06-221-11/+19
|\ \ | | | | | | Use with_parse_json_times helper in tests.
| * | Use with_parse_json_times helper in tests.Zuhao Wan2014-06-221-11/+19
| |/
* / Avoid hardcoded magic number in test teardown.Zuhao Wan2014-06-221-14/+19
|/
* Add regression test for NameError#nameArthur Neves2014-06-202-2/+5
|
* Make dependencies.rb add a name to NameErrorArthur Neves2014-06-202-4/+7
|
* Merge pull request #15799 from ↵Yves Senn2014-06-1810-122/+47
|\ | | | | | | | | zuhao/refactor_activesupport_time_zone_test_helpers Extract out with_env_tz helper method.
| * Extract out with_env_tz helper method.Zuhao Wan2014-06-1810-122/+47
| | | | | | | | | | It’s used at so many places that extracting it out into a helper file is worth doing.
* | Fix documentation from #15669 [ci skip]Zachary Scott2014-06-171-3/+5
| |
* | [ci skip] fix doc for the Hash#assert_valid_keysAditya Kapoor2014-06-171-3/+3
| |
* | Move test teardown into `ensure` block.Zuhao Wan2014-06-171-1/+2
|/
* Formatting fix in AS changelog [ci skip]Juanjo Bazán2014-06-161-2/+5
|
* Merge pull request #15684 from aditya-kapoor/add-tests-for-assert-valid-keysRafael Mendonça França2014-06-161-0/+15
|\ | | | | Add test cases for Hash#asset_valid_keys
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 02:40:08 +0000