diff options
| author | Guo Xiang Tan <tgx_world@hotmail.com> | 2014-07-18 14:27:08 +0800 |
|---|---|---|
| committer | Guo Xiang Tan <tgx_world@hotmail.com> | 2014-07-18 15:04:43 +0800 |
| commit | ee35b79d4cff24b960be54c3f5c4f46627c069fe (patch) | |
| tree | 51bf939c44a735fe9aad005f1f9c880a396bbc73 /activesupport | |
| parent | d4c8068675f0b6be025590471b40ff175daa845e (diff) | |
| download | rails-ee35b79d4cff24b960be54c3f5c4f46627c069fe.tar.gz rails-ee35b79d4cff24b960be54c3f5c4f46627c069fe.tar.bz2 rails-ee35b79d4cff24b960be54c3f5c4f46627c069fe.zip | |
Prefer to pass block when logging.
The Logger by default includes a guard which checks for the
logging level. By removing the custom logging guards, we can decouple
the logging guard from the logging action to be done.
This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
Diffstat (limited to 'activesupport')
| -rw-r--r-- | activesupport/lib/active_support/testing/tagged_logging.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activesupport/lib/active_support/testing/tagged_logging.rb b/activesupport/lib/active_support/testing/tagged_logging.rb index f4cee64091..843ce4a867 100644 --- a/activesupport/lib/active_support/testing/tagged_logging.rb +++ b/activesupport/lib/active_support/testing/tagged_logging.rb @@ -6,7 +6,7 @@ module ActiveSupport attr_writer :tagged_logger def before_setup - if tagged_logger + if tagged_logger && tagged_logger.info? heading = "#{self.class}: #{name}" divider = '-' * heading.size tagged_logger.info divider |