| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
A few have been left for aesthetic reasons, but have made a pass
and removed most of them.
Note that if the method `foo` returns an array, `foo << 1`
is a regular push, nothing to do with assignments, so
no self required.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since 434df00 week durations are no longer converted to days. This means
we need to add :weeks to the parts that ActiveSupport::TimeWithZone will
consider being of variable duration to take account of DST transitions.
Fixes #26039.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
#25874 was squashed before merging [skip ci]
|
|\ \ \ \
| | | | |
| | | | | |
Adds `not_in?` onto Object
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
The exclamation mark is not a metacharacter.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Where appropriate prefer the more concise Regexp#match?, String#include?,
String#start_with?, and String#end_with?
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Some casual benchmarks showed a 2x factor.
All credit goes to @nurse.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
See the rationale in the documentation included in this patch.
We are going to gradually introduce this predicate in the code base.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
AEAD modes like `aes-256-gcm` provide both confidentiality and data authenticity, eliminating the need to use MessageVerifier to check if the encrypted data has been tampered with.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
|\ \ \ \
| | | | |
| | | | | |
Add missing tests for memory store of cache.
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Introduce `assert_changes` and `assert_no_changes`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Those are assertions that I really do miss from the standard
`ActiveSupport::TestCase`. Think of those as a more general version of
`assert_difference` and `assert_no_difference` (those can be implemented
by assert_changes, should this change be accepted).
Why do we need those? They are useful when you want to check a
side-effect of an operation. `assert_difference` do cover a really
common case, but we `assert_changes` gives us more control. Having a
global error flag? You can test it easily with `assert_changes`. In
fact, you can be really specific about the initial state and the
terminal one.
```ruby
error = Error.new(:bad)
assert_changes -> { Error.current }, from: nil, to: error do
expected_bad_operation
end
```
`assert_changes` follows `assert_difference` and a string can be given
for evaluation as well.
```ruby
error = Error.new(:bad)
assert_changes 'Error.current', from: nil, to: error do
expected_bad_operation
end
```
Check out the test cases if you wanna see more examples.
:beers:
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
mechanicles/clear-local-cache-on-invalid-parameters-error
Add missing test for clearing up local cache on invalid parameters error.
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | | |
Add missing test for clearing up local cache and check response should
be present on invalid parameters error.
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
The minitest stubs were conflicting with the time travel stubs so the
travel_back method call in the teardown block was actually keeping the
time stubbed.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Wrap module around lazy load hooks
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix for issue https://github.com/rails/rails/issues/25784
Prior to this commit the lazy_load_hooks.rb file contained important lazy load
hooks. Since [7c90d91](https://github.com/rails/rails/commit/7c90d91c3c43bdbba25d38589aed0e2940af3bc8) the [documentation](http://api.rubyonrails.org/files/activesupport/lib/active_support/lazy_load_hooks_rb.html) did not display
the comments in this file as the docs for load hooks.
This commit wraps the code within this file in a module so we can display the
documentation for `ActiveSupport` load hooks. By extending `ActiveSupport` with
this module, all the methods within it should still be accessible through
`ActiveSupport`.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This test was added to protect the test suite from our mistakes but now
it is failing because bundler does add duplicated libs in the load path
by design (if the repository has more than one gem)
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The current implementation serializes zero-length durations incorrectly (it serializes as `"-P"`), and cannot un-serialize itself:
```
[1] pry(main)> ActiveSupport::Duration.parse(0.minutes.iso8601)
ActiveSupport::Duration::ISO8601Parser::ParsingError: Invalid ISO 8601 duration: "-P" is empty duration
from /Users/rando/.gem/ruby/2.3.1/gems/activesupport-5.0.0/lib/active_support/duration/iso8601_parser.rb:96:in `raise_parsing_error'
```
Postgres empty intervals are serialized as `"PT0S"`, which is also parseable by the Duration deserializer, so I've modified the `ISO8601Serializer` to do the same.
Additionally, the `#normalize` function returned a negative sign if `parts` was blank (all zero). Even though this fix does not rely on the sign, I've gone ahead and corrected that, too, in case a future refactoring of `#serialize` uses it.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Pathname might not be always initialized.
|
| | |/
| |/|
| | |
| | | |
Require 'pathname' explicitly
|
|\ \ \
| | | |
| | | | |
`travel/travel_to` travel time helpers, now raise on nested calls
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
as this can lead to confusing time stubbing.
Instead of:
travel_to 2.days.from_now do
# 2 days from today
travel_to 3.days.from_now do
# 5 days from today
end
end
preferred way to achieve above is:
travel_to 2.days.from_now
# 2 days from today
travel_back
travel_to 5.days.from_now
# 5 days from today
Closes #24690
Fixes #24689
|
|\ \ \ \
| | | | |
| | | | | |
Dry downloader
|
| | | | | |
|
| | |/ /
| |/| | |
|
|/ / /
| | |
| | |
| | | |
Require 'pathname' explicitly
|
|\ \ \
| |/ /
|/| | |
Do not depend on Rails git repository layout in ActiveSupport tests.
|
| | | |
|