Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Only define Objetc#itself when it is not defined | Rafael Mendonça França | 2014-08-04 | 1 | -8/+10 |
| | | | | | | | Ruby 2.2 will include Kernel#itself so we don't need to define again. See https://github.com/ruby/ruby/commit/0a0160d6b659f6131a525fe1579e7c463d4c197e | ||||
* | Rename tests too | Rafael Mendonça França | 2014-08-01 | 1 | -2/+2 |
| | |||||
* | Rename Object#self to Object#itself to have parity with matz sanctioned ↵ | David Heinemeier Hansson | 2014-08-01 | 4 | -6/+6 |
| | | | | method name for Ruby 2.2 | ||||
* | Added Object#self which returns the object itself | David Heinemeier Hansson | 2014-08-01 | 4 | -0/+26 |
| | |||||
* | Fix assertion arguments order | Carlos Antonio da Silva | 2014-07-31 | 1 | -1/+1 |
| | |||||
* | Avoid creating an extra hash | Carlos Antonio da Silva | 2014-07-31 | 1 | -2/+2 |
| | |||||
* | Merge pull request #16356 from gchan/add-hwia-tests | Yves Senn | 2014-07-31 | 1 | -0/+12 |
|\ | | | | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block | ||||
| * | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵ | Gordon Chan | 2014-07-31 | 1 | -0/+12 |
| | | | | | | | | initialized with a block | ||||
* | | Raise a descriptive error if non-positive integer passed to in_groups_of. | Xavier Shay | 2014-07-30 | 2 | -0/+11 |
|/ | | | | | | | | | | This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still. | ||||
* | Merge pull request #16352 from gchan/remove-unnecessary-convert-key | Carlos Antonio da Silva | 2014-07-30 | 1 | -2/+2 |
|\ | | | | | Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash' | ||||
| * | Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash' | Gordon Chan | 2014-07-31 | 1 | -2/+2 |
| | | | | | | | | All the keys are already Strings by virtue of being a HashWithIndifferentAccess. | ||||
* | | Prevent using String#scrub on Rubinius | Robin Dupret | 2014-07-30 | 1 | -1/+2 |
| | | | | | | | | | | | | Rubinius' has built-in support for String#scrub but it doesn't have yet support for ASCII-incompatible chars so for now, we should rely on the old implementation of #tidy_bytes. | ||||
* | | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require" | Santiago Pastorino | 2014-07-30 | 1 | -0/+2 |
|/ | | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343 | ||||
* | Add implicit receiver support to `Object#with_options` | Pavel Pravosud | 2014-07-29 | 3 | -2/+29 |
| | |||||
* | Add missing test case for Array#to_sentence, collect all test cases for ↵ | Akshay Vishnoi | 2014-07-29 | 2 | -24/+16 |
| | | | | Object#to_param at one place and avoid repitition | ||||
* | Merge pull request #16334 from akshay-vishnoi/array-tests | Rafael Mendonça França | 2014-07-29 | 7 | -482/+495 |
|\ | | | | | Move array test files under array | ||||
| * | Move array test files under array | Akshay Vishnoi | 2014-07-29 | 7 | -482/+495 |
| | | |||||
* | | Fixed a compatibility issue with the `Oj` gem | Godfrey Chan | 2014-07-29 | 2 | -3/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | `Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a delegation that is set up in `active_support/json/encoding`. We cannot simply require that file in `core_ext/object/json` because it would cause a circular dependency problem (see #12203 for background). We should instead rely on AS's autoload to load that file for us on-demand. To trigger autoload correctly, we need to reference the `AS::JSON::Encoding` constant instead of using the delegated version. Fixes #16131. | ||||
* | | Added failing test case for #16131 | Godfrey Chan | 2014-07-29 | 1 | -0/+42 |
| | | |||||
* | | Merge pull request #15629 from akshay-vishnoi/test-to_param | Rafael Mendonça França | 2014-07-28 | 4 | -66/+81 |
|\ \ | |/ |/| | Define Hash#to_query and set Hash#to_param as alias to it; with test cases | ||||
| * | Move to_param to to_query, also Improve tests | Akshay Vishnoi | 2014-06-20 | 4 | -66/+81 |
| | | |||||
* | | Move object test files under object | Akshay Vishnoi | 2014-07-29 | 3 | -65/+65 |
| | | |||||
* | | Make HWIA copy the default proc too. | Arthur Neves | 2014-07-24 | 3 | -0/+16 |
| | | | | | | | | [fixes #16279] | ||||
* | | Do not set enforce_available_locales to i18n 0.7 | Rafael Mendonça França | 2014-07-23 | 2 | -4/+2 |
| | | | | | | | | | | | | Now the default is always true. Users still can set it using config.i18n.enforce_available_locales. | ||||
* | | Merge pull request #16232 from egilburg/activesupport_coverage | Rafael Mendonça França | 2014-07-21 | 11 | -4/+114 |
|\ \ | | | | | | | Added some missing activesupport test coverage | ||||
| * | | missing activesupport test coverage | Eugene Gilburg | 2014-07-19 | 11 | -4/+114 |
| | | | |||||
* | | | Remove not-required file class/subclasses | Akshay Vishnoi | 2014-07-21 | 1 | -1/+0 |
|/ / | |||||
* | | Merge branch 'rm-remove-mocha' | Rafael Mendonça França | 2014-07-19 | 2 | -5/+2 |
|\ \ | | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb | ||||
| * | | Stop requiring mocha automatically | Rafael Mendonça França | 2014-07-19 | 2 | -5/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal | ||||
* | | | Prefer to pass block when logging. | Guo Xiang Tan | 2014-07-18 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance. | ||||
* | | | fix thread safety issues | Aaron Patterson | 2014-07-17 | 1 | -4/+7 |
| | | | | | | | | | | | | | | | this test case had a race condition where it could download data multiple times. We'll download the data once at class load. | ||||
* | | | Fix typos in string_ext_test.rb [ci skip] | Jon Atack | 2014-07-16 | 1 | -4/+4 |
| | | | |||||
* | | | Merge pull request #16190 from oss92/word_truncation | Matthew Draper | 2014-07-17 | 3 | -0/+49 |
|\ \ \ | | | | | | | | | | | | | Word truncation | ||||
| * | | | Added truncate_words method to activesupport strings | root | 2014-07-16 | 3 | -0/+45 |
|/ / / | |||||
* | | | Move uuid_v5 and uuid_v3 to Digest::UUID | Rafael Mendonça França | 2014-07-15 | 5 | -76/+76 |
| | | | | | | | | | | | | | | | These methods are not random so they should not belings to SecureRandom module. | ||||
* | | | Add CHANGELOG entry for #13392 [ci skip] | Rafael Mendonça França | 2014-07-15 | 1 | -0/+7 |
| | | | |||||
* | | | Keep quietly and capture undeprecated on your suite | Rafael Mendonça França | 2014-07-15 | 2 | -19/+34 |
| | | | |||||
* | | | Deprecate reporting methods for silencing output as they aren't thread safe | Tom Meier | 2014-07-15 | 1 | -0/+10 |
| | | | |||||
* | | | Fix tests broken in https://github.com/rails/rails/pull/16149 | Erik Michaels-Ober | 2014-07-12 | 1 | -1/+1 |
| | | | |||||
* | | | Return an Enumerator if no block is given | Erik Michaels-Ober | 2014-07-12 | 4 | -1/+49 |
| | | | |||||
* | | | Don't construct a Proc if no block is given | Erik Michaels-Ober | 2014-07-12 | 1 | -1/+1 |
| | | | |||||
* | | | Silence the output downloading a file | Robin Dupret | 2014-07-11 | 1 | -1/+0 |
|/ / | | | | | | | | | This output isn't used anywhere for assertions so we can simply remove it. The introducing commit was f238d495. | ||||
* | | Fix ActiveSupport::Callbacks #set_callback docs. | Nick Pellant | 2014-07-07 | 1 | -1/+1 |
| | | | | | | | | | | | | A minor version breakage due to a rewrite of the callbacks code now requires an explicit block to be passed to #set_callback. This amends the documentation. | ||||
* | | Don't fail if unicode.org isn't talking to us | Matthew Draper | 2014-07-05 | 1 | -1/+3 |
| | | |||||
* | | :fire: these are lambdas now [ci skip] | Godfrey Chan | 2014-07-03 | 1 | -9/+2 |
| | | | | | | This has changed since around 2b1500d6 | ||||
* | | The hex escape sequence can be of any length | Godfrey Chan | 2014-07-02 | 1 | -1/+1 |
| | | |||||
* | | Fix escape_once double-escaping hex-encoded entities | John F. Douthat | 2014-07-02 | 1 | -1/+1 |
| | | | | | | | | (This is a manual merge of #9102) | ||||
* | | `DateTime#to_f` now preserves fractional seconds. | John Paul Ashenfelter | 2014-07-02 | 3 | -2/+10 |
| | | | | | | | | | | | | | | Previously this method always returns `.0` in the fractional part. This commit changes it to preserve the fractional seconds instead. Fixes #15994. | ||||
* | | Add `Hash#map_values` to ActiveSupport | Sean Griffin | 2014-06-29 | 4 | -0/+76 |
| | | | | | | | | | | Didn't get a chance to convert existing code, I'll skim through the code base to make use of this later this afternoon. | ||||
* | | Tiny documentation fixes [ci skip] | Robin Dupret | 2014-06-29 | 1 | -1/+1 |
| | |