aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Avoid mutating the constants in a test caseAkira Matsuda2014-08-162-6/+4
|
* Avoid polluting String class globally in a test caseAkira Matsuda2014-08-161-8/+13
|
* Unused ivar in a test suiteAkira Matsuda2014-08-161-1/+0
|
* AS tests are now order_independent!Akira Matsuda2014-08-131-5/+0
|
* Reset ActiveSupport::Dependencies.mechanism to make tests order independentAkira Matsuda2014-08-131-6/+10
|
* Duplicated method in the test helperAkira Matsuda2014-08-131-7/+0
|
* Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-123-2/+6
|
* CHANGELOG entry for TestCase.i_suck_and_my_tests_are_order_dependent! fixAkira Matsuda2014-08-121-0/+6
|
* Remove old setup from AS test caseCarlos Antonio da Silva2014-08-121-5/+0
| | | | | This was added back in Rails 3 on c4a6109286909c394e8c5bfc471a1eb9de245d2b, and is not being used anymore.
* users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-122-4/+5
| | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* Docs: grammar fix for fetch. [ci skip]Mike Coutermarsh2014-08-081-1/+1
|
* Fix the #const_regexp's documentation [ci skip]Robin Dupret2014-08-081-3/+4
| | | | | | Originally introduced in f9086d63, the documentation of this method is wrong as #const_regexp returns a string to easy the interpolation inside regular expressions.
* remove dead file_watcher codeGregory Ostermayr2014-08-071-36/+0
|
* Fix DateTime comparison with DateTime::Infinity objectRafael Mendonça França2014-08-063-1/+8
| | | | Fixes #16406
* Fix AS docs / changelog with wrong method [ci skip]Carlos Antonio da Silva2014-08-052-3/+3
|
* Update itself.rb [ci skip]Jon Atack2014-08-051-1/+1
|
* Only define Objetc#itself when it is not definedRafael Mendonça França2014-08-041-8/+10
| | | | | | | Ruby 2.2 will include Kernel#itself so we don't need to define again. See https://github.com/ruby/ruby/commit/0a0160d6b659f6131a525fe1579e7c463d4c197e
* Rename tests tooRafael Mendonça França2014-08-011-2/+2
|
* Rename Object#self to Object#itself to have parity with matz sanctioned ↵David Heinemeier Hansson2014-08-014-6/+6
| | | | method name for Ruby 2.2
* Added Object#self which returns the object itselfDavid Heinemeier Hansson2014-08-014-0/+26
|
* Fix assertion arguments orderCarlos Antonio da Silva2014-07-311-1/+1
|
* Avoid creating an extra hashCarlos Antonio da Silva2014-07-311-2/+2
|
* Merge pull request #16356 from gchan/add-hwia-testsYves Senn2014-07-311-0/+12
|\ | | | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block
| * Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵Gordon Chan2014-07-311-0/+12
| | | | | | | | initialized with a block
* | Raise a descriptive error if non-positive integer passed to in_groups_of.Xavier Shay2014-07-302-0/+11
|/ | | | | | | | | | This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still.
* Merge pull request #16352 from gchan/remove-unnecessary-convert-keyCarlos Antonio da Silva2014-07-301-2/+2
|\ | | | | Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash'
| * Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash'Gordon Chan2014-07-311-2/+2
| | | | | | | | All the keys are already Strings by virtue of being a HashWithIndifferentAccess.
* | Prevent using String#scrub on RubiniusRobin Dupret2014-07-301-1/+2
| | | | | | | | | | | | Rubinius' has built-in support for String#scrub but it doesn't have yet support for ASCII-incompatible chars so for now, we should rely on the old implementation of #tidy_bytes.
* | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require"Santiago Pastorino2014-07-301-0/+2
|/ | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343
* Add implicit receiver support to `Object#with_options`Pavel Pravosud2014-07-293-2/+29
|
* Add missing test case for Array#to_sentence, collect all test cases for ↵Akshay Vishnoi2014-07-292-24/+16
| | | | Object#to_param at one place and avoid repitition
* Merge pull request #16334 from akshay-vishnoi/array-testsRafael Mendonça França2014-07-297-482/+495
|\ | | | | Move array test files under array
| * Move array test files under arrayAkshay Vishnoi2014-07-297-482/+495
| |
* | Fixed a compatibility issue with the `Oj` gemGodfrey Chan2014-07-292-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | `Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a delegation that is set up in `active_support/json/encoding`. We cannot simply require that file in `core_ext/object/json` because it would cause a circular dependency problem (see #12203 for background). We should instead rely on AS's autoload to load that file for us on-demand. To trigger autoload correctly, we need to reference the `AS::JSON::Encoding` constant instead of using the delegated version. Fixes #16131.
* | Added failing test case for #16131Godfrey Chan2014-07-291-0/+42
| |
* | Merge pull request #15629 from akshay-vishnoi/test-to_paramRafael Mendonça França2014-07-284-66/+81
|\ \ | |/ |/| Define Hash#to_query and set Hash#to_param as alias to it; with test cases
| * Move to_param to to_query, also Improve testsAkshay Vishnoi2014-06-204-66/+81
| |
* | Move object test files under objectAkshay Vishnoi2014-07-293-65/+65
| |
* | Make HWIA copy the default proc too.Arthur Neves2014-07-243-0/+16
| | | | | | | | [fixes #16279]
* | Do not set enforce_available_locales to i18n 0.7Rafael Mendonça França2014-07-232-4/+2
| | | | | | | | | | | | Now the default is always true. Users still can set it using config.i18n.enforce_available_locales.
* | Merge pull request #16232 from egilburg/activesupport_coverageRafael Mendonça França2014-07-2111-4/+114
|\ \ | | | | | | Added some missing activesupport test coverage
| * | missing activesupport test coverageEugene Gilburg2014-07-1911-4/+114
| | |
* | | Remove not-required file class/subclassesAkshay Vishnoi2014-07-211-1/+0
|/ /
* | Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-192-5/+2
|\ \ | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * | Stop requiring mocha automaticallyRafael Mendonça França2014-07-192-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | | Prefer to pass block when logging.Guo Xiang Tan2014-07-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
* | | fix thread safety issuesAaron Patterson2014-07-171-4/+7
| | | | | | | | | | | | | | | this test case had a race condition where it could download data multiple times. We'll download the data once at class load.
* | | Fix typos in string_ext_test.rb [ci skip]Jon Atack2014-07-161-4/+4
| | |
* | | Merge pull request #16190 from oss92/word_truncationMatthew Draper2014-07-173-0/+49
|\ \ \ | | | | | | | | | | | | Word truncation
| * | | Added truncate_words method to activesupport stringsroot2014-07-163-0/+45
|/ / /