aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #16356 from gchan/add-hwia-testsYves Senn2014-07-311-0/+12
|\ \ | | | | | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block
| * | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵Gordon Chan2014-07-311-0/+12
| | | | | | | | | | | | initialized with a block
* | | Raise a descriptive error if non-positive integer passed to in_groups_of.Xavier Shay2014-07-302-0/+11
|/ / | | | | | | | | | | | | | | | | | | This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still.
* | Merge pull request #16352 from gchan/remove-unnecessary-convert-keyCarlos Antonio da Silva2014-07-301-2/+2
|\ \ | | | | | | Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash'
| * | Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash'Gordon Chan2014-07-311-2/+2
| | | | | | | | | | | | All the keys are already Strings by virtue of being a HashWithIndifferentAccess.
* | | Prevent using String#scrub on RubiniusRobin Dupret2014-07-301-1/+2
| | | | | | | | | | | | | | | | | | Rubinius' has built-in support for String#scrub but it doesn't have yet support for ASCII-incompatible chars so for now, we should rely on the old implementation of #tidy_bytes.
* | | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require"Santiago Pastorino2014-07-301-0/+2
|/ / | | | | | | | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343
* / Add implicit receiver support to `Object#with_options`Pavel Pravosud2014-07-293-2/+29
|/
* Add missing test case for Array#to_sentence, collect all test cases for ↵Akshay Vishnoi2014-07-292-24/+16
| | | | Object#to_param at one place and avoid repitition
* Merge pull request #16334 from akshay-vishnoi/array-testsRafael Mendonça França2014-07-297-482/+495
|\ | | | | Move array test files under array
| * Move array test files under arrayAkshay Vishnoi2014-07-297-482/+495
| |
* | Fixed a compatibility issue with the `Oj` gemGodfrey Chan2014-07-292-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | `Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a delegation that is set up in `active_support/json/encoding`. We cannot simply require that file in `core_ext/object/json` because it would cause a circular dependency problem (see #12203 for background). We should instead rely on AS's autoload to load that file for us on-demand. To trigger autoload correctly, we need to reference the `AS::JSON::Encoding` constant instead of using the delegated version. Fixes #16131.
* | Added failing test case for #16131Godfrey Chan2014-07-291-0/+42
| |
* | Merge pull request #15629 from akshay-vishnoi/test-to_paramRafael Mendonça França2014-07-284-66/+81
|\ \ | |/ |/| Define Hash#to_query and set Hash#to_param as alias to it; with test cases
| * Move to_param to to_query, also Improve testsAkshay Vishnoi2014-06-204-66/+81
| |
* | Move object test files under objectAkshay Vishnoi2014-07-293-65/+65
| |
* | Make HWIA copy the default proc too.Arthur Neves2014-07-243-0/+16
| | | | | | | | [fixes #16279]
* | Do not set enforce_available_locales to i18n 0.7Rafael Mendonça França2014-07-232-4/+2
| | | | | | | | | | | | Now the default is always true. Users still can set it using config.i18n.enforce_available_locales.
* | Merge pull request #16232 from egilburg/activesupport_coverageRafael Mendonça França2014-07-2111-4/+114
|\ \ | | | | | | Added some missing activesupport test coverage
| * | missing activesupport test coverageEugene Gilburg2014-07-1911-4/+114
| | |
* | | Remove not-required file class/subclassesAkshay Vishnoi2014-07-211-1/+0
|/ /
* | Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-192-5/+2
|\ \ | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * | Stop requiring mocha automaticallyRafael Mendonça França2014-07-192-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | | Prefer to pass block when logging.Guo Xiang Tan2014-07-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
* | | fix thread safety issuesAaron Patterson2014-07-171-4/+7
| | | | | | | | | | | | | | | this test case had a race condition where it could download data multiple times. We'll download the data once at class load.
* | | Fix typos in string_ext_test.rb [ci skip]Jon Atack2014-07-161-4/+4
| | |
* | | Merge pull request #16190 from oss92/word_truncationMatthew Draper2014-07-173-0/+49
|\ \ \ | | | | | | | | | | | | Word truncation
| * | | Added truncate_words method to activesupport stringsroot2014-07-163-0/+45
|/ / /
* | | Move uuid_v5 and uuid_v3 to Digest::UUIDRafael Mendonça França2014-07-155-76/+76
| | | | | | | | | | | | | | | These methods are not random so they should not belings to SecureRandom module.
* | | Add CHANGELOG entry for #13392 [ci skip]Rafael Mendonça França2014-07-151-0/+7
| | |
* | | Keep quietly and capture undeprecated on your suiteRafael Mendonça França2014-07-152-19/+34
| | |
* | | Deprecate reporting methods for silencing output as they aren't thread safeTom Meier2014-07-151-0/+10
| | |
* | | Fix tests broken in https://github.com/rails/rails/pull/16149Erik Michaels-Ober2014-07-121-1/+1
| | |
* | | Return an Enumerator if no block is givenErik Michaels-Ober2014-07-124-1/+49
| | |
* | | Don't construct a Proc if no block is givenErik Michaels-Ober2014-07-121-1/+1
| | |
* | | Silence the output downloading a fileRobin Dupret2014-07-111-1/+0
|/ / | | | | | | | | This output isn't used anywhere for assertions so we can simply remove it. The introducing commit was f238d495.
* | Fix ActiveSupport::Callbacks #set_callback docs.Nick Pellant2014-07-071-1/+1
| | | | | | | | | | | | A minor version breakage due to a rewrite of the callbacks code now requires an explicit block to be passed to #set_callback. This amends the documentation.
* | Don't fail if unicode.org isn't talking to usMatthew Draper2014-07-051-1/+3
| |
* | :fire: these are lambdas now [ci skip]Godfrey Chan2014-07-031-9/+2
| | | | | | This has changed since around 2b1500d6
* | The hex escape sequence can be of any lengthGodfrey Chan2014-07-021-1/+1
| |
* | Fix escape_once double-escaping hex-encoded entitiesJohn F. Douthat2014-07-021-1/+1
| | | | | | | | (This is a manual merge of #9102)
* | `DateTime#to_f` now preserves fractional seconds.John Paul Ashenfelter2014-07-023-2/+10
| | | | | | | | | | | | | | Previously this method always returns `.0` in the fractional part. This commit changes it to preserve the fractional seconds instead. Fixes #15994.
* | Add `Hash#map_values` to ActiveSupportSean Griffin2014-06-294-0/+76
| | | | | | | | | | Didn't get a chance to convert existing code, I'll skim through the code base to make use of this later this afternoon.
* | Tiny documentation fixes [ci skip]Robin Dupret2014-06-291-1/+1
| |
* | Quick pass through Active Support and guides CHANGELOGRobin Dupret2014-06-291-0/+2
| | | | | | | | [ci skip]
* | Merge pull request #15943 from wagenet/cache-instrumentationRafael Mendonça França2014-06-272-11/+17
|\ \ | | | | | | | | | Always instrument ActiveSupport::Cache
| * | Always instrument ActiveSupport::CachePeter Wagenet2014-06-271-11/+10
| | | | | | | | | | | | | | | | | | | | | | | | The current approach is broken because it uses a thread local value which means on multi-threaded environments it has to be turned on per thread. Secondly, ActiveSupport::Notifications does not instrument items when there are not subscribers so this flag is unnecessary.
* | | Update documentation for run_callbacksjamesprior2014-06-271-1/+2
| | | | | | | | | In some cases run_callbacks will return nil. I'm attempting to update the documentation for the method to clarify.
* | | Merge pull request #14247 from robin850/inflections-with-uncountablesRafael Mendonça França2014-06-263-5/+18
|\ \ \ | |/ / |/| | Make the apply_inflections method case-sensitive
| * | Make the apply_inflections method case-sensitiveRobin Dupret2014-06-263-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since d3071db1, the apply_inflections method check if the downcased version of a string is contained inside the "whitelist" of uncountable words. However, if the word is composed of capital letters, it won't be matched in the list while it should. We can't simply revert to the previous behavior as there is a performance concern (benchmarked over /usr/share/dict/words): Before d3071db1 135.610000 0.290000 135.900000 (137.807081) Since d3071db1 22.170000 0.020000 22.190000 ( 22.530005) With the patch 22.060000 0.020000 22.080000 ( 22.125771) Benchmarked with http://git.io/aFnWig This way, the solution is to put the down-case version of words inside the @uncountables array.
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-04 06:27:03 +0000