Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Avoid mutating the constants in a test case | Akira Matsuda | 2014-08-16 | 2 | -6/+4 |
| | |||||
* | Avoid polluting String class globally in a test case | Akira Matsuda | 2014-08-16 | 1 | -8/+13 |
| | |||||
* | Unused ivar in a test suite | Akira Matsuda | 2014-08-16 | 1 | -1/+0 |
| | |||||
* | AS tests are now order_independent! | Akira Matsuda | 2014-08-13 | 1 | -5/+0 |
| | |||||
* | Reset ActiveSupport::Dependencies.mechanism to make tests order independent | Akira Matsuda | 2014-08-13 | 1 | -6/+10 |
| | |||||
* | Duplicated method in the test helper | Akira Matsuda | 2014-08-13 | 1 | -7/+0 |
| | |||||
* | Nobody sucks so nobody should call this awful method name | Rafael Mendonça França | 2014-08-12 | 3 | -2/+6 |
| | |||||
* | CHANGELOG entry for TestCase.i_suck_and_my_tests_are_order_dependent! fix | Akira Matsuda | 2014-08-12 | 1 | -0/+6 |
| | |||||
* | Remove old setup from AS test case | Carlos Antonio da Silva | 2014-08-12 | 1 | -5/+0 |
| | | | | | This was added back in Rails 3 on c4a6109286909c394e8c5bfc471a1eb9de245d2b, and is not being used anymore. | ||||
* | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent! | Akira Matsuda | 2014-08-12 | 2 | -4/+5 |
| | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework. | ||||
* | Docs: grammar fix for fetch. [ci skip] | Mike Coutermarsh | 2014-08-08 | 1 | -1/+1 |
| | |||||
* | Fix the #const_regexp's documentation [ci skip] | Robin Dupret | 2014-08-08 | 1 | -3/+4 |
| | | | | | | Originally introduced in f9086d63, the documentation of this method is wrong as #const_regexp returns a string to easy the interpolation inside regular expressions. | ||||
* | remove dead file_watcher code | Gregory Ostermayr | 2014-08-07 | 1 | -36/+0 |
| | |||||
* | Fix DateTime comparison with DateTime::Infinity object | Rafael Mendonça França | 2014-08-06 | 3 | -1/+8 |
| | | | | Fixes #16406 | ||||
* | Fix AS docs / changelog with wrong method [ci skip] | Carlos Antonio da Silva | 2014-08-05 | 2 | -3/+3 |
| | |||||
* | Update itself.rb [ci skip] | Jon Atack | 2014-08-05 | 1 | -1/+1 |
| | |||||
* | Only define Objetc#itself when it is not defined | Rafael Mendonça França | 2014-08-04 | 1 | -8/+10 |
| | | | | | | | Ruby 2.2 will include Kernel#itself so we don't need to define again. See https://github.com/ruby/ruby/commit/0a0160d6b659f6131a525fe1579e7c463d4c197e | ||||
* | Rename tests too | Rafael Mendonça França | 2014-08-01 | 1 | -2/+2 |
| | |||||
* | Rename Object#self to Object#itself to have parity with matz sanctioned ↵ | David Heinemeier Hansson | 2014-08-01 | 4 | -6/+6 |
| | | | | method name for Ruby 2.2 | ||||
* | Added Object#self which returns the object itself | David Heinemeier Hansson | 2014-08-01 | 4 | -0/+26 |
| | |||||
* | Fix assertion arguments order | Carlos Antonio da Silva | 2014-07-31 | 1 | -1/+1 |
| | |||||
* | Avoid creating an extra hash | Carlos Antonio da Silva | 2014-07-31 | 1 | -2/+2 |
| | |||||
* | Merge pull request #16356 from gchan/add-hwia-tests | Yves Senn | 2014-07-31 | 1 | -0/+12 |
|\ | | | | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block | ||||
| * | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵ | Gordon Chan | 2014-07-31 | 1 | -0/+12 |
| | | | | | | | | initialized with a block | ||||
* | | Raise a descriptive error if non-positive integer passed to in_groups_of. | Xavier Shay | 2014-07-30 | 2 | -0/+11 |
|/ | | | | | | | | | | This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still. | ||||
* | Merge pull request #16352 from gchan/remove-unnecessary-convert-key | Carlos Antonio da Silva | 2014-07-30 | 1 | -2/+2 |
|\ | | | | | Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash' | ||||
| * | Removed unnecessary call to 'convert_key' in 'HashWithIndifferentAccess#to_hash' | Gordon Chan | 2014-07-31 | 1 | -2/+2 |
| | | | | | | | | All the keys are already Strings by virtue of being a HashWithIndifferentAccess. | ||||
* | | Prevent using String#scrub on Rubinius | Robin Dupret | 2014-07-30 | 1 | -1/+2 |
| | | | | | | | | | | | | Rubinius' has built-in support for String#scrub but it doesn't have yet support for ASCII-incompatible chars so for now, we should rely on the old implementation of #tidy_bytes. | ||||
* | | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require" | Santiago Pastorino | 2014-07-30 | 1 | -0/+2 |
|/ | | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343 | ||||
* | Add implicit receiver support to `Object#with_options` | Pavel Pravosud | 2014-07-29 | 3 | -2/+29 |
| | |||||
* | Add missing test case for Array#to_sentence, collect all test cases for ↵ | Akshay Vishnoi | 2014-07-29 | 2 | -24/+16 |
| | | | | Object#to_param at one place and avoid repitition | ||||
* | Merge pull request #16334 from akshay-vishnoi/array-tests | Rafael Mendonça França | 2014-07-29 | 7 | -482/+495 |
|\ | | | | | Move array test files under array | ||||
| * | Move array test files under array | Akshay Vishnoi | 2014-07-29 | 7 | -482/+495 |
| | | |||||
* | | Fixed a compatibility issue with the `Oj` gem | Godfrey Chan | 2014-07-29 | 2 | -3/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | `Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a delegation that is set up in `active_support/json/encoding`. We cannot simply require that file in `core_ext/object/json` because it would cause a circular dependency problem (see #12203 for background). We should instead rely on AS's autoload to load that file for us on-demand. To trigger autoload correctly, we need to reference the `AS::JSON::Encoding` constant instead of using the delegated version. Fixes #16131. | ||||
* | | Added failing test case for #16131 | Godfrey Chan | 2014-07-29 | 1 | -0/+42 |
| | | |||||
* | | Merge pull request #15629 from akshay-vishnoi/test-to_param | Rafael Mendonça França | 2014-07-28 | 4 | -66/+81 |
|\ \ | |/ |/| | Define Hash#to_query and set Hash#to_param as alias to it; with test cases | ||||
| * | Move to_param to to_query, also Improve tests | Akshay Vishnoi | 2014-06-20 | 4 | -66/+81 |
| | | |||||
* | | Move object test files under object | Akshay Vishnoi | 2014-07-29 | 3 | -65/+65 |
| | | |||||
* | | Make HWIA copy the default proc too. | Arthur Neves | 2014-07-24 | 3 | -0/+16 |
| | | | | | | | | [fixes #16279] | ||||
* | | Do not set enforce_available_locales to i18n 0.7 | Rafael Mendonça França | 2014-07-23 | 2 | -4/+2 |
| | | | | | | | | | | | | Now the default is always true. Users still can set it using config.i18n.enforce_available_locales. | ||||
* | | Merge pull request #16232 from egilburg/activesupport_coverage | Rafael Mendonça França | 2014-07-21 | 11 | -4/+114 |
|\ \ | | | | | | | Added some missing activesupport test coverage | ||||
| * | | missing activesupport test coverage | Eugene Gilburg | 2014-07-19 | 11 | -4/+114 |
| | | | |||||
* | | | Remove not-required file class/subclasses | Akshay Vishnoi | 2014-07-21 | 1 | -1/+0 |
|/ / | |||||
* | | Merge branch 'rm-remove-mocha' | Rafael Mendonça França | 2014-07-19 | 2 | -5/+2 |
|\ \ | | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb | ||||
| * | | Stop requiring mocha automatically | Rafael Mendonça França | 2014-07-19 | 2 | -5/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal | ||||
* | | | Prefer to pass block when logging. | Guo Xiang Tan | 2014-07-18 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance. | ||||
* | | | fix thread safety issues | Aaron Patterson | 2014-07-17 | 1 | -4/+7 |
| | | | | | | | | | | | | | | | this test case had a race condition where it could download data multiple times. We'll download the data once at class load. | ||||
* | | | Fix typos in string_ext_test.rb [ci skip] | Jon Atack | 2014-07-16 | 1 | -4/+4 |
| | | | |||||
* | | | Merge pull request #16190 from oss92/word_truncation | Matthew Draper | 2014-07-17 | 3 | -0/+49 |
|\ \ \ | | | | | | | | | | | | | Word truncation | ||||
| * | | | Added truncate_words method to activesupport strings | root | 2014-07-16 | 3 | -0/+45 |
|/ / / |