aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
Commit message (Collapse)AuthorAgeFilesLines
* Bring back the test cases for `presence`Godfrey Chan2014-08-291-0/+5
| | | | This was removed by mistake in 5e51bdd
* We tenderized the wrong method! Object#try already had the yield option, ↵David Heinemeier Hansson2014-08-292-10/+4
| | | | just needed some tenderloving instance_eval to fit the bill
* Clarify the origin of this great addition to Rails :trollface: :trollface ↵David Heinemeier Hansson2014-08-291-1/+1
| | | | :trollface:
* Use instance_eval on @tenderlove's suggestion :trollface:David Heinemeier Hansson2014-08-291-2/+2
|
* Added yield to Object#presenceDavid Heinemeier Hansson2014-08-291-0/+5
|
* Keep the first string we fetchMatthew Draper2014-08-271-1/+1
| | | | Otherwise, it's possible for GC to run in between, and fail the test.
* [ci skip] use proper apostropheankit19102014-08-251-1/+1
|
* Skip #eql? tests on Rubinius for AS::DurationRobin Dupret2014-08-241-0/+3
| | | | | | | | | Since Rubinius is relying on #instance_of? for its definition of #eql? (http://git.io/MtmbbA) but ActiveSupport::Duration should behave like is_a? it returns true with `Fixnum`. Thus, for the moment, the last assertion is failing so we have to skip this test.
* Follow-up to #16560Robin Dupret2014-08-241-5/+6
| | | | | | | For the sake of backward-compatibility, we need to make #instance_of? return true for Fixnum. On the other hand, the method should still give true for ActiveSupport::Duration itself which was not the case before.
* Merge pull request #16560 from robin850/rbx-duration-eqlRafael Mendonça França2014-08-221-0/+5
|\ | | | | Define the Duration#instance_of? method
| * Define the Duration#instance_of? methodRobin Dupret2014-08-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Since Duration is extending from ProxyObject which extends itself from BasicObject, the Duration object doesn't respond to the #instance_of? method. Thus, the #method_missing hook get triggered, delegating the method to its `value` attribute. However, Rubinius' #eql? definition relies on #instance_of?, thus this will equal to true with a Fixnum (since its `value` attribute is a Fixnum) while it should not. The previous behavior was wrong anyway, no matter the implementation.
* | Fixes the digits counter of AS's NumberToRoundedConverterXavier Noria2014-08-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | Zero has one digit, but Math.log10(0) returns -Infinity. The method needs to special-case zero. The patch adds a regression test that is not clearly related to the underlying issue because digit_count is private and has no coverage. Gray area. This bug was uncovered by 60062cf.
* | Move as/test_test to as/test_case_testZachary Scott2014-08-191-0/+0
| |
* | Move date and time requires to time_travel_test, also includeZachary Scott2014-08-192-2/+4
| | | | | | | | | | | | 'abstract_unit'. cc #16564
* | Move TimeHelperTest to TimeTravelTest from `as/test_test.rb`Zachary Scott2014-08-192-69/+68
| |
* | "warning: assigned but unused variable"Akira Matsuda2014-08-191-1/+0
|/
* Expectations firstAkira Matsuda2014-08-181-4/+4
|
* Fix rounding errors with #travel_to by resetting the usec on any passed time ↵David Heinemeier Hansson2014-08-171-3/+10
| | | | to zero, so we only travel with per-second precision, not anything deeper than that.
* Avoid mutating the constants in a test caseAkira Matsuda2014-08-162-6/+4
|
* Avoid polluting String class globally in a test caseAkira Matsuda2014-08-161-8/+13
|
* Unused ivar in a test suiteAkira Matsuda2014-08-161-1/+0
|
* AS tests are now order_independent!Akira Matsuda2014-08-131-5/+0
|
* Reset ActiveSupport::Dependencies.mechanism to make tests order independentAkira Matsuda2014-08-131-6/+10
|
* Duplicated method in the test helperAkira Matsuda2014-08-131-7/+0
|
* Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-121-1/+1
|
* users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-121-0/+5
| | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* Fix DateTime comparison with DateTime::Infinity objectRafael Mendonça França2014-08-061-0/+1
| | | | Fixes #16406
* Rename tests tooRafael Mendonça França2014-08-011-2/+2
|
* Rename Object#self to Object#itself to have parity with matz sanctioned ↵David Heinemeier Hansson2014-08-011-1/+1
| | | | method name for Ruby 2.2
* Added Object#self which returns the object itselfDavid Heinemeier Hansson2014-08-011-0/+9
|
* Fix assertion arguments orderCarlos Antonio da Silva2014-07-311-1/+1
|
* Merge pull request #16356 from gchan/add-hwia-testsYves Senn2014-07-311-0/+12
|\ | | | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block
| * Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵Gordon Chan2014-07-311-0/+12
| | | | | | | | initialized with a block
* | Raise a descriptive error if non-positive integer passed to in_groups_of.Xavier Shay2014-07-301-0/+6
|/ | | | | | | | | | This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still.
* Add implicit receiver support to `Object#with_options`Pavel Pravosud2014-07-291-0/+9
|
* Add missing test case for Array#to_sentence, collect all test cases for ↵Akshay Vishnoi2014-07-292-24/+16
| | | | Object#to_param at one place and avoid repitition
* Merge pull request #16334 from akshay-vishnoi/array-testsRafael Mendonça França2014-07-297-482/+495
|\ | | | | Move array test files under array
| * Move array test files under arrayAkshay Vishnoi2014-07-297-482/+495
| |
* | Added failing test case for #16131Godfrey Chan2014-07-291-0/+42
| |
* | Merge pull request #15629 from akshay-vishnoi/test-to_paramRafael Mendonça França2014-07-282-0/+22
|\ \ | |/ |/| Define Hash#to_query and set Hash#to_param as alias to it; with test cases
| * Move to_param to to_query, also Improve testsAkshay Vishnoi2014-06-202-0/+22
| |
* | Move object test files under objectAkshay Vishnoi2014-07-293-65/+65
| |
* | Make HWIA copy the default proc too.Arthur Neves2014-07-241-0/+11
| | | | | | | | [fixes #16279]
* | Merge pull request #16232 from egilburg/activesupport_coverageRafael Mendonça França2014-07-2111-4/+114
|\ \ | | | | | | Added some missing activesupport test coverage
| * | missing activesupport test coverageEugene Gilburg2014-07-1911-4/+114
| | |
* | | Remove not-required file class/subclassesAkshay Vishnoi2014-07-211-1/+0
|/ /
* | Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-191-0/+2
|\ \ | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * | Stop requiring mocha automaticallyRafael Mendonça França2014-07-191-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | | fix thread safety issuesAaron Patterson2014-07-171-4/+7
| | | | | | | | | | | | | | | this test case had a race condition where it could download data multiple times. We'll download the data once at class load.
* | | Fix typos in string_ext_test.rb [ci skip]Jon Atack2014-07-161-4/+4
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 23:44:37 +0000