diff options
| author | Robin Dupret <robin.dupret@gmail.com> | 2014-08-17 16:31:00 +0200 |
|---|---|---|
| committer | Robin Dupret <robin.dupret@gmail.com> | 2014-08-18 15:43:49 +0200 |
| commit | eb73d7dafa343507a60f765c43c748d6987ec652 (patch) | |
| tree | 4336d688de6658a22a6a039aa1a4d12585104005 /activesupport/test | |
| parent | b30b99c6158766a6b09e8d3b1f91938fc0884605 (diff) | |
| download | rails-eb73d7dafa343507a60f765c43c748d6987ec652.tar.gz rails-eb73d7dafa343507a60f765c43c748d6987ec652.tar.bz2 rails-eb73d7dafa343507a60f765c43c748d6987ec652.zip | |
Define the Duration#instance_of? method
Since Duration is extending from ProxyObject which extends itself from
BasicObject, the Duration object doesn't respond to the #instance_of?
method. Thus, the #method_missing hook get triggered, delegating the
method to its `value` attribute.
However, Rubinius' #eql? definition relies on #instance_of?, thus this
will equal to true with a Fixnum (since its `value` attribute is a
Fixnum) while it should not.
The previous behavior was wrong anyway, no matter the implementation.
Diffstat (limited to 'activesupport/test')
| -rw-r--r-- | activesupport/test/core_ext/duration_test.rb | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/activesupport/test/core_ext/duration_test.rb b/activesupport/test/core_ext/duration_test.rb index 31af3c4521..330d995b7c 100644 --- a/activesupport/test/core_ext/duration_test.rb +++ b/activesupport/test/core_ext/duration_test.rb @@ -41,6 +41,11 @@ class DurationTest < ActiveSupport::TestCase assert !1.eql?(1.second) end + def test_instance_of + assert !1.minute.instance_of?(Fixnum) + assert !2.days.instance_of?(Fixnum) + end + def test_inspect assert_equal '0 seconds', 0.seconds.inspect assert_equal '1 month', 1.month.inspect |