rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \| \|	Methods are not duplicable.	Peter Jaros	2014-09-03	1	-1/+1
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Leave all our tests as order_dependent! for now	Matthew Draper	2014-09-02	1	-0/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa.
* \| \| \| \| \| \|	Use `safe_constantize`.	Guo Xiang Tan	2014-09-02	3	-0/+40
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes https://github.com/rails/rails/issues/9933.
* \| \| \| \| \| \|	Bring back the test cases for `presence`	Godfrey Chan	2014-08-29	1	-0/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This was removed by mistake in 5e51bdd
* \| \| \| \| \| \|	We tenderized the wrong method! Object#try already had the yield option, ↵	David Heinemeier Hansson	2014-08-29	2	-10/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	just needed some tenderloving instance_eval to fit the bill
* \| \| \| \| \| \|	Clarify the origin of this great addition to Rails :trollface: :trollface ↵	David Heinemeier Hansson	2014-08-29	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	:trollface:
* \| \| \| \| \| \|	Use instance_eval on @tenderlove's suggestion :trollface:	David Heinemeier Hansson	2014-08-29	1	-2/+2
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Added yield to Object#presence	David Heinemeier Hansson	2014-08-29	1	-0/+5
\| \|_\|/ / / / \|/\| \| \| \| \|
* \| \| \| \| \|	Keep the first string we fetch	Matthew Draper	2014-08-27	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Otherwise, it's possible for GC to run in between, and fail the test.
* \| \| \| \| \|	[ci skip] use proper apostrophe	ankit1910	2014-08-25	1	-1/+1
\| \| \| \| \| \|
* \| \| \| \| \|	Skip #eql? tests on Rubinius for AS::Duration	Robin Dupret	2014-08-24	1	-0/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Since Rubinius is relying on #instance_of? for its definition of #eql? (http://git.io/MtmbbA) but ActiveSupport::Duration should behave like is_a? it returns true with `Fixnum`. Thus, for the moment, the last assertion is failing so we have to skip this test.
* \| \| \| \| \|	Follow-up to #16560	Robin Dupret	2014-08-24	1	-5/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	For the sake of backward-compatibility, we need to make #instance_of? return true for Fixnum. On the other hand, the method should still give true for ActiveSupport::Duration itself which was not the case before.
* \| \| \| \| \|	Merge pull request #16560 from robin850/rbx-duration-eql	Rafael Mendonça França	2014-08-22	1	-0/+5
\|\ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Define the Duration#instance_of? method
\| * \| \| \| \| \|	Define the Duration#instance_of? method	Robin Dupret	2014-08-18	1	-0/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Since Duration is extending from ProxyObject which extends itself from BasicObject, the Duration object doesn't respond to the #instance_of? method. Thus, the #method_missing hook get triggered, delegating the method to its `value` attribute. However, Rubinius' #eql? definition relies on #instance_of?, thus this will equal to true with a Fixnum (since its `value` attribute is a Fixnum) while it should not. The previous behavior was wrong anyway, no matter the implementation.
* \| \| \| \| \| \|	Fixes the digits counter of AS's NumberToRoundedConverter	Xavier Noria	2014-08-20	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Zero has one digit, but Math.log10(0) returns -Infinity. The method needs to special-case zero. The patch adds a regression test that is not clearly related to the underlying issue because digit_count is private and has no coverage. Gray area. This bug was uncovered by 60062cf.
* \| \| \| \| \| \|	Move as/test_test to as/test_case_test	Zachary Scott	2014-08-19	1	-0/+0
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Move date and time requires to time_travel_test, also include	Zachary Scott	2014-08-19	2	-2/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	'abstract_unit'. cc #16564
* \| \| \| \| \| \|	Move TimeHelperTest to TimeTravelTest from `as/test_test.rb`	Zachary Scott	2014-08-19	2	-69/+68
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	"warning: assigned but unused variable"	Akira Matsuda	2014-08-19	1	-1/+0
\|/ / / / / /
* \| \| \| \| \|	Expectations first	Akira Matsuda	2014-08-18	1	-4/+4
\| \| \| \| \| \|
* \| \| \| \| \|	Fix rounding errors with #travel_to by resetting the usec on any passed time ↵	David Heinemeier Hansson	2014-08-17	1	-3/+10
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	to zero, so we only travel with per-second precision, not anything deeper than that.
* \| \| \| \| \|	Avoid mutating the constants in a test case	Akira Matsuda	2014-08-16	2	-6/+4
\| \| \| \| \| \|
* \| \| \| \| \|	Avoid polluting String class globally in a test case	Akira Matsuda	2014-08-16	1	-8/+13
\| \| \| \| \| \|
* \| \| \| \| \|	Unused ivar in a test suite	Akira Matsuda	2014-08-16	1	-1/+0
\| \| \| \| \| \|
* \| \| \| \| \|	AS tests are now order_independent!	Akira Matsuda	2014-08-13	1	-5/+0
\| \| \| \| \| \|
* \| \| \| \| \|	Reset ActiveSupport::Dependencies.mechanism to make tests order independent	Akira Matsuda	2014-08-13	1	-6/+10
\| \| \| \| \| \|
* \| \| \| \| \|	Duplicated method in the test helper	Akira Matsuda	2014-08-13	1	-7/+0
\| \| \| \| \| \|
* \| \| \| \| \|	Nobody sucks so nobody should call this awful method name	Rafael Mendonça França	2014-08-12	1	-1/+1
\| \| \| \| \| \|
* \| \| \| \| \|	users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!	Akira Matsuda	2014-08-12	1	-0/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* \| \| \| \| \|	Fix DateTime comparison with DateTime::Infinity object	Rafael Mendonça França	2014-08-06	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes #16406
* \| \| \| \| \|	Rename tests too	Rafael Mendonça França	2014-08-01	1	-2/+2
\| \| \| \| \| \|
* \| \| \| \| \|	Rename Object#self to Object#itself to have parity with matz sanctioned ↵	David Heinemeier Hansson	2014-08-01	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	method name for Ruby 2.2
* \| \| \| \| \|	Added Object#self which returns the object itself	David Heinemeier Hansson	2014-08-01	1	-0/+9
\| \| \| \| \| \|
* \| \| \| \| \|	Fix assertion arguments order	Carlos Antonio da Silva	2014-07-31	1	-1/+1
\| \| \| \| \| \|
* \| \| \| \| \|	Merge pull request #16356 from gchan/add-hwia-tests	Yves Senn	2014-07-31	1	-0/+12
\|\ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block
\| * \| \| \| \| \|	Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵	Gordon Chan	2014-07-31	1	-0/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	initialized with a block
* \| \| \| \| \| \|	Raise a descriptive error if non-positive integer passed to in_groups_of.	Xavier Shay	2014-07-30	1	-0/+6
\|/ / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still.
* \| \| \| \| \|	Add implicit receiver support to `Object#with_options`	Pavel Pravosud	2014-07-29	1	-0/+9
\| \| \| \| \| \|
* \| \| \| \| \|	Add missing test case for Array#to_sentence, collect all test cases for ↵	Akshay Vishnoi	2014-07-29	2	-24/+16
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Object#to_param at one place and avoid repitition
* \| \| \| \| \|	Merge pull request #16334 from akshay-vishnoi/array-tests	Rafael Mendonça França	2014-07-29	7	-482/+495
\|\ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Move array test files under array
\| * \| \| \| \| \|	Move array test files under array	Akshay Vishnoi	2014-07-29	7	-482/+495
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Added failing test case for #16131	Godfrey Chan	2014-07-29	1	-0/+42
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Merge pull request #15629 from akshay-vishnoi/test-to_param	Rafael Mendonça França	2014-07-28	2	-0/+22
\|\ \ \ \ \ \ \ \| \|/ / / / / / \|/\| \| \| \| \| \|	Define Hash#to_query and set Hash#to_param as alias to it; with test cases
\| * \| \| \| \| \|	Move to_param to to_query, also Improve tests	Akshay Vishnoi	2014-06-20	2	-0/+22
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Move object test files under object	Akshay Vishnoi	2014-07-29	3	-65/+65
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Make HWIA copy the default proc too.	Arthur Neves	2014-07-24	1	-0/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[fixes #16279]
* \| \| \| \| \| \|	Merge pull request #16232 from egilburg/activesupport_coverage	Rafael Mendonça França	2014-07-21	11	-4/+114
\|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Added some missing activesupport test coverage
\| * \| \| \| \| \| \|	missing activesupport test coverage	Eugene Gilburg	2014-07-19	11	-4/+114
\| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \|	Remove not-required file class/subclasses	Akshay Vishnoi	2014-07-21	1	-1/+0
\|/ / / / / / /
* \| \| \| \| \| \|	Merge branch 'rm-remove-mocha'	Rafael Mendonça França	2014-07-19	1	-0/+2
\|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Conflicts: actionpack/test/abstract_unit.rb