Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Privatize unneededly protected methods in Active Support | Akira Matsuda | 2016-12-24 | 1 | -2/+1 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
| | |||||
* | Remove deprecated key_file_path | Andrew White | 2016-11-13 | 1 | -8/+0 |
| | |||||
* | Merge pull request #25628 from ysksn/options | Rafael Mendonça França | 2016-08-17 | 1 | -1/+1 |
|\ | | | | | | | Remove parameter "options = nil" for #clear | ||||
| * | Update CHANGELOG.md for #25628 [ci skip] | Yosuke Kabuto | 2016-07-02 | 1 | -1/+1 |
| | | | | | | | | | | | | Move new CHANGELOG entry top [ci skip] Remove parameter "options = nil" for #clear | ||||
* | | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | | applies new string literal convention in activesupport/lib | Xavier Noria | 2016-08-06 | 1 | -7/+7 |
|/ | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Merge pull request #22278 from poporul/master | Godfrey Chan | 2016-01-15 | 1 | -3/+9 |
|\ | | | | | Allow to store .keep file in cache directory | ||||
| * | Allow to store .keep file in cache directory | Alexey Pokhozhaev | 2015-11-13 | 1 | -3/+9 |
| | | |||||
* | | add deprecations for a smooth transition after #22215 | Michael Grosser | 2015-11-19 | 1 | -0/+8 |
| | | |||||
* | | keep deprecated namespaced_key in case any subclass uses it | Michael Grosser | 2015-11-10 | 1 | -1/+1 |
| | | |||||
* | | send normalized keys to the cache backends so they do not need to manage ↵ | Michael Grosser | 2015-11-10 | 1 | -15/+13 |
|/ | | | | this themselves | ||||
* | use prepend instead of extending every instance | Michael Grosser | 2015-11-06 | 1 | -1/+1 |
| | | | | | extending an instance with a module puts the methods on top of it, prepend does the same but on the class level, so less work for us and more standard way of doing things | ||||
* | when checking for too long cache keys used the uri encoded fname | Cedric Sohrauer | 2015-04-24 | 1 | -3/+4 |
| | |||||
* | Allow AS::Cache::FileStore#clear without cache directory | Kohei Suzuki | 2015-04-09 | 1 | -0/+1 |
| | | | | | | Currently `Rails.cache.clear` raises Errno::ENOENT if it's run just after cloning a new Rails project. It should succeed without removing files or directories. | ||||
* | fix error with long keys in ActiveSupport::Cache::FileStore | Adam Panzer | 2014-06-10 | 1 | -0/+5 |
| | |||||
* | Copy-edit the parent commit | Rafael Mendonça França | 2013-12-12 | 1 | -6/+8 |
| | |||||
* | Merge pull request #13268 from aayushkhandelwal11/master | Rafael Mendonça França | 2013-12-12 | 1 | -22/+16 |
|\ | | | | | | | Moving the common code of increment and decrement of cache file store in... | ||||
| * | Moving the common code of increment and decrement of cache file store into ↵ | Aayush khandelwal | 2013-12-12 | 1 | -22/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | seprate function Removing the double checking for the value of id simplifying code for checking conditional code for key Removing the default values for parameters removing reduntant code and asiigning value of id in local variable removing wrongly added line break[ci ckip] reverting code | ||||
* | | typo rectified [skip ci] | Aayush khandelwal | 2013-12-11 | 1 | -1/+1 |
|/ | |||||
* | Merge pull request #11785 from grosser/grosser/file-unless-exist | Rafael Mendonça França | 2013-10-28 | 1 | -0/+1 |
|\ | | | | | | | | | | | | | | | support :unless_exist for FileCache Conflicts: activesupport/CHANGELOG.md activesupport/test/caching_test.rb | ||||
| * | support :unless_exist for FileCache | grosser | 2013-08-30 | 1 | -0/+1 |
| | | |||||
* | | Fix FileStore#cleanup to no longer rely on missing each_key method | Murray Steele | 2013-09-11 | 1 | -1/+2 |
|/ | |||||
* | Add documentation for FileStore#increment and #decrement | Matt Stopa | 2013-07-10 | 1 | -0/+4 |
| | | | | [ci skip] | ||||
* | Add documentation for #clear on certain Store classes | Matt Stopa | 2013-07-10 | 1 | -0/+1 |
| | | | | [ci skip | ||||
* | Update the filestore documentation for clear | Matt Stopa | 2013-07-09 | 1 | -0/+3 |
| | | | | [ci skip] | ||||
* | Fix deletion of empty directories: | Charles Jones | 2013-02-25 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | 1. When comparing the directory to delete against the top level cache_path, use File.realpath to make sure we aren't comparing two unequal strings that point to the same path. This occurs, for example, when cache_path has a trailing slash, which it does in the default Rails configuration. Since the input to delete_empty_directories never has a trailing slash, the comparison will never be true and the top level cache directory (and above) may be deleted. However… 2. File.delete raises EPERM when trying to delete a directory, so no directories have ever been deleted. Changing the code to Dir.delete fixes that. | ||||
* | Patched Marshal#load to work with constant autoloading ↵ | Uriel Katz | 2012-12-01 | 1 | -0/+1 |
| | | | | (active_support/dependecies.rb) (issue #8167) | ||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -4/+3 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | Merge pull request #5125 from winston/log_exception_when_cache_read_fails | Michael Koziarski | 2012-05-21 | 1 | -1/+2 |
|\ | | | | | #read_entry in ActiveSupport::Cache::FileStore should log details of the exception when an exception is thrown | ||||
| * | #read_entry in ActiveSupport::Cache::FileStore should log details of the ↵ | Winston | 2012-02-22 | 1 | -1/+2 |
| | | | | | | | | exception when an exception is thrown. | ||||
* | | Remove wrong rack/utils dependency from AS | Santiago Pastorino | 2012-05-12 | 1 | -3/+3 |
| | | | | | | | | Closes #6274 | ||||
* | | Merge pull request #4452 from tapajos/e5425c8f68fbb720fcbf4b14e1f154ac27dbbbed | Aaron Patterson | 2012-05-03 | 1 | -1/+1 |
|\ \ | | | | | | | Fix cache (FileStore) clear to keep .gitkeep. | ||||
| * | | Cache (FileStore) clear should keep .gitkeep | Marcos Tapajos | 2012-01-13 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #4911 from Floppy/master | Aaron Patterson | 2012-03-30 | 1 | -1/+1 |
|\ \ \ | |_|/ |/| | | Reduce FILENAME_MAX_SIZE in ActiveSupport::Cache::FileStore | ||||
| * | | Change FILENAME_MAX_SIZE in FileStore to 228. | James Smith | 2012-02-06 | 1 | -1/+1 |
| |/ | | | | | | | In order that temp filenames generated from it will fit in 255 chars. See https://github.com/rails/rails/issues/4907 | ||||
* / | Bug: cache_path.size doesn't return length of filename but size of file if ↵ | Issei Naruta | 2012-02-21 | 1 | -1/+1 |
|/ | | | | cache_path is Pathname. | ||||
* | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-13 | 1 | -1/+1 |
| | |||||
* | Revert "Fix "in memory" where it should be "in-memory"." | Vijay Dev | 2011-11-11 | 1 | -1/+1 |
| | | | | | | This reverts commit e34e4d43301618307f94123d3710f094297f91f3. Reason: code changes are not allowed in docrails. | ||||
* | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-11 | 1 | -1/+1 |
| | |||||
* | Refactor ActiveSupport::Cache::FileStore. used method and deleted duplicate ↵ | kennyj | 2011-10-30 | 1 | -3/+4 |
| | | | | code. | ||||
* | Added fix so that file store does not raise an exception when cache dir does ↵ | Philippe Huibonhoa | 2011-09-29 | 1 | -0/+1 |
| | | | | not exist yet. This can happen if a delete_matched is called before anything is saved in the cache. | ||||
* | No need to create a range object | Santiago Pastorino | 2011-09-22 | 1 | -3/+3 |
| | |||||
* | Fixed issue in file store where it could create a filename that was too long ↵ | Philippe Huibonhoa | 2011-09-21 | 1 | -9/+8 |
| | | | | for the file system. (https://github.com/rails/rails/issues/3072) | ||||
* | Fix ActiveSupport::Cache::FileStore#file_path_key does not work if ↵ | Gonzalo Rodriguez | 2011-07-23 | 1 | -1/+1 |
| | | | | | | initialized with Pathname Port from 3-1-stable | ||||
* | Removed deprecated methods and related tests from ActiveSupport | Josh Kalderimis | 2011-05-25 | 1 | -13/+1 |
| | |||||
* | File should be open in read/write mode. When doing lock on a file. | Arun Agrawal | 2011-04-18 | 1 | -1/+1 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -2/+2 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -2/+2 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -2/+3 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. |