diff options
author | Philippe Huibonhoa <phuibonhoa@gmail.com> | 2011-09-21 21:00:46 -0700 |
---|---|---|
committer | Philippe Huibonhoa <phuibonhoa@gmail.com> | 2011-09-21 21:00:46 -0700 |
commit | 8d63678d1406c5518d437709af0fde717c0248d7 (patch) | |
tree | 823e14613a73667d99574824a3cd573fd6041e38 /activesupport/lib/active_support/cache/file_store.rb | |
parent | 51bef9d8fb0b4da7a104425ab8545e9331387743 (diff) | |
download | rails-8d63678d1406c5518d437709af0fde717c0248d7.tar.gz rails-8d63678d1406c5518d437709af0fde717c0248d7.tar.bz2 rails-8d63678d1406c5518d437709af0fde717c0248d7.zip |
Fixed issue in file store where it could create a filename that was too long for the file system. (https://github.com/rails/rails/issues/3072)
Diffstat (limited to 'activesupport/lib/active_support/cache/file_store.rb')
-rw-r--r-- | activesupport/lib/active_support/cache/file_store.rb | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/activesupport/lib/active_support/cache/file_store.rb b/activesupport/lib/active_support/cache/file_store.rb index f7c01948b4..ab2382d98c 100644 --- a/activesupport/lib/active_support/cache/file_store.rb +++ b/activesupport/lib/active_support/cache/file_store.rb @@ -13,6 +13,7 @@ module ActiveSupport attr_reader :cache_path DIR_FORMATTER = "%03X" + FILENAME_MAX_SIZE = 230 # max filename size on file system is 255, minus room for timestamp and random characters appended by Tempfile (used by atomic write) def initialize(cache_path, options = nil) super(options) @@ -129,15 +130,13 @@ module ActiveSupport hash, dir_1 = hash.divmod(0x1000) dir_2 = hash.modulo(0x1000) fname_paths = [] - # Make sure file name is < 255 characters so it doesn't exceed file system limits. - if fname.size <= 255 - fname_paths << fname - else - while fname.size <= 255 - fname_path << fname[0, 255] - fname = fname[255, -1] - end - end + + # Make sure file name doesn't exceed file system limits. + begin + fname_paths << fname[0...FILENAME_MAX_SIZE] + fname = fname[FILENAME_MAX_SIZE..-1] + end until fname.blank? + File.join(cache_path, DIR_FORMATTER % dir_1, DIR_FORMATTER % dir_2, *fname_paths) end |