Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | prevent shadowing outer variables | Dorian Marié | 2017-12-25 | 1 | -4/+4 | |
| | ||||||
* | Active Storage: Fix direct uploads in IE 11 | Javan Makhmali | 2017-12-23 | 2 | -4/+18 | |
| | | | | | Fixes #31531 Closes #31540 | |||||
* | Merge pull request #31538 from ↵ | Eileen M. Uchitelle | 2017-12-22 | 1 | -2/+2 | |
|\ | | | | | | | | | yhirano55/add_cloud_service_links_to_readme_in_active_storage Add cloud service's links to README of Active Storage [ci skip] | |||||
| * | Add cloud service's links to README of Active Storage [ci skip] | Yoshiyuki Hirano | 2017-12-22 | 1 | -2/+2 | |
| | | ||||||
* | | Add support for combined MiniMagick transformations | Robert Glaser | 2017-12-22 | 2 | -6/+30 | |
| | | ||||||
* | | Merge pull request #31537 from yhirano55/pass_options_to_rails_blob_url | Rafael França | 2017-12-21 | 1 | -1/+1 | |
|\ \ | | | | | | | Pass options to rails_blob_url | |||||
| * | | Pass options to rails_blob_url | Yoshiyuki Hirano | 2017-12-22 | 1 | -1/+1 | |
| |/ | ||||||
* / | [ci skip] Remove needless from doc for ActiveStorage::Variant | Yoshiyuki Hirano | 2017-12-22 | 1 | -1/+1 | |
|/ | ||||||
* | Delete MiniMagick tempfile when transformation fails | George Claghorn | 2017-12-18 | 1 | -1/+7 | |
| | ||||||
* | Ensure MiniMagick tempfiles are properly unlinked after image transformation | George Claghorn | 2017-12-18 | 1 | -9/+18 | |
| | ||||||
* | Convert non-web image (e.g. PSD) variants to PNG | George Claghorn | 2017-12-18 | 3 | -12/+53 | |
| | ||||||
* | Update ActiveStorage::Blob#transformation docs [ci skip] | George Claghorn | 2017-12-16 | 1 | -3/+3 | |
| | ||||||
* | Handle invalid signed blob IDs gracefully | George Claghorn | 2017-12-15 | 7 | -18/+51 | |
| | ||||||
* | Restrict variants to variable image blobs | George Claghorn | 2017-12-15 | 4 | -4/+27 | |
| | ||||||
* | Merge branch 'master' into activestorage-guide | Jeffrey Guenther | 2017-12-14 | 9 | -20/+25 | |
|\ | ||||||
| * | Merge pull request #31434 from olivierlacan/boot-feedback | Sean Griffin | 2017-12-14 | 1 | -0/+4 | |
| |\ | | | | | | | Provide instant feedback when booting Rails | |||||
| | * | Provide instant feedback when booting Rails | Olivier Lacan | 2017-12-13 | 1 | -0/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've noticed during pair/mob programming sessions with peers that despite the speed boosts provided by Bootsnap and Spring, there is a noticeable latency between firing a bin/rails server command and any feedback being provided to the console. Depending on the size of the application this lack of feedback can make it seem like something is wrong when Rails is simply busy initializing. This change may seem gratuitous but by just printing one line to STDOUT we're giving a clear signal to the Rails user that their command has been received and that Rails is indeed booting. It almost imperciptibly makes Rails feel more responsive. Sure the code doesn't look very fancy but there's no other appropriate place I could think of putting it than boot.rb. Compare these two GIFs of booting without and with this change: Before: ![Without Boot Feedback](https://user-images.githubusercontent.com/65950/33964140-721041fc-e025-11e7-9b25-9d839ce92977.gif) After: ![With Boot Feedback](https://user-images.githubusercontent.com/65950/33964151-79e12f86-e025-11e7-93e9-7a75c70d408f.gif) | |||||
| * | | Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the future | Ryuta Kamizono | 2017-12-14 | 1 | -4/+0 | |
| |/ | | | | | | | Follow up of #31432. | |||||
| * | Expose Active Storage routes | Mehmet Emin INAC | 2017-12-13 | 1 | -6/+6 | |
| | | ||||||
| * | Exclude ActiveStorage::Filename{#parameters,::Parameters} from API docs [ci ↵ | George Claghorn | 2017-12-13 | 2 | -2/+2 | |
| | | | | | | | | skip] | |||||
| * | Merge pull request #31391 from ↵ | Eileen M. Uchitelle | 2017-12-13 | 1 | -1/+5 | |
| |\ | | | | | | | | | | | | | 5t111111/fix-active_storage-installation-failure-in-engine Fix active_storage installation failure when in engine | |||||
| | * | Invoke app-prefixed active storage task when in engine | Hirofumi Wakasugi | 2017-12-13 | 1 | -1/+5 | |
| | | | ||||||
| * | | Fix optimizing GIF variants using mogrify's -layers option | George Claghorn | 2017-12-11 | 1 | -5/+7 | |
| | | | ||||||
| * | | Revert "Invoke mogrify once when transforming an image" | George Claghorn | 2017-12-11 | 1 | -8/+6 | |
| | | | | | | | | | | | | This reverts commit a80f81af055f02bf4625c90470aa90441cf6fc24. | |||||
| * | | Merge pull request #31399 from yhirano55/return_nil_if_raise_http_error | George Claghorn | 2017-12-11 | 1 | -1/+1 | |
| |\ \ | | | | | | | | | Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError` | |||||
| | * | | Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError` | Yoshiyuki Hirano | 2017-12-12 | 1 | -1/+1 | |
| | |/ | | | | | | | | | | | | | | | | | | | * If it raise error `Azure::Core::Http::HTTPError`, return `nil` instead of `false` in `ActiveStorage::Service::AzureStorageService#delete`. * Other services behave as same as this. | |||||
| * | | Invoke mogrify once when transforming an image | George Claghorn | 2017-12-11 | 1 | -6/+8 | |
| | | | | | | | | | | | | Execute a single mogrify command with multiple options rather than one command per option. Permit the use of all mogrify options, not just the ones that fall through to MiniMagick::Image#method_missing. | |||||
| * | | `webpack` is assigned but never used in webpack.config.js | Yoshiyuki Hirano | 2017-12-11 | 1 | -1/+0 | |
| |/ | | | | | | | * Removed webpack const, so it is assigned but never used in webpack.config.js. | |||||
* | | Merge branch 'master' into activestorage-guide | Jeffrey Guenther | 2017-12-08 | 17 | -39/+179 | |
|\| | ||||||
| * | Swap raw video width and height if angle is 90 or 270 degrees | George Claghorn | 2017-12-08 | 2 | -3/+15 | |
| | | ||||||
| * | Fix customizing Content-Type via GCS service URLs | George Claghorn | 2017-12-07 | 2 | -1/+21 | |
| | | ||||||
| * | Fix instrumention name: delete_prefixed like the others. | Kasper Timm Hansen | 2017-12-03 | 1 | -1/+1 | |
| | | ||||||
| * | Purge variants with their blobs | George Claghorn | 2017-12-02 | 10 | -31/+107 | |
| | | ||||||
| * | Make ASt previewer/analyzer binary paths configurable | George Claghorn | 2017-12-01 | 4 | -4/+32 | |
| | | ||||||
| * | Add ActiveStorage::Previewer#logger to match ActiveStorage::Analyzer#logger | George Claghorn | 2017-11-30 | 1 | -0/+4 | |
| | | ||||||
* | | Merge branch 'master' into activestorage-guide | Jeffrey Guenther | 2017-11-30 | 10 | -27/+44 | |
|\| | ||||||
| * | Use `credentials` instead of `keyfile` in GCS sevice | yuuji.yaginuma | 2017-11-29 | 2 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | The `keyfile` was renamed to `credentials` in `google-cloud-storage` 1.8.0. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/master/google-cloud-storage/CHANGELOG.md#180--2017-11-14 Although `keyfile` can still be used, but it looks like deprecate. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/ddf7b2a856d676316525eb581c1a4cc83ca6097b/google-cloud-storage/lib/google/cloud/storage.rb#L589...L590 Therefore, I think that should use `credentials` in newly generated applications. Ref: https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1802 | |||||
| * | Preparing for 5.2.0.beta2 release | Rafael Mendonça França | 2017-11-28 | 3 | -2/+9 | |
| | | ||||||
| * | Fix typos and add a few suggestions | Fatos Morina | 2017-11-28 | 1 | -0/+14 | |
| | | ||||||
| * | Include migration files in gem | yuuji.yaginuma | 2017-11-28 | 1 | -1/+1 | |
| | | | | | | | | Fixes #31245 | |||||
| * | Preparing for 5.2.0.beta1 release | Rafael Mendonça França | 2017-11-27 | 3 | -2/+4 | |
| | | ||||||
| * | Update yarn lock | Rafael Mendonça França | 2017-11-27 | 1 | -10/+0 | |
| | | ||||||
| * | Avoid connecting to GCS during app boot | George Claghorn | 2017-11-23 | 2 | -12/+14 | |
| | | ||||||
| * | Fix loading ActiveStorage::DiskController when CSRF protection is disabled ↵ | George Claghorn | 2017-11-21 | 1 | -1/+1 | |
| | | | | | | | | by default | |||||
* | | Merge branch 'master' into activestorage-guide | Jeffrey Guenther | 2017-11-21 | 1 | -10/+10 | |
|\| | ||||||
| * | Fix that some ASt route helpers silently discarded options | George Claghorn | 2017-11-21 | 1 | -10/+10 | |
| | | ||||||
* | | Merge branch 'master' into activestorage-guide | Jeffrey Guenther | 2017-11-20 | 9 | -17/+169 | |
|\| | ||||||
| * | Provide attachment writers | George Claghorn | 2017-11-20 | 2 | -0/+40 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | Permit creating a record and attaching files in a single step. # Before: User.create!(user_params.except(:avatar)).tap do |user| user.avatar.attach(user_params[:avatar]) end # After: User.create!(user_params) [Yoshiyuki Hirano & George Claghorn] | |||||
| * | Load 5.2 defaults in ASt dummy app | George Claghorn | 2017-11-20 | 1 | -1/+1 | |
| | | ||||||
| * | Fix direct uploads to local service | George Claghorn | 2017-11-20 | 3 | -0/+6 | |
| | | | | | | | | | | | | | | | | Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens. Closes #30290. [Shinichi Maeshima & George Claghorn] |