diff options
| author | yuuji.yaginuma <yuuji.yaginuma@gmail.com> | 2017-11-29 13:08:33 +0900 |
|---|---|---|
| committer | yuuji.yaginuma <yuuji.yaginuma@gmail.com> | 2017-11-29 13:17:04 +0900 |
| commit | 9d65ac30fde3977d4773ff6052f31b99a5084f0f (patch) | |
| tree | e08b107308b56d6a463ab380c064d9967707e583 /activestorage | |
| parent | 055493ce056a663a7b61ae4f88f657d1a355995d (diff) | |
| download | rails-9d65ac30fde3977d4773ff6052f31b99a5084f0f.tar.gz rails-9d65ac30fde3977d4773ff6052f31b99a5084f0f.tar.bz2 rails-9d65ac30fde3977d4773ff6052f31b99a5084f0f.zip | |
Use `credentials` instead of `keyfile` in GCS sevice
The `keyfile` was renamed to `credentials` in `google-cloud-storage` 1.8.0.
https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/master/google-cloud-storage/CHANGELOG.md#180--2017-11-14
Although `keyfile` can still be used, but it looks like deprecate.
https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/ddf7b2a856d676316525eb581c1a4cc83ca6097b/google-cloud-storage/lib/google/cloud/storage.rb#L589...L590
Therefore, I think that should use `credentials` in newly generated
applications.
Ref: https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1802
Diffstat (limited to 'activestorage')
| -rw-r--r-- | activestorage/lib/active_storage/service/gcs_service.rb | 2 | ||||
| -rw-r--r-- | activestorage/test/service/configurations.example.yml | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/activestorage/lib/active_storage/service/gcs_service.rb b/activestorage/lib/active_storage/service/gcs_service.rb index be6ddf32a0..fd9916634a 100644 --- a/activestorage/lib/active_storage/service/gcs_service.rb +++ b/activestorage/lib/active_storage/service/gcs_service.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +gem "google-cloud-storage", "~> 1.8" + require "google/cloud/storage" require "active_support/core_ext/object/to_query" diff --git a/activestorage/test/service/configurations.example.yml b/activestorage/test/service/configurations.example.yml index 56ed37be5d..43cc013bc8 100644 --- a/activestorage/test/service/configurations.example.yml +++ b/activestorage/test/service/configurations.example.yml @@ -7,7 +7,7 @@ # # gcs: # service: GCS -# keyfile: { +# credentials: { # type: "service_account", # project_id: "", # private_key_id: "", |