aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
Commit message (Collapse)AuthorAgeFilesLines
...
* Update ActiveStorage::Blob#transformation docs [ci skip]George Claghorn2017-12-161-3/+3
|
* Handle invalid signed blob IDs gracefullyGeorge Claghorn2017-12-157-18/+51
|
* Restrict variants to variable image blobsGeorge Claghorn2017-12-154-4/+27
|
* Merge branch 'master' into activestorage-guideJeffrey Guenther2017-12-149-20/+25
|\
| * Merge pull request #31434 from olivierlacan/boot-feedbackSean Griffin2017-12-141-0/+4
| |\ | | | | | | Provide instant feedback when booting Rails
| | * Provide instant feedback when booting RailsOlivier Lacan2017-12-131-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've noticed during pair/mob programming sessions with peers that despite the speed boosts provided by Bootsnap and Spring, there is a noticeable latency between firing a bin/rails server command and any feedback being provided to the console. Depending on the size of the application this lack of feedback can make it seem like something is wrong when Rails is simply busy initializing. This change may seem gratuitous but by just printing one line to STDOUT we're giving a clear signal to the Rails user that their command has been received and that Rails is indeed booting. It almost imperciptibly makes Rails feel more responsive. Sure the code doesn't look very fancy but there's no other appropriate place I could think of putting it than boot.rb. Compare these two GIFs of booting without and with this change: Before: ![Without Boot Feedback](https://user-images.githubusercontent.com/65950/33964140-721041fc-e025-11e7-9b25-9d839ce92977.gif) After: ![With Boot Feedback](https://user-images.githubusercontent.com/65950/33964151-79e12f86-e025-11e7-93e9-7a75c70d408f.gif)
| * | Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the futureRyuta Kamizono2017-12-141-4/+0
| |/ | | | | | | Follow up of #31432.
| * Expose Active Storage routesMehmet Emin INAC2017-12-131-6/+6
| |
| * Exclude ActiveStorage::Filename{#parameters,::Parameters} from API docs [ci ↵George Claghorn2017-12-132-2/+2
| | | | | | | | skip]
| * Merge pull request #31391 from ↵Eileen M. Uchitelle2017-12-131-1/+5
| |\ | | | | | | | | | | | | 5t111111/fix-active_storage-installation-failure-in-engine Fix active_storage installation failure when in engine
| | * Invoke app-prefixed active storage task when in engineHirofumi Wakasugi2017-12-131-1/+5
| | |
| * | Fix optimizing GIF variants using mogrify's -layers optionGeorge Claghorn2017-12-111-5/+7
| | |
| * | Revert "Invoke mogrify once when transforming an image"George Claghorn2017-12-111-8/+6
| | | | | | | | | | | | This reverts commit a80f81af055f02bf4625c90470aa90441cf6fc24.
| * | Merge pull request #31399 from yhirano55/return_nil_if_raise_http_errorGeorge Claghorn2017-12-111-1/+1
| |\ \ | | | | | | | | Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError`
| | * | Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError`Yoshiyuki Hirano2017-12-121-1/+1
| | |/ | | | | | | | | | | | | | | | | | | * If it raise error `Azure::Core::Http::HTTPError`, return `nil` instead of `false` in `ActiveStorage::Service::AzureStorageService#delete`. * Other services behave as same as this.
| * | Invoke mogrify once when transforming an imageGeorge Claghorn2017-12-111-6/+8
| | | | | | | | | | | | Execute a single mogrify command with multiple options rather than one command per option. Permit the use of all mogrify options, not just the ones that fall through to MiniMagick::Image#method_missing.
| * | `webpack` is assigned but never used in webpack.config.jsYoshiyuki Hirano2017-12-111-1/+0
| |/ | | | | | | * Removed webpack const, so it is assigned but never used in webpack.config.js.
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-12-0817-39/+179
|\|
| * Swap raw video width and height if angle is 90 or 270 degreesGeorge Claghorn2017-12-082-3/+15
| |
| * Fix customizing Content-Type via GCS service URLsGeorge Claghorn2017-12-072-1/+21
| |
| * Fix instrumention name: delete_prefixed like the others.Kasper Timm Hansen2017-12-031-1/+1
| |
| * Purge variants with their blobsGeorge Claghorn2017-12-0210-31/+107
| |
| * Make ASt previewer/analyzer binary paths configurableGeorge Claghorn2017-12-014-4/+32
| |
| * Add ActiveStorage::Previewer#logger to match ActiveStorage::Analyzer#loggerGeorge Claghorn2017-11-301-0/+4
| |
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-3010-27/+44
|\|
| * Use `credentials` instead of `keyfile` in GCS seviceyuuji.yaginuma2017-11-292-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | The `keyfile` was renamed to `credentials` in `google-cloud-storage` 1.8.0. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/master/google-cloud-storage/CHANGELOG.md#180--2017-11-14 Although `keyfile` can still be used, but it looks like deprecate. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/ddf7b2a856d676316525eb581c1a4cc83ca6097b/google-cloud-storage/lib/google/cloud/storage.rb#L589...L590 Therefore, I think that should use `credentials` in newly generated applications. Ref: https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1802
| * Preparing for 5.2.0.beta2 releaseRafael Mendonça França2017-11-283-2/+9
| |
| * Fix typos and add a few suggestionsFatos Morina2017-11-281-0/+14
| |
| * Include migration files in gemyuuji.yaginuma2017-11-281-1/+1
| | | | | | | | Fixes #31245
| * Preparing for 5.2.0.beta1 releaseRafael Mendonça França2017-11-273-2/+4
| |
| * Update yarn lockRafael Mendonça França2017-11-271-10/+0
| |
| * Avoid connecting to GCS during app bootGeorge Claghorn2017-11-232-12/+14
| |
| * Fix loading ActiveStorage::DiskController when CSRF protection is disabled ↵George Claghorn2017-11-211-1/+1
| | | | | | | | by default
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-211-10/+10
|\|
| * Fix that some ASt route helpers silently discarded optionsGeorge Claghorn2017-11-211-10/+10
| |
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-209-17/+169
|\|
| * Provide attachment writersGeorge Claghorn2017-11-202-0/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | Permit creating a record and attaching files in a single step. # Before: User.create!(user_params.except(:avatar)).tap do |user| user.avatar.attach(user_params[:avatar]) end # After: User.create!(user_params) [Yoshiyuki Hirano & George Claghorn]
| * Load 5.2 defaults in ASt dummy appGeorge Claghorn2017-11-201-1/+1
| |
| * Fix direct uploads to local serviceGeorge Claghorn2017-11-203-0/+6
| | | | | | | | | | | | | | | | Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens. Closes #30290. [Shinichi Maeshima & George Claghorn]
| * Permit attaching files to new recordsGeorge Claghorn2017-11-193-5/+53
| | | | | | | | Closes #31164.
| * Fix ASt CI failure with rack-test 0.7.1Ryuta Kamizono2017-11-201-1/+1
| | | | | | | | Due to https://github.com/rack-test/rack-test/commit/5fd3631078e7c73aaed7d4371f70fb2a79384be9.
| * Introduce ActiveStorage::Attached::{One,Many}#detachGeorge Claghorn2017-11-143-7/+40
| |
| * Preserve existing metadata when analyzing a blobGeorge Claghorn2017-11-133-3/+28
| | | | | | | | Closes #31138.
* | Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-098-23/+30
|\|
| * Remove needless block parameterGeorge Claghorn2017-11-071-1/+1
| |
| * Fix streaming downloads from S3/Azure StorageGeorge Claghorn2017-11-063-7/+17
| | | | | | Closes #31073.
| * Permit configuring Active Storage's job queueGeorge Claghorn2017-11-035-16/+13
| |
* | Fixes typo in docsJeffrey Guenther2017-11-021-1/+1
|/
* Allow third-party previewers/analyzers to customize their tempdirsGeorge Claghorn2017-11-022-3/+10
|
* Use the indicative mood consistently [ci skip]George Claghorn2017-10-221-1/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-28 18:36:12 +0000