aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Exercise stringify of database configurationsbogdanvlviv2018-10-051-0/+5
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since #33968 we stringify keys of database configuration This commit adds more assertions in order to ensure that and prevent any regression in the future. Currently, if remove `to_s` added in #33968 from `env_name.to_s` on the line (activerecord/lib/active_record/database_configurations.rb:107), there is no test that would fail. One of the added assertions should emphasize why we need this `to_s`. Follow up #33968
* | | | Remove `ignore_none: false` to assert no queries more strictlyRyuta Kamizono2018-10-057-31/+31
| | | | | | | | | | | | | | | | Follow up 811be477786455d144819a5e9fbb7f9f54b8da69.
* | | | Use `assert_no_queries` not to ignore BEGIN/COMMIT queriesRyuta Kamizono2018-10-0513-38/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `test_update_does_not_run_sql_if_record_has_not_changed` would pass without #18501 since `assert_queries` ignores BEGIN/COMMIT unless `ignore_none: true` is given. Since #32647, empty BEGIN/COMMIT is ommited. So we no longer need to use `assert_queries(0)` to ignore BEGIN/COMMIT in the queries.
* | | | Simplify the condition in `prepare_update_statement`Ryuta Kamizono2018-10-051-8/+2
| | | |
* | | | Restore `preloaders_for_one` methodRyuta Kamizono2018-10-051-5/+9
| | | | | | | | | | | | | | | | Since the above comment is for the `preloaders_for_one`.
* | | | failing test for eager loadingMatt Jones2018-10-041-0/+5
| | | | | | | | | | | | | | | | cherry-picked from https://github.com/rails/rails/pull/33763
* | | | Merge pull request #33938 from faucct/bugfix/preload_through_no_recordsEileen M. Uchitelle2018-10-042-28/+29
|\ \ \ \ | | | | | | | | | | ActiveRecord::Associations::Preloader should not fail to preload through missing records
| * | | | ActiveRecord::Associations::Preloader should not fail to preload through ↵Nikita Sokolov2018-10-022-28/+29
| | | | | | | | | | | | | | | | | | | | missing records
* | | | | Escape table name so that it can be used in regular expressionAidan Haran2018-10-041-1/+1
| | | | |
* | | | | Remove unreachable database warningEugene Kenny2018-10-041-15/+1
| | | | | | | | | | | | | | | | | | | | | | | | | `establish_connection` will never raise `ActiveRecord::NoDatabaseError`, because it doesn't connect to a database; it sets up a connection pool.
* | | | | Move test_fixtures and render_context to separate filesGannon McGibbon2018-10-033-214/+220
| | | | |
* | | | | Move UPDATE/DELETE with JOIN handling to the Arel sideRyuta Kamizono2018-10-035-106/+92
| | | | |
* | | | | Fix call sitesGannon McGibbon2018-10-022-6/+6
|/ / / /
* | | | Handle UPDATE/DELETE with OFFSET in ArelRyuta Kamizono2018-10-016-19/+35
| | | |
* | | | Merge pull request #23593 from meinac/add_index_option_for_change_tableRyuta Kamizono2018-10-013-0/+22
|\ \ \ \ | | | | | | | | | | | | | | | index option added for change_table migrations
| * | | | Index option added for change_table migrationsMehmet Emin INAC2018-09-223-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case if we want to add a column into the existing table with index on it, we have to add column and index in two seperate lines. With this feature we don't need to write an extra line to add index for column. We can just use `index` option. Old behaviour in action: ``` change_table(:languages) do |t| t.string :country_code t.index: :country_code end ``` New behaviour in action: ``` change_table(:languages) do |t| t.string :country_code, index: true end ``` Exactly same behaviour is already exist for `create_table` migrations.
* | | | | Merge pull request #32031 from yahonda/remove_redundant_freezeRyuta Kamizono2018-10-0119-42/+42
|\ \ \ \ \ | | | | | | | | | | | | Add `Style/RedundantFreeze` to remove redudant `.freeze`
| * | | | | Add `Style/RedundantFreeze` to remove redudant `.freeze`Yasuo Honda2018-09-2919-42/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Rails 6.0 will support Ruby 2.4.1 or higher `# frozen_string_literal: true` magic comment is enough to make string object frozen. This magic comment is enabled by `Style/FrozenStringLiteralComment` cop. * Exclude these files not to auto correct false positive `Regexp#freeze` - 'actionpack/lib/action_dispatch/journey/router/utils.rb' - 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb' It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333 Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed. * Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required - 'actionpack/test/controller/test_case_test.rb' - 'activemodel/test/cases/type/string_test.rb' - 'activesupport/lib/active_support/core_ext/string/strip.rb' - 'activesupport/test/core_ext/string_ext_test.rb' - 'railties/test/generators/actions_test.rb'
* | | | | | Place `PartialQuery` and `PartialQueryCollector` in the same fileRyuta Kamizono2018-09-302-24/+28
| | | | | |
* | | | | | Handle DELETE with LIMIT in ArelRyuta Kamizono2018-09-309-69/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MySQL supports DELETE with LIMIT and ORDER BY. https://dev.mysql.com/doc/refman/8.0/en/delete.html Before: ``` Post Destroy (1.0ms) DELETE FROM `posts` WHERE `posts`.`id` IN (SELECT `id` FROM (SELECT `posts`.`id` FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ?) __active_record_temp) [["author_id", 1], ["LIMIT", 1]] ``` After: ``` Post Destroy (0.4ms) DELETE FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ? [["author_id", 1], ["LIMIT", 1]] ```
* | | | | | `SQLString#compile` is no longer used since ↵Ryuta Kamizono2018-09-302-15/+5
| | | | | | | | | | | | | | | | | | | | | | | | 53521a9e39b9d8af4165d7703c36dc905f1f8f67
* | | | | | `visitor.accept` doesn't handle `&block`Ryuta Kamizono2018-09-301-2/+2
| | | | | |
* | | | | | Use private attr_reader in ArelRyuta Kamizono2018-09-303-6/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No longer needed workaround for Ruby 2.2 "private attribute?" warning. Related 6d63b5e49a399fe246afcebad45c3c962de268fa.
* | | | | | Remove `visit_Fixnum` and `visit_Bignum`Ryuta Kamizono2018-09-303-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | Follow up ae406cd633dab2cafbc0d1bb5922d1ca40056ea0.
* | | | | | Make `test_initialize_with_invalid_attribute` work correctlyyuuji.yaginuma2018-09-301-4/+6
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Originally specified attributes were only normal values, and `ActiveRecord::MultiparameterAssignmentErrors` did not occur. In addition, an assertion is performed only on rescue, even if an exception does not occur, the test passes. To avoid this use `assert_raise`.
* | | | | Refactor migrations_path command option to databaseGannon McGibbon2018-09-286-6/+35
| | | | |
* | | | | Bugfix ActiveRecord::Relation#merge special case of from clauseBogdan Gusiev2018-09-282-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | When one relation is merged into another that has a different base class merging `from_clause` causes invalid SQL to be generated
* | | | | Merge pull request #34006 from kamipo/remove_debug_codeRyuta Kamizono2018-09-281-10/+0
|\ \ \ \ \ | | | | | | | | | | | | Revert "record who created the node when $DEBUG is true"
| * | | | | Revert "record who created the node when $DEBUG is true"Ryuta Kamizono2018-09-281-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a1b72178714fbf0033fe076b7e51f57eff152bdd.
* | | | | | Extract `Arel.arel_node?` helper methodRyuta Kamizono2018-09-283-4/+7
|/ / / / /
* | | | | Remove `visit_Fixnum` and `visit_Bignum`Ryuta Kamizono2018-09-281-2/+0
| | | | | | | | | | | | | | | | | | | | Since Ruby 2.4 unified Fixnum and Bignum into Integer.
* | | | | Make `update_counters` preparableRyuta Kamizono2018-09-283-10/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ``` Topic Update All (0.4ms) UPDATE `topics` SET `topics`.`replies_count` = COALESCE(`topics`.`replies_count`, 0) + 1, `topics`.`updated_at` = '2018-09-27 18:34:05.068774' WHERE `topics`.`id` = ? [["id", 7]] ``` After: ``` Topic Update All (0.4ms) UPDATE `topics` SET `topics`.`replies_count` = COALESCE(`topics`.`replies_count`, 0) + ?, `topics`.`updated_at` = ? WHERE `topics`.`id` = ? [["replies_count", 1], ["updated_at", 2018-09-27 18:55:05 UTC], ["id", 7]] ```
* | | | | Merge pull request #33986 from matt17r/patch-1Gannon McGibbon2018-09-271-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Add missing rdoc +code+ tags [ci skip]
| * | | | | Add missing rdoc +code+ tagsMatthew LS2018-09-261-1/+1
| | |_|_|/ | |/| | |
* | | | | Make `update_all` preparableRyuta Kamizono2018-09-282-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ``` Pet Update All (0.8ms) UPDATE `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` SET `pets`.`name` = 'Bob' WHERE `toys`.`name` = ? [["name", "Bone"]] ``` After: ``` Pet Update All (1.1ms) UPDATE `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` SET `pets`.`name` = ? WHERE `toys`.`name` = ? [["name", "Bob"], ["name", "Bone"]] ```
* | | | | Merge pull request #31604 from fatkodima/reverting-transactionEileen M. Uchitelle2018-09-277-5/+86
|\ \ \ \ \ | | | | | | | | | | | | Fix `transaction` reverting for migrations
| * | | | | Fix `transaction` reverting for migrationsfatkodima2018-09-267-5/+86
| | | | | | | | | | | | | | | | | | | | | | | | [fatkodima & David Verhasselt]
* | | | | | Add migrations_paths option to model generatorGannon McGibbon2018-09-271-0/+1
| | | | | |
* | | | | | Avoid extra touch queries when counter cache is updatedRyuta Kamizono2018-09-272-6/+16
| | | | | | | | | | | | | | | | | | | | | | | | Since counter cache handles touch option too.
* | | | | | Refactor counter cache to extract `decrement_counters_before_last_save` on ↵Ryuta Kamizono2018-09-272-48/+31
| | | | | | | | | | | | | | | | | | | | | | | | the belongs_to association
* | | | | | Use -X when loading structure.sql via psqlJ Smith2018-09-272-4/+4
| | | | | |
* | | | | | Removed invalid -X flag for pg_dumpMatthias Winkelmann2018-09-272-8/+8
|/ / / / /
* | | | | Merge pull request #33983 from gmcgibbon/raise_if_fixture_path_blankRafael França2018-09-263-0/+21
|\ \ \ \ \ | | | | | | | | | | | | Raise an error when loading all fixtures from nil fixture_path
| * | | | | Raise an error when loading all fixtures from nil fixture_pathGannon McGibbon2018-09-263-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | [Gannon McGibbon + Max Albrecht]
* | | | | | Merge pull request #31819 from bpohoriletz/masterEileen M. Uchitelle2018-09-262-4/+29
|\ \ \ \ \ \ | | | | | | | | | | | | | | If association is a hash-like object preloading fails
| * | | | | | If association is a hash-like object preloading failsBohdan Pohorilets2018-09-262-4/+29
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | If you pass a hash-like object to preload associations (for example ActionController::Parameters) preloader will fail with the ArgumentError. This change allows passing objects that may be converted to a Hash or String into a preloader
* | | | | | Remove force parent loading when counter cache child is created/destroyedRyuta Kamizono2018-09-262-7/+7
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | `association.increment_counters` and `association.decrement_counters` works regardless of parent target is loaded or not. Related 52e11e462f6114a4d12225c639c5f501f0ffec7a.
* | | | | Revert "Remove `counter_cache_target` which is no longer called"Ryuta Kamizono2018-09-262-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 376ffe0ea2e59dc51461122210729c05a10fb443. Since 38fae1f, `association.increment_counters` is called without inflated parent target if inverse_of is disabled. In that case, that commit would cause extra queries to inflate parent.
* | | | | Update counter cache in memory if parent target is existedRyuta Kamizono2018-09-262-10/+35
|/ / / / | | | | | | | | | | | | Fixes #19550.
* | | | Fix "warning: shadowing outer local variable - config"yuuji.yaginuma2018-09-261-2/+2
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 01:22:43 +0000