Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #11230 from ↵ | Rafael Mendonça França | 2013-07-01 | 1 | -5/+0 |
|\ | | | | | | | | | frodsan/remove_deprecated_clear_stale_cached_connections_method Remove AR::Connection#clear_stale_cached_connections! deprecated method | ||||
| * | Remove deprecated AR::Connection#clear_stale_cached_connections! method | Francesco Rodriguez | 2013-07-01 | 1 | -5/+0 |
| | | |||||
* | | Removed deprecated method type_cast_code from Column | Neeraj Singh | 2013-07-02 | 2 | -24/+4 |
|/ | |||||
* | avoid intermediate zipped array | Aaron Patterson | 2013-07-01 | 1 | -3/+2 |
| | |||||
* | make the identity type a singleton to save on object creation | Aaron Patterson | 2013-07-01 | 2 | -3/+7 |
| | |||||
* | only deal with strings internally | Aaron Patterson | 2013-07-01 | 1 | -3/+3 |
| | |||||
* | Merge pull request #11222 from neerajdotname/removed-deprecation-for-sql | Rafael Mendonça França | 2013-07-01 | 5 | -41/+8 |
|\ | | | | | Removed deprecated options for assocations | ||||
| * | Removed deprecated options for assocations | Neeraj Singh | 2013-07-02 | 5 | -41/+8 |
| | | | | | | | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted. | ||||
* | | build an AST rather than slapping strings together | Aaron Patterson | 2013-07-01 | 1 | -11/+7 |
|/ | |||||
* | Remove deprecation messages about protected_attributes and rails-observers | Carlos Antonio da Silva | 2013-07-01 | 1 | -39/+0 |
| | |||||
* | stop exposing the underlying alias datastructure | Aaron Patterson | 2013-07-01 | 1 | -4/+4 |
| | |||||
* | we don't need to to_s the column | Aaron Patterson | 2013-07-01 | 1 | -1/+1 |
| | |||||
* | the data structure used to store attribute aliases should not be exposed | Aaron Patterson | 2013-07-01 | 1 | -2/+2 |
| | |||||
* | remove deprecated `ActiveRecord::Base#connection` method. | Yves Senn | 2013-07-01 | 3 | -12/+5 |
| | |||||
* | remove auto-explain-config deprecation warning | Yves Senn | 2013-07-01 | 2 | -11/+4 |
| | |||||
* | Remove deprecated `:distinct` option from `Relation#count`. | Yves Senn | 2013-07-01 | 3 | -15/+4 |
| | |||||
* | Removed deprecated methods partial_updates and family | Neeraj Singh | 2013-07-02 | 3 | -25/+5 |
| | | | | | Removed deprecated methods `partial_updates`, `partial_updates?` and `partial_updates=` | ||||
* | Merge pull request #11213 from neerajdotname/scoped-deprecated | Rafael Mendonça França | 2013-07-01 | 2 | -5/+4 |
|\ | | | | | | | | | | | | | Removed deprecated scoped method Conflicts: activerecord/CHANGELOG.md | ||||
| * | Removed deprecated method scoped | Neeraj Singh | 2013-07-01 | 2 | -5/+4 |
| | | |||||
* | | Removed deprecated method default_scopes? | Neeraj Singh | 2013-07-01 | 2 | -8/+4 |
|/ | |||||
* | don't shadow `through_scope` method name with local var. | Yves Senn | 2013-06-30 | 1 | -7/+7 |
| | |||||
* | remove deprecated implicit join references. | Yves Senn | 2013-06-29 | 6 | -87/+25 |
| | |||||
* | Merge pull request #11161 from dmitry/find_in_batches_works_without_logger | Carlos Antonio da Silva | 2013-06-28 | 2 | -2/+12 |
|\ | | | | | | | | | ActiveRecord find_in_batches should work without logger When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway. | ||||
| * | find_in_batches should work without logger | Dmitry Polushkin | 2013-06-28 | 2 | -2/+12 |
| | | |||||
* | | Remove order_values argument now that default_scope is simplified | Carlos Antonio da Silva | 2013-06-28 | 1 | -5/+5 |
| | | | | | | | | | | | | | | | | | | | | In 94924dc32baf78f13e289172534c2e71c9c8cade the internal default_scope implementation has changed making it simpler to follow, meaning that the old usage of with_default_scope has been removed. With that, order_values was the same argument for both calls to find_first_with_limit, so remove it and use the existent attribute for the sake of clarity/simplification. | ||||
* | | Simplify/fix implementation of default scopes | Jon Leighton | 2013-06-28 | 12 | -74/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation was necessary in order to support stuff like: class Post < ActiveRecord::Base default_scope where(published: true) scope :ordered, order("created_at") end If we didn't evaluate the default scope at the last possible moment before sending the SQL to the database, it would become impossible to do: Post.unscoped.ordered This is because the default scope would already be bound up in the "ordered" scope, and therefore wouldn't be removed by the "Post.unscoped" part. In 4.0, we have deprecated all "eager" forms of scopes. So now you must write: class Post < ActiveRecord::Base default_scope { where(published: true) } scope :ordered, -> { order("created_at") } end This prevents the default scope getting bound up inside the "ordered" scope, which means we can now have a simpler/better/more natural implementation of default scoping. A knock on effect is that some things that didn't work properly now do. For example it was previously impossible to use #except to remove a part of the default scope, since the default scope was evaluated after the call to #except. | ||||
* | | Apply default scope when joining associations. | Jon Leighton | 2013-06-28 | 3 | -0/+29 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example: class Post < ActiveRecord::Base default_scope -> { where published: true } end class Comment belongs_to :post end When calling `Comment.join(:post)`, we expect to receive only comments on published posts, since that is the default scope for posts. Before this change, the default scope from `Post` was not applied, so we'd get comments on unpublished posts. | ||||
* | | Fix test | Jon Leighton | 2013-06-28 | 1 | -1/+8 |
| | | | | | | | | | | Oops. We need to estalish/remove the connection in the setup/teardown, else it messes with the fixtures. | ||||
* | | Fix rake test_sqlite3_mem | Jon Leighton | 2013-06-28 | 2 | -11/+7 |
| | | | | | | | | Clearly nobody uses this except me. It's fast people! | ||||
* | | Merge pull request #11153 from strzalek/remove-ar-deprecated-finders | Jon Leighton | 2013-06-28 | 7 | -637/+7 |
|\ \ | | | | | | | Remove depreacted finders | ||||
| * | | Remove depreacted finders | Łukasz Strzałkowski | 2013-06-28 | 7 | -637/+7 |
| | | | | | | | | | | | | They were deprecated in 4.0, planned to remove in 4.1 | ||||
* | | | Fix indentation | Akira Matsuda | 2013-06-28 | 1 | -1/+1 |
| | | | |||||
* | | | Remove deprecated attr_protected/accessible | Łukasz Strzałkowski | 2013-06-27 | 1 | -1/+0 |
|/ / | | | | | | | Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters. | ||||
* | | activerecord/examples/simple.rb use master branch activesupport gem | tumayun | 2013-06-27 | 1 | -1/+1 |
| | | |||||
* | | fix activerecord/examples/performance.rb#L101 syntax error | tumayun | 2013-06-27 | 1 | -1/+1 |
| | | |||||
* | | Moving the `pluck` and `ids` methods to their own delegate line. | wangjohn | 2013-06-25 | 1 | -8/+9 |
| | | | | | | | | | | | | | | | | These two methods aren't really statistical helper methods and don't really belong in any other group which is being delegated for querying, so I'm moving them to their own group of methods. I've also changed the `:to => :all` hash syntax to `to: :all`. | ||||
* | | Fix @tenderlove's name in changelog :sparkles: | Carlos Antonio da Silva | 2013-06-26 | 1 | -2/+2 |
| | | | | | | | | [ci skip] | ||||
* | | Merge pull request #10730 from ↵ | Carlos Antonio da Silva | 2013-06-25 | 1 | -8/+9 |
|\ \ | | | | | | | | | | | | | tkhr/add_test_for_AR__CounterCache#update_counters Add test for AR::CounterCache.update_counters | ||||
| * | | Refactor AR's counter_cache_test.rb test | Takehiro Adachi | 2013-05-23 | 1 | -8/+3 |
| | | | |||||
| * | | Add test for AR::CounterCache.update_counters | Takehiro Adachi | 2013-05-23 | 1 | -0/+6 |
| | | | |||||
* | | | Add changelog entry for database tasks removal #10853 [ci skip] | Carlos Antonio da Silva | 2013-06-25 | 1 | -0/+4 |
| | | | |||||
* | | | Merge pull request #10853 from kennyj/deprecated-database_tasks | Carlos Antonio da Silva | 2013-06-25 | 7 | -433/+0 |
|\ \ \ | | | | | | | | | Remove Oracle / Sqlserver / Firebird database tasks were deprecated since 4.0. | ||||
| * | | | Remove FirebirdDatabaseTasks was deprecated, because this was provided by ↵ | kennyj | 2013-06-05 | 3 | -158/+0 |
| | | | | | | | | | | | | | | | | 3rd-party. | ||||
| * | | | Remove SqlseverDatabaseTasks was deprecated, because this was provided by ↵ | kennyj | 2013-06-05 | 3 | -136/+0 |
| | | | | | | | | | | | | | | | | 3rd-party. | ||||
| * | | | Remove OracleDatabaseTasks was deprecated, because this was provided by ↵ | kennyj | 2013-06-05 | 3 | -139/+0 |
| | | | | | | | | | | | | | | | | 3rd-party. | ||||
* | | | | Merge pull request #10992 from Empact/find-each-enumerator | Carlos Antonio da Silva | 2013-06-25 | 3 | -2/+36 |
|\ \ \ \ | | | | | | | | | | | | | | | | When .find_each is called without a block, return an Enumerator. | ||||
| * | | | | When .find_each is called without a block, return an Enumerator. | Ben Woosley | 2013-06-19 | 3 | -2/+36 |
| | | | | | | | | | | | | | | | | | | | | This lets us do things like call: .find_each.with_index | ||||
* | | | | | Merge pull request #10993 from Empact/result-each-enumerator | Carlos Antonio da Silva | 2013-06-25 | 3 | -1/+42 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Change Result#each to return an Enumerator when called without a block. | ||||
| * | | | | | Change Result#each to return an Enumerator when called without a block. | Ben Woosley | 2013-06-18 | 3 | -1/+43 |
| | | | | | | | | | | | | | | | | | | | | | | | | As with #10992, this lets us call #with_index, etc on the results. | ||||
* | | | | | | Merge pull request #11046 from arunagw/verbose_mode_on | Carlos Antonio da Silva | 2013-06-25 | 1 | -1/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Verbose mode on when running tests |