Merge pull request #10730 from tkhr/add_test_for_AR__CounterCache#update_counters

Add test for AR::CounterCache.update_counters

1 files changed, 9 insertions, 8 deletions

diff --git a/activerecord/test/cases/counter_cache_test.rb b/activerecord/test/cases/counter_cache_test.rb
index 61f9d4cdae..ee3d8a81c2 100644
--- a/activerecord/test/cases/counter_cache_test.rb
+++ b/activerecord/test/cases/counter_cache_test.rb
@@ -51,14 +51,9 @@ class CounterCacheTest < ActiveRecord::TestCase
     end
   end
 
-  test 'reset multiple association counters' do
-    Topic.increment_counter(:replies_count, @topic.id)
-    assert_difference '@topic.reload.replies_count', -1 do
-      Topic.reset_counters(@topic.id, :replies, :unique_replies)
-    end
-
-    Topic.increment_counter(:unique_replies_count, @topic.id)
-    assert_difference '@topic.reload.unique_replies_count', -1 do
+  test 'reset multiple counters' do
+    Topic.update_counters @topic.id, replies_count: 1, unique_replies_count: 1
+    assert_difference ['@topic.reload.replies_count', '@topic.reload.unique_replies_count'], -1 do
       Topic.reset_counters(@topic.id, :replies, :unique_replies)
     end
   end
@@ -127,6 +122,12 @@ class CounterCacheTest < ActiveRecord::TestCase
     end
   end
 
+  test 'update multiple counters' do
+    assert_difference ['@topic.reload.replies_count', '@topic.reload.unique_replies_count'], 2 do
+      Topic.update_counters @topic.id, replies_count: 2, unique_replies_count: 2
+    end
+  end
+
   test "update other counters on parent destroy" do
     david, joanna = dog_lovers(:david, :joanna)
     joanna = joanna # squelch a warning