aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* unscoped works with named scope [ci skip]Neeraj Singh2013-03-231-8/+0
| | | | | Update comment to reflect that unscoped works with named scope even when named scope is using without block form
* Merge branch 'schema'Aaron Patterson2013-03-2210-104/+230
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * schema: add uuid primary key support separate primary key from column type push the mysql add_column up to the abstract adapter allow multiple add columns pull add_column_options! off the pg connection class add a pg visitor for dealing with schema modification push alter table add column sql in to the schema modification visitor there is no reason to check for an already defined column push column initialization down to the factory method @columns list is no longer necessary keep ivars private, do not manipulate them outside their owner object factory methods should not alter object state push SQL generation inside the schema creation object mostly decouple TableDefinition from the database connection remove to_sql from TableDefinition decouple column definition from the database connection stop depending on sql_type in pg remove knowledge of SQL from the column definition object
| * add uuid primary key supportAaron Patterson2013-03-225-3/+30
| |
| * separate primary key from column typeAaron Patterson2013-03-221-10/+11
| |
| * push the mysql add_column up to the abstract adapterAaron Patterson2013-03-224-22/+35
| |
| * allow multiple add columnsAaron Patterson2013-03-223-6/+6
| |
| * pull add_column_options! off the pg connection classAaron Patterson2013-03-222-13/+13
| |
| * add a pg visitor for dealing with schema modificationAaron Patterson2013-03-221-4/+21
| |
| * push alter table add column sql in to the schema modification visitorAaron Patterson2013-03-223-14/+51
| |
| * there is no reason to check for an already defined columnAaron Patterson2013-03-221-1/+1
| |
| * push column initialization down to the factory methodAaron Patterson2013-03-221-13/+13
| |
| * @columns list is no longer necessaryAaron Patterson2013-03-221-8/+4
| |
| * keep ivars private, do not manipulate them outside their owner objectAaron Patterson2013-03-222-1/+5
| |
| * factory methods should not alter object stateAaron Patterson2013-03-221-5/+7
| |
| * push SQL generation inside the schema creation objectAaron Patterson2013-03-224-12/+20
| |
| * mostly decouple TableDefinition from the database connectionAaron Patterson2013-03-223-5/+5
| |
| * remove to_sql from TableDefinitionAaron Patterson2013-03-223-9/+5
| |
| * decouple column definition from the database connectionAaron Patterson2013-03-223-11/+11
| |
| * stop depending on sql_type in pgAaron Patterson2013-03-221-6/+8
| |
| * remove knowledge of SQL from the column definition objectAaron Patterson2013-03-223-24/+47
| |
* | squelch an unused variable warningAaron Patterson2013-03-221-0/+1
|/
* Merge pull request #9866 from choudhuryanupam/fix_connection_testCarlos Antonio da Silva2013-03-221-1/+1
|\ | | | | Removed unused loop variable
| * Removed unused loop variableAnupam Choudhury2013-03-221-1/+1
| |
* | Merge pull request #9867 from choudhuryanupam/fix_mysql2_active_schema_testCarlos Antonio da Silva2013-03-221-2/+1
|\ \ | | | | | | Removed unnecessary block
| * | Removed unnecessary blockAnupam Choudhury2013-03-221-2/+1
| | |
* | | test-case to prevent resetting associations when preloading twice.Yves Senn2013-03-221-0/+7
| | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/preloader/through_association.rb activerecord/test/cases/associations/eager_test.rb
* | | When we pass id to update_attributes it will try to set new id for that recordDmitry Vorotilin2013-03-224-2/+18
|/ /
* / Delete failing testJon Leighton2013-03-221-36/+0
|/ | | | | | | | | | | | I don't think this is testing anything useful, and the test code is exceedingly brittle. It is broken since 34c7e73c1def1312e59ef1f334586ff2f668246e because the test code makes assumptions about the implementation of PostgreSQLAdapter#active? which are incorrect after the commit. I could fix this test but it would be even more brittle (by stubbing the underlying @connection.connect_poll) and it doesn't test any complex logic. I conclude that it's not worth it.
* Allows setting fixture_path to a PathnameAlexander Murmann and Can Berk Güder2013-03-212-1/+10
|
* Adding a bang to method name of raise_on_type_mismatch.wangjohn2013-03-216-8/+8
|
* Merge pull request #9847 from vipulnsward/fix_sqlite_testRafael Mendonça França2013-03-211-1/+1
|\ | | | | Fix copy table index test; Change == to ! on false in travis.rb
| * Fix copy table index test; Change == to ! on false in travis.rbVipul A M2013-03-211-1/+1
| |
* | Update other counter caches on destroyIan Young2013-03-2011-9/+45
|/
* use `connect_poll` on pg so that reaping does not hurt the connectionAaron Patterson2013-03-202-3/+4
|
* Revert "default the reaping frequency to 10 seconds"Aaron Patterson2013-03-201-1/+1
| | | | | | | mysql can't handle a parallel thread pinging the connection, so we can get wrong results or segvs This reverts commit 7cc588b684f6d1af3e7fab1edfa6715e269e41a2.
* Merge pull request #9833 from choudhuryanupam/fix_active_schema_testCarlos Antonio da Silva2013-03-201-2/+1
|\ | | | | Removed unnecessary block
| * Removed unnecessary blockAnupam Choudhury2013-03-201-2/+1
| |
* | Properly named variable inside blockAnupam Choudhury2013-03-201-2/+2
|/ | | | Closes #9824.
* Merge pull request #9821 from vipulnsward/fix_typos_in_ARVijay Dev2013-03-205-6/+6
|\ | | | | Fix some typos in AR- CHANGELOG, tests, method doc. fixed
| * Fix some typos in AR- CHANGELOG, tests, method doc. fixedVipul A M2013-03-205-6/+6
| |
* | Fix a typoRajeev N Bharshetty2013-03-201-1/+1
|/
* Merge pull request #9818 from wangjohn/sort_last_to_max_in_migration_versionCarlos Antonio da Silva2013-03-191-1/+1
|\ | | | | Changed the call to .sort.last to .max when computing the migration version
| * Changed the call to .sort.last to .max when computing the migration version. Youwangjohn2013-03-191-1/+1
| | | | | | | | | | do not actually need to sort everything (incurs more cost than just a simple max).
* | Commas aren't comas.Josh Adams2013-03-191-2/+2
|/ | | | Type a fixo.
* Calling find() on an association with an inverse will now check to seewangjohn2013-03-193-2/+38
| | | | | if the association already holds that record in memory before checking the database for the specified ids.
* The repair_validations helper was not working correctly before becausewangjohn2013-03-191-2/+2
| | | | | | it only cleared the validations that created :validate callbacks. This didn't include the validates created by validates_with, so I've added a method to clear all validations.
* Revert "Merge pull request #9784 from ↵Carlos Antonio da Silva2013-03-181-4/+4
| | | | | | | | | | vipulnsward/change_from_blank_to_empty_on_string" This reverts commit 9c4c05fc82e997b722dec4068c3aa27eaee69eb8, reversing changes made to 4620bdcefd0c88905a005f191496df887877b8f3. Reason: They're not completely interchangeable, since blank? will also check for strings containing spaces.
* Merge pull request #9784 from vipulnsward/change_from_blank_to_empty_on_stringCarlos Antonio da Silva2013-03-181-4/+4
|\ | | | | Change from blank? to empty? on obvious string values to save extra calls
| * change from blank? to empty? on obvious string values to save extra method ↵Vipul A M2013-03-191-4/+4
| | | | | | | | calls
* | Fix failing tests related to where values change to stringsCarlos Antonio da Silva2013-03-181-7/+7
| | | | | | | | Introduced in 5dc2e3531babcbdc165884d1a47cbcd13455522d.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 04:19:45 +0000