diff options
author | Vipul A M <vipulnsward@gmail.com> | 2013-03-19 03:03:19 +0530 |
---|---|---|
committer | Vipul A M <vipulnsward@gmail.com> | 2013-03-19 03:03:19 +0530 |
commit | 9ff33fbec32e3f0692601bcd1895b8498df7883e (patch) | |
tree | 2d61407c29aa663f9cd8dab48f99806fa9ea2cd4 /activerecord | |
parent | 4e7292c0262ae70d968e0732bb6fea627646feef (diff) | |
download | rails-9ff33fbec32e3f0692601bcd1895b8498df7883e.tar.gz rails-9ff33fbec32e3f0692601bcd1895b8498df7883e.tar.bz2 rails-9ff33fbec32e3f0692601bcd1895b8498df7883e.zip |
change from blank? to empty? on obvious string values to save extra method calls
Diffstat (limited to 'activerecord')
-rw-r--r-- | activerecord/lib/active_record/connection_adapters/column.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/column.rb b/activerecord/lib/active_record/connection_adapters/column.rb index a4b3a0c584..609ccc2ed2 100644 --- a/activerecord/lib/active_record/connection_adapters/column.rb +++ b/activerecord/lib/active_record/connection_adapters/column.rb @@ -161,7 +161,7 @@ module ActiveRecord def value_to_date(value) if value.is_a?(String) - return nil if value.blank? + return nil if value.empty? fast_string_to_date(value) || fallback_string_to_date(value) elsif value.respond_to?(:to_date) value.to_date @@ -172,14 +172,14 @@ module ActiveRecord def string_to_time(string) return string unless string.is_a?(String) - return nil if string.blank? + return nil if string.empty? fast_string_to_time(string) || fallback_string_to_time(string) end def string_to_dummy_time(string) return string unless string.is_a?(String) - return nil if string.blank? + return nil if string.empty? dummy_time_string = "2000-01-01 #{string}" @@ -192,7 +192,7 @@ module ActiveRecord # convert something to a boolean def value_to_boolean(value) - if value.is_a?(String) && value.blank? + if value.is_a?(String) && value.empty? nil else TRUE_VALUES.include?(value) |