| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Removed unnecessary block
|
| | |_|_|/ / /
| |/| | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Conflicts:
activerecord/lib/active_record/associations/preloader/through_association.rb
activerecord/test/cases/associations/eager_test.rb
|
|/ / / / / / |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I don't think this is testing anything useful, and the test code is
exceedingly brittle. It is broken since
34c7e73c1def1312e59ef1f334586ff2f668246e because the test code makes
assumptions about the implementation of PostgreSQLAdapter#active? which
are incorrect after the commit.
I could fix this test but it would be even more brittle (by stubbing the
underlying @connection.connect_poll) and it doesn't test any complex
logic. I conclude that it's not worth it.
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix copy table index test; Change == to ! on false in travis.rb
|
| | | | | |
|
|/ / / / |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
mysql can't handle a parallel thread pinging the connection, so we can
get wrong results or segvs
This reverts commit 7cc588b684f6d1af3e7fab1edfa6715e269e41a2.
|
|\ \ \ \
| | | | |
| | | | | |
Removed unnecessary block
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
Closes #9824.
|
|\ \ \ \
| | | | |
| | | | | |
Fix some typos in AR- CHANGELOG, tests, method doc. fixed
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Changed the call to .sort.last to .max when computing the migration version
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
do not actually need to sort everything (incurs more cost than just a
simple max).
|
|/ / / /
| | | |
| | | |
| | | | |
Type a fixo.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
if the association already holds that record in memory before checking
the database for the specified ids.
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
it only cleared the validations that created :validate callbacks. This
didn't include the validates created by validates_with, so I've added a
method to clear all validations.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
vipulnsward/change_from_blank_to_empty_on_string"
This reverts commit 9c4c05fc82e997b722dec4068c3aa27eaee69eb8, reversing
changes made to 4620bdcefd0c88905a005f191496df887877b8f3.
Reason: They're not completely interchangeable, since blank? will also
check for strings containing spaces.
|
|\ \ \
| | | |
| | | | |
Change from blank? to empty? on obvious string values to save extra calls
|
| | | |
| | | |
| | | |
| | | | |
calls
|
| | | |
| | | |
| | | |
| | | | |
Introduced in 5dc2e3531babcbdc165884d1a47cbcd13455522d.
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57.
|
|\ \ \ \
| | | | |
| | | | | |
Change from each to each_value;drop assignment in habtm
|
| |/ / /
| | | |
| | | |
| | | | |
2. drop assignment of value to sum in test
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
fix typos in AR. lots of them.
|
| |/ / / |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* master-sec:
fix protocol checking in sanitization [CVE-2013-1857]
JDOM XXE Protection [CVE-2013-1856]
fix incorrect ^$ usage leading to XSS in sanitize_css [CVE-2013-1855]
stop calling to_sym when building arel nodes [CVE-2013-1854]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove ancient TODOs [ci skip]
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Move tests out from base_test.rb to inheritance_test.rb
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
These tests should be in inheritance_test.rb since its testing a
feature which is implemented in inheritance.rb
|
|\ \ \ \
| |/ / /
|/| | | |
SQLite3 3.6.8+ supports nested transactions [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
http://www.sqlite.org/lang_savepoint.html
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #8079.
I had to rework some of the tests because the mock allowed any arguments
for `connection.exeucte`. I think this is very dangerous as there could
anything be executed without the tests noticing it.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
"utf8mb4"
Please, see rationale in the included CHANGELOG patch.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
PR #5210 added a Friendship model to illustrate a bug, but in doing so
created a confusing structure because both belongs_to declarations in
Friendship referred to the same side of the join. The new structure
maintains the integrity of the bug test while changing the follower
relationship to be more useful for other testing.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
the primary key on an association will make sure that the corresponding
counter on the association is changed properly. Fixes #9722.
|
|\ \ \ \
| | | | |
| | | | | |
Method #primary_key? is not reused
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
senny/9712_option_to_turn_references_deprecation_off
make it possible to disable implicit join references.
|