aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Refactor `PredicateBuilder` from singleton to instanceMelanie Gilman2014-12-024-19/+32
|
* no need to pass native_database_types aroundYves Senn2014-12-024-7/+13
|
* pg tests, get rid of global schema `schema_1`.Yves Senn2014-12-023-53/+51
|
* pg tests, move uniqueness validation test to array tests.Yves Senn2014-12-023-27/+16
|
* tests, extract pg number tests into separate file.Yves Senn2014-12-023-44/+51
|
* tests, move schema shorthand assertions into pg specific tests.Yves Senn2014-12-0210-131/+89
|
* tests, move pg geometric tests out of `base_test`.Yves Senn2014-12-023-106/+73
|
* ugh, forgot to add this test to cdd90f39d796986dabf1678b3277b230dbe18961Aaron Patterson2014-12-011-0/+5
|
* tests, favor public API over inspecting columns where possible.Yves Senn2014-12-013-23/+20
| | | | | This is a follow up to https://github.com/rails/rails/commit/07786c5e75a7b0afdf318063510af6b475e3e04c and https://github.com/rails/rails/commit/cd2596f55e88fe659592612a793c4f4aa723c9be
* tests, run numeric default tests for every adapter.Yves Senn2014-12-011-15/+33
|
* tests, use public API to verify default parsing. #17863, #17856Yves Senn2014-12-011-1/+2
|
* Fix value extracted from negative integers for PostgreSQL.Guo Xiang Tan2014-12-012-1/+5
| | | | Fixes: https://github.com/rails/rails/issues/17856.
* Ensure numericality validations work with mutationSean Griffin2014-12-012-6/+19
| | | | | | | | | | | | | | | | | | | | | The detection of in-place changes caused a weird unexpected issue with numericality validations. That validator (out of necessity) works on the `_before_type_cast` version of the attribute, since on an `:integer` type column, a non-numeric string would type cast to 0. However, strings are mutable, and we changed strings to ensure that the post type cast version of the attribute was a different instance than the before type cast version (so the mutation detection can work properly). Even though strings are the only mutable type for which a numericality validation makes sense, special casing strings would feel like a strange change to make here. Instead, we can make the assumption that for all mutable types, we should work on the post-type-cast version of the attribute, since all cases which would return 0 for non-numeric strings are immutable. Fixes #17852
* Fix grammar on ActiveRecord::AttributeMethods doc.Hendy Tanata2014-11-301-1/+1
| | | | [ci skip]
* Update Arel usage for rails/arel#98fc259Sean Griffin2014-11-294-8/+8
| | | | | `where_sql` now requires that we pass it an engine. None of the manager classes take an engine in their constructor.
* Stop using `Arel::Table.engine`Sean Griffin2014-11-294-5/+5
| | | | | | | | | | | | | We never actually make use of it on the table, since we're constructing the select manager manually. It looks like if we ever actually were grabbing it from the table, we're grossly misusing it since it's meant to vary by AR class. Its existence on `Arel::Table` appears to be purely for convenience methods that are never used outside of tests. However, in production code it just complicates construction of the tables on the rails side, and the plan is to remove it from `Arel::Table` entirely. I'm not convinced it needs to live on `SelectManager`, etc either.
* Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-2959-176/+156
|
* Bump required Ruby version to 2.1.0claudiob2014-11-281-1/+1
| | | | | | | | | [This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that: > Rails 5.0 is in most likelihood going to target Ruby 2.2. Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383) that **at least** version 2.1.0 **must** be required by the `gemspec` files.
* Merge pull request #17799 from kamipo/refactor_add_column_optionsRafael Mendonça França2014-11-282-6/+14
|\ | | | | Refactor `add_column_options!`, to move the quoting of default value for :uuid in `quote_value`.
| * Rename to `quote_default_expression` from `quote_value`Ryuta Kamizono2014-11-282-3/+3
| |
| * Refactor `add_column_options!`, to move the quoting of default value for ↵Ryuta Kamizono2014-11-281-4/+12
| | | | | | | | :uuid in `quote_value`.
* | Start Rails 5 development :tada:Rafael Mendonça França2014-11-282-1339/+4
| | | | | | | | | | | | | | We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9.
* | Adds preloaded_records method to NullPreloaderThorsten Ball2014-11-282-0/+9
| | | | | | | | | | | | | | | | This fixes a regression where preloading association throws an exception if one of the associations in the preloading hash doesn't exist for one record. Fixes #16070
* | Merge pull request #17808 from ↵Rafael Mendonça França2014-11-285-12/+31
|\ \ | | | | | | | | | | | | yuki24/fix-bug-where-record-not-saved-loses-error-message Fixed a bug where AR::RecordNotSaved loses the given error message
| * | Fix a bug where AR::RecordNotSaved loses error messagesYuki Nishijima2014-11-275-12/+31
| |/ | | | | | | | | | | Since 3e30c5d, it started ignoring the given error message. This commit changes the behavior of AR::RecordNotSaved#initialize so that it no longer loses the given error message.
* | Merge pull request #17798 from kamipo/refactor_visit_add_columnYves Senn2014-11-282-9/+1
|\ \ | |/ |/| Refactor `SchemaCreation#visit_AddColumn`
| * Refactor `SchemaCreation#visit_AddColumn`Ryuta Kamizono2014-11-272-9/+1
| |
* | Merge pull request #17807 from jvperrin/correct-integer-testRafael Mendonça França2014-11-271-1/+1
|\ \ | | | | | | Correct test description for large integer test
| * | Correct test description for large integer testJason Perrin2014-11-031-1/+1
| | |
* | | Update the StatementCache documentationRafael Mendonça França2014-11-271-4/+15
| | |
* | | StatementCache is private APIRafael Mendonça França2014-11-271-6/+6
| |/ |/| | | | | It should not be used in applications
* | various error classes: added newlines & removed :nodoc: flag from public ↵Recursive Madman2014-11-262-3/+6
| | | | | | | | attribute.
* | Merge pull request #17674 from recursive-madman/activerecord-error-improvementRafael Mendonça França2014-11-263-4/+25
|\ \ | | | | | | Add #record attribute to RecordNotFound and RecordDestroyed exceptions.
| * | Add #record attribute to RecordNotFound and RecordDestroyed exceptions.Recursive Madman2014-11-263-4/+25
| | | | | | | | | | | | This allows these exceptions to be handled generically in conjunction with RecordInvalid.
* | | Active Record change log pass [skip ci]Jon Atack2014-11-261-38/+40
| | |
* | | Generators add foreign keys on referencesDerek Prior2014-11-252-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you run a generator such as: ``` rails generate model accounts supplier:references ``` The resulting migration will now add the corresponding foreign key constraint unless the reference was specified to be polymorphic.
* | | Merge pull request #17697 from sgrif/sg-remove-is-a-check-when-ignoring-tablesSean Griffin2014-11-252-16/+1
|\ \ \ | | | | | | | | Remove is_a? check when ignoring tables
| * | | Remove is_a? check when ignoring tablesSean Griffin2014-11-202-16/+1
| | | | | | | | | | | | | | | | | | | | Technically changes the API, as it will allow any object which responds to `===`. Personally, I think this is more flexible.
* | | | Use released arelRafael Mendonça França2014-11-251-1/+1
| | | |
* | | | Move PG float quoting to the correct locationSean Griffin2014-11-251-16/+6
| | | | | | | | | | | | | | | | | | | | Not sure how we missed this case when we moved everything else to the `_quote` method.
* | | | Merge pull request #17739 from rails/bring_back_db_test_prepareYves Senn2014-11-254-8/+28
|\ \ \ \ | | | | | | | | | | bring back `db:test:prepare`.
| * | | | bring back `db:test:prepare`.Yves Senn2014-11-253-6/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts deprecations added in #13528. The task is brought back for two reasons: 1. Give plugins a way to hook into the test database initialization process 2. Give the user a way to force a test database synchronization While `test:prepare` is still a dependency of every test task, `db:test:prepare` no longer hooks into it. This means that `test:prepare` runs before the schema is synchronized. Plugins, which insert data can now hook into `db:test:prepare`. The automatic schema maintenance can't detect when a migration is rolled-back, modified and reapplied. In this case the user has to fall back to `db:test:prepare` to force the synchronization to happen.
| * | | | do not trigger AR lazy load hook before initializers ran.Yves Senn2014-11-251-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Rafael Mendonça França & Yves Senn] This require caused the `active_record.set_configs` initializer to run immediately, before `config/initializers`. This means that setting any configuration on `Rails.application.config.active_record` inside of an initializer had no effects when rails was loaded through `rake`. Introduced by #6518 /cc @rafaelfranca
* | | | | Setting an association replaces records with the same id in memorySean Griffin2014-11-252-2/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The records weren't being replaced since equality in Active Record is defined in terms of `id` only. It is reasonable to expect that the references would be replaced in memory, even if no queries are actually executed. This change did not appear to affect any other parts of the code base. I chose not to execute callbacks since we're not actually modifying the association in a way that will be persisted. Fixes #17730
* | | | | Merge pull request #17754 from eileencodes/refactor-aliased_table_forSantiago Pastorino2014-11-252-13/+4
|\ \ \ \ \ | |/ / / / |/| | | | Combine aliased_table_for and aliased_name_for
| * | | | Combine aliased_table_for and aliased_name_foreileencodes2014-11-242-13/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactoring reduces the number of conditionals needed to build `aliased_table_for` and removes `aliased_name_for` because it's no longer necessary. `aliased_name_for` was also used in `JoinDependency#initialize` so that was replaced with `aliased_table_for` as well.
* | | | | Fix out of range error messageRyuta Kamizono2014-11-251-1/+1
|/ / / /
* | | | allow types to be passed in for USING castsAaron Patterson2014-11-241-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us so abstract the migration from the type that is actually used by Rails. For example, ":string" may be a varchar or something, but the framework does that translation, and the app shouldn't need to know.
* | | | oops, forgot to add the real assertion!Aaron Patterson2014-11-241-0/+1
| | | |
* | | | allow the "USING" statement to be specified on change column callsAaron Patterson2014-11-242-1/+28
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 21:20:09 +0000