| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The comment in the test pretty much summarizes the issue.
`FIXME these assertions bust a lot`
Adding any type of association in class `Firm` will break this test.
I removed some deprecated stuff and this test failed.
I do not think this test provides any useful value. First of all who
counted last that 39 is the right number of associations.
Secondly there are a large number of tests which depend on reflection
returning right information about associations. Those tests will start
failing if there is a bug in the code.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
neerajdotname/delete_all_should_not_call_callbacks
Do not invoke callbacks when delete_all is called
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Method `delete_all` should not be invoking callbacks and this
feature was deprecated in Rails 4.0. This is being removed.
`delete_all` will continue to honor the `:dependent` option. However
if `:dependent` value is `:destroy` then the default deletion
strategy for that collection will be applied.
User can also force a deletion strategy by passing parameter to
`delete_all`. For example you can do `@post.comments.delete_all(:nullify)`
|
| | |
| |
| |
| | |
Calling default_scope without a proc will now raise `ArgumentError`.
|
| |\ \
| | |
| | |
| | |
| | | |
frodsan/remove_deprecated_clear_stale_cached_connections_method
Remove AR::Connection#clear_stale_cached_connections! deprecated method
|
| | | | |
|
| |/ / |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
Removed deprecated options for assocations
|
| | | |
| | |
| | |
| | |
| | | |
Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql`
have been deleted.
|
| |/ / |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Removed deprecated methods `partial_updates`, `partial_updates?` and
`partial_updates=`
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Removed deprecated scoped method
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
|
| |/ / |
|
| |/ |
|
| | |
|
| |\
| |
| |
| |
| | |
ActiveRecord find_in_batches should work without logger
When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In 94924dc32baf78f13e289172534c2e71c9c8cade the internal default_scope
implementation has changed making it simpler to follow, meaning that the
old usage of with_default_scope has been removed.
With that, order_values was the same argument for both calls to
find_first_with_limit, so remove it and use the existent attribute
for the sake of clarity/simplification.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous implementation was necessary in order to support stuff
like:
class Post < ActiveRecord::Base
default_scope where(published: true)
scope :ordered, order("created_at")
end
If we didn't evaluate the default scope at the last possible moment
before sending the SQL to the database, it would become impossible to
do:
Post.unscoped.ordered
This is because the default scope would already be bound up in the
"ordered" scope, and therefore wouldn't be removed by the
"Post.unscoped" part.
In 4.0, we have deprecated all "eager" forms of scopes. So now you must
write:
class Post < ActiveRecord::Base
default_scope { where(published: true) }
scope :ordered, -> { order("created_at") }
end
This prevents the default scope getting bound up inside the "ordered"
scope, which means we can now have a simpler/better/more natural
implementation of default scoping.
A knock on effect is that some things that didn't work properly now do.
For example it was previously impossible to use #except to remove a part
of the default scope, since the default scope was evaluated after the
call to #except.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For example:
class Post < ActiveRecord::Base
default_scope -> { where published: true }
end
class Comment
belongs_to :post
end
When calling `Comment.join(:post)`, we expect to receive only
comments on published posts, since that is the default scope for
posts.
Before this change, the default scope from `Post` was not applied,
so we'd get comments on unpublished posts.
|
| | |
| |
| |
| |
| | |
Oops. We need to estalish/remove the connection in the setup/teardown,
else it messes with the fixtures.
|
| | |
| |
| |
| | |
Clearly nobody uses this except me. It's fast people!
|
| |\ \
| | |
| | | |
Remove depreacted finders
|
| | | |
| | |
| | |
| | | |
They were deprecated in 4.0, planned to remove in 4.1
|
| | | | |
|
| |/ /
| |
| |
| | |
Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
These two methods aren't really statistical helper methods and don't
really belong in any other group which is being delegated for querying,
so I'm moving them to their own group of methods.
I've also changed the `:to => :all` hash syntax to `to: :all`.
|
| | |
| |
| |
| | |
[ci skip]
|
| |\ \
| | |
| | |
| | |
| | | |
tkhr/add_test_for_AR__CounterCache#update_counters
Add test for AR::CounterCache.update_counters
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Remove Oracle / Sqlserver / Firebird database tasks were deprecated since 4.0.
|
| | | | |
| | | |
| | | |
| | | | |
3rd-party.
|
| | | | |
| | | |
| | | |
| | | | |
3rd-party.
|
| | | | |
| | | |
| | | |
| | | | |
3rd-party.
|
