aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #11153 from strzalek/remove-ar-deprecated-findersJon Leighton2013-06-287-637/+7
|\ | | | | Remove depreacted finders
| * Remove depreacted findersŁukasz Strzałkowski2013-06-287-637/+7
| | | | | | | | They were deprecated in 4.0, planned to remove in 4.1
* | Fix indentationAkira Matsuda2013-06-281-1/+1
| |
* | Remove deprecated attr_protected/accessibleŁukasz Strzałkowski2013-06-271-1/+0
|/ | | | Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters.
* activerecord/examples/simple.rb use master branch activesupport gemtumayun2013-06-271-1/+1
|
* fix activerecord/examples/performance.rb#L101 syntax errortumayun2013-06-271-1/+1
|
* Moving the `pluck` and `ids` methods to their own delegate line.wangjohn2013-06-251-8/+9
| | | | | | | | These two methods aren't really statistical helper methods and don't really belong in any other group which is being delegated for querying, so I'm moving them to their own group of methods. I've also changed the `:to => :all` hash syntax to `to: :all`.
* Fix @tenderlove's name in changelog :sparkles:Carlos Antonio da Silva2013-06-261-2/+2
| | | | [ci skip]
* Merge pull request #10730 from ↵Carlos Antonio da Silva2013-06-251-8/+9
|\ | | | | | | | | tkhr/add_test_for_AR__CounterCache#update_counters Add test for AR::CounterCache.update_counters
| * Refactor AR's counter_cache_test.rb testTakehiro Adachi2013-05-231-8/+3
| |
| * Add test for AR::CounterCache.update_countersTakehiro Adachi2013-05-231-0/+6
| |
* | Add changelog entry for database tasks removal #10853 [ci skip]Carlos Antonio da Silva2013-06-251-0/+4
| |
* | Merge pull request #10853 from kennyj/deprecated-database_tasksCarlos Antonio da Silva2013-06-257-433/+0
|\ \ | | | | | | Remove Oracle / Sqlserver / Firebird database tasks were deprecated since 4.0.
| * | Remove FirebirdDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-053-158/+0
| | | | | | | | | | | | 3rd-party.
| * | Remove SqlseverDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-053-136/+0
| | | | | | | | | | | | 3rd-party.
| * | Remove OracleDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-053-139/+0
| | | | | | | | | | | | 3rd-party.
* | | Merge pull request #10992 from Empact/find-each-enumeratorCarlos Antonio da Silva2013-06-253-2/+36
|\ \ \ | | | | | | | | | | | | When .find_each is called without a block, return an Enumerator.
| * | | When .find_each is called without a block, return an Enumerator.Ben Woosley2013-06-193-2/+36
| | | | | | | | | | | | | | | | This lets us do things like call: .find_each.with_index
* | | | Merge pull request #10993 from Empact/result-each-enumeratorCarlos Antonio da Silva2013-06-253-1/+42
|\ \ \ \ | | | | | | | | | | | | | | | Change Result#each to return an Enumerator when called without a block.
| * | | | Change Result#each to return an Enumerator when called without a block.Ben Woosley2013-06-183-1/+43
| | | | | | | | | | | | | | | | | | | | As with #10992, this lets us call #with_index, etc on the results.
* | | | | Merge pull request #11046 from arunagw/verbose_mode_onCarlos Antonio da Silva2013-06-251-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Verbose mode on when running tests
| * | | | | Adding verbose in isolated test.Arun Agrawal2013-06-211-1/+1
| | | | | |
* | | | | | removed unnecessary mapping for on optionsAnton Kalyaev2013-06-251-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right before that in `assert_valid_transaction_action` method we make sure that `options[:on]` contains values from `ACTIONS` array (`[:create, :destroy, :update]`) and nothing more (i.e. it could not contain strings or something else, otherwise the error is raised). Also I've polished some docs.
* | | | | | remove trailing whitespace from Active Record CHANGELOGYves Senn2013-06-251-1/+1
| | | | | |
* | | | | | Fix `another_contract` not being used warningVipul A M2013-06-241-1/+1
| | | | | |
* | | | | | test-case to prevent regressions described in #10901.Jared Armstrong2013-06-241-0/+27
| | | | | |
* | | | | | replace all older rocket sign to new ":" from examples of active record and ↵Rajarshi Das2013-06-242-19/+19
| | | | | | | | | | | | | | | | | | | | | | | | active models
* | | | | | Setup env and seed_loaded for DatabaseTasks outside load_configPiotr Sarnacki2013-06-231-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | Those vars can be used in tasks, which not call load_config.
* | | | | | Change a way ActiveRecord's config is prepared for rake tasksPiotr Sarnacki2013-06-231-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit d1d7c86d0 I moved setting migrations paths into activerecord's railtie to remove Rails dependency on databases.rake. However, it introduced a regression, ENGINE_PATH was not available at the moment, so engine's migrations where not added properly to paths. Fix was added at 97a4a771, but it changes a way things work from using ENGINE_PATH to APP_RAKEFILE. Additionally, the config runs when the code loads, while previously it ran in the db:load_config rake task In order to make it more in pair with original version this commit changes the config to run only on load_config task. This code uses the fact that defining a task in rake does not overwrite, but only appends. It also allows to get back to checking for ENGINE_PATH
* | | | | | test-case to prevent regressions on `Association#build` with an Array.Yves Senn2013-06-221-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | Closes #11026
* | | | | | flatten merged join_values before building the joinsNeeraj Singh2013-06-223-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes #10669 While joining_values special treatment is given to string values. By flattening the array it ensures that string values are detected as strings and not arrays.
* | | | | | do not load all child records for inverse caseNeeraj Singh2013-06-213-1/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | currently `post.comments.find(Comment.first.id)` would load all comments for the given post to set the inverse association. This has a huge performance penalty. Because if post has 100k records and all these 100k records would be loaded in memory even though the comment id was supplied. Fix is to use in-memory records only if loaded? is true. Otherwise load the records using full sql. Fixes #10509
* | | | | | Merge pull request #11049 from neerajdotname/no-need-of-large-numberJon Leighton2013-06-211-1/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | fix bad test by making number that fits for integer
| * | | | | | fix bad test by making number that fits for integerNeeraj Singh2013-06-211-1/+5
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR https://github.com/rails/rails/pull/10566 had to be reverted because after applying the fix test "test_raise_record_not_found_error_when_invalid_ids_are_passed" started failing. In this test invalid_id is being assigned a really large number which was causing following failure when PR #10566 was applied. ``` RangeError: bignum too big to convert into `long long' SELECT `interests`.* FROM `interests` WHERE `interests`.`man_id` = ? AND `interests`.`id` = ? LIMIT 1 [["man_id", 970345987], ["id", 2394823094892348920348523452345]] ``` This test is not failing in master because when test code `man.interests.find(invalid_id)` is executed then interests are fully loaded in memory and no database query is executed. After PR #10566 was merged then test code `man.interests.find(invalid_id)` started executing sql query and hence the error. In case someone is wondering why the second part of query is not failing, then that's because the actual query does not require any variable substituation where the number is large. In that case the sql generate is following. ``` SELECT `interests`.* FROM `interests` WHERE `interests`.`man_id` = ? AND `interests`.`id` IN (8432342, 2390102913, 2453245234523452) [["man_id", 970345987]] ```
* | | | | | Merge pull request #11040 from satococoa/fix-create_join_table-documentCarlos Antonio da Silva2013-06-211-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix documents for create_join_table [ci skip]
| * | | | | | Fix documents for create_join_tableSatoshi Ebisawa2013-06-211-2/+2
| |/ / / / /
* / / / / / Saying gemcutter => rubygems [ci skip]Arun Agrawal2013-06-211-1/+1
|/ / / / /
* | | | | `inspect` for AR model classes does not initiate a new connection.Yves Senn2013-06-203-0/+33
| | | | |
* | | | | add forgotten CHANGELOG entry for #10884.Yves Senn2013-06-191-0/+5
| | | | |
* | | | | Merge pull request #10884 from dmarkow/pg_fix_default_quotesYves Senn2013-06-192-1/+26
|\ \ \ \ \ | | | | | | | | | | | | Handle single quotes in PostgreSQL default column values
| * | | | | Handle single quotes in PostgreSQL default column valuesDylan Markow2013-06-192-1/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PostgreSQL escapes single quotes by using an additional single quote. When Rails queries the column information, PostgreSQL returns the default values with the escaped single quotes. #extract_value_from_default now converts these to one single quote each. Fixes #10881.
* | | | | | Revert "Merge pull request #10566 from neerajdotname/10509d"Jon Leighton2013-06-193-25/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2b817a5e89ac0e7aeb894a40ae7151a0cf3cef16, reversing changes made to 353a398bee68c5ea99d76ac7601de0a5fef6f4a5. Conflicts: activerecord/CHANGELOG.md Reason: the build broke
* | | | | | log the sql that is actually sent to the databaseNeeraj Singh2013-06-193-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If I have a query that produces sql `WHERE "users"."name" = 'a b'` then in the log all the whitespace is being squeezed. So the sql that is printed in the log is `WHERE "users"."name" = 'a b'`. This can be confusing. This commit fixes it by ensuring that whitespace is not squeezed. fixes #10982
* | | | | | do not load all child records for inverse caseNeeraj Singh2013-06-193-1/+25
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | currently `post.comments.find(Comment.first.id)` would load all comments for the given post to set the inverse association. This has a huge performance penalty. Because if post has 100k records and all these 100k records would be loaded in memory even though the comment id was supplied. Fix is to use in-memory records only if loaded? is true. Otherwise load the records using full sql. Fixes #10509
* | | | | Fix formatting of my name in the changelog, and given Aaron credit for ↵Ben Woosley2013-06-181-1/+3
| | | | | | | | | | | | | | | | | | | | b483a0d2a75b
* | | | | It takes 4 spaces or some backticks to have this code displayed as code in ↵Ben Woosley2013-06-181-23/+23
| |/ / / |/| | | | | | | | | | | the changelog.
* | | | Merge pull request #10987 from senny/10979_association_include_returns_trueXavier Noria2013-06-182-12/+12
|\ \ \ \ | | | | | | | | | | `CollectionProxy#include?` returns `true` and `false` as documented.
| * | | | `CollectionProxy#include?` returns `true` and `false` as documented.Yves Senn2013-06-182-12/+12
| | | | |
* | | | | just construct real objects rather than mock and stubAaron Patterson2013-06-171-7/+8
| | | | |
* | | | | Merge branch 'master' into mrbrdo-fixserializationAaron Patterson2013-06-1741-301/+522
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (142 commits) Use Colspan in th Tags Added test for link_to_unless to make sure the result consistency. Escape the string even when the condition of link_to_unless is not satisfied. Add CHANGELOG entry for #10969 Use a case insensitive URI Regexp for #asset_path collection tags accept html attributes as the last element of collection Rewind StringIO instances before be parsed again Use xml instead already parsed xml Updated the doc for const_regexp [ci skip] Make test name descriptive and add reference to original regression commit fixture setup does not rely on `AR::Base.configurations`. regression test + mysql2 adapter raises correct error if conn is closed. cleanup, remove trailing whitespace from AR changelog 'json' gem is no more required under JRuby fix typos Fix AS changelog [ci skip] Update the HTML boolean attributes per the HTML 5.1 spec Changing const_regexp to check for constant name. valid_app_const? -> valid_const? Add CHANGELOG entry for #10740 ...
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 04:12:09 +0000