| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
| |
| |
| |
| | |
Since the above comment is for the `preloaders_for_one`.
|
| |
| |
| |
| | |
cherry-picked from https://github.com/rails/rails/pull/33763
|
|\ \
| | |
| | | |
ActiveRecord::Associations::Preloader should not fail to preload through missing records
|
| | |
| | |
| | |
| | | |
missing records
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
`establish_connection` will never raise `ActiveRecord::NoDatabaseError`,
because it doesn't connect to a database; it sets up a connection pool.
|
| | | |
|
| | | |
|
|/ / |
|
| | |
|
|\ \
| | |
| | |
| | | |
index option added for change_table migrations
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In case if we want to add a column into the existing table
with index on it, we have to add column and index in two
seperate lines.
With this feature we don't need to write an extra line to
add index for column. We can just use `index` option.
Old behaviour in action:
```
change_table(:languages) do |t|
t.string :country_code
t.index: :country_code
end
```
New behaviour in action:
```
change_table(:languages) do |t|
t.string :country_code, index: true
end
```
Exactly same behaviour is already exist for `create_table` migrations.
|
|\ \ \
| | | |
| | | | |
Add `Style/RedundantFreeze` to remove redudant `.freeze`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since Rails 6.0 will support Ruby 2.4.1 or higher
`# frozen_string_literal: true` magic comment is enough to make string object frozen.
This magic comment is enabled by `Style/FrozenStringLiteralComment` cop.
* Exclude these files not to auto correct false positive `Regexp#freeze`
- 'actionpack/lib/action_dispatch/journey/router/utils.rb'
- 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb'
It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333
Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed.
* Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required
- 'actionpack/test/controller/test_case_test.rb'
- 'activemodel/test/cases/type/string_test.rb'
- 'activesupport/lib/active_support/core_ext/string/strip.rb'
- 'activesupport/test/core_ext/string_ext_test.rb'
- 'railties/test/generators/actions_test.rb'
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
MySQL supports DELETE with LIMIT and ORDER BY.
https://dev.mysql.com/doc/refman/8.0/en/delete.html
Before:
```
Post Destroy (1.0ms) DELETE FROM `posts` WHERE `posts`.`id` IN (SELECT `id` FROM (SELECT `posts`.`id` FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ?) __active_record_temp) [["author_id", 1], ["LIMIT", 1]]
```
After:
```
Post Destroy (0.4ms) DELETE FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ? [["author_id", 1], ["LIMIT", 1]]
```
|
| | | |
| | | |
| | | |
| | | | |
53521a9e39b9d8af4165d7703c36dc905f1f8f67
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
No longer needed workaround for Ruby 2.2 "private attribute?" warning.
Related 6d63b5e49a399fe246afcebad45c3c962de268fa.
|
| | | |
| | | |
| | | |
| | | | |
Follow up ae406cd633dab2cafbc0d1bb5922d1ca40056ea0.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Originally specified attributes were only normal values, and
`ActiveRecord::MultiparameterAssignmentErrors` did not occur.
In addition, an assertion is performed only on rescue, even if an
exception does not occur, the test passes. To avoid this use `assert_raise`.
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
When one relation is merged into another that has a different base class
merging `from_clause` causes invalid SQL to be generated
|
|\ \ \
| | | |
| | | | |
Revert "record who created the node when $DEBUG is true"
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit a1b72178714fbf0033fe076b7e51f57eff152bdd.
|
|/ / / |
|
| | |
| | |
| | |
| | | |
Since Ruby 2.4 unified Fixnum and Bignum into Integer.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before:
```
Topic Update All (0.4ms) UPDATE `topics` SET `topics`.`replies_count` = COALESCE(`topics`.`replies_count`, 0) + 1, `topics`.`updated_at` = '2018-09-27 18:34:05.068774' WHERE `topics`.`id` = ? [["id", 7]]
```
After:
```
Topic Update All (0.4ms) UPDATE `topics` SET `topics`.`replies_count` = COALESCE(`topics`.`replies_count`, 0) + ?, `topics`.`updated_at` = ? WHERE `topics`.`id` = ? [["replies_count", 1], ["updated_at", 2018-09-27 18:55:05 UTC], ["id", 7]]
```
|
|\ \ \
| | | |
| | | | |
Add missing rdoc +code+ tags [ci skip]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Before:
```
Pet Update All (0.8ms) UPDATE `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` SET `pets`.`name` = 'Bob' WHERE `toys`.`name` = ? [["name", "Bone"]]
```
After:
```
Pet Update All (1.1ms) UPDATE `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` SET `pets`.`name` = ? WHERE `toys`.`name` = ? [["name", "Bob"], ["name", "Bone"]]
```
|
|\ \ \ \
| | | | |
| | | | | |
Fix `transaction` reverting for migrations
|
| | | | |
| | | | |
| | | | |
| | | | | |
[fatkodima & David Verhasselt]
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Since counter cache handles touch option too.
|
| | | | |
| | | | |
| | | | |
| | | | | |
the belongs_to association
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Raise an error when loading all fixtures from nil fixture_path
|
| | | | |
| | | | |
| | | | |
| | | | | |
[Gannon McGibbon + Max Albrecht]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
If association is a hash-like object preloading fails
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
If you pass a hash-like object to preload associations (for example ActionController::Parameters)
preloader will fail with the ArgumentError.
This change allows passing objects that may be converted to a Hash or String into a preloader
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`association.increment_counters` and `association.decrement_counters`
works regardless of parent target is loaded or not.
Related 52e11e462f6114a4d12225c639c5f501f0ffec7a.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 376ffe0ea2e59dc51461122210729c05a10fb443.
Since 38fae1f, `association.increment_counters` is called without
inflated parent target if inverse_of is disabled.
In that case, that commit would cause extra queries to inflate parent.
|
|/ / /
| | |
| | |
| | | |
Fixes #19550.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Stringify database configurations
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`counter_cache_target` is called only when updated counter cache in
replacing target, but it was already removed at #33913.
|