aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #10604 from ↵Rafael Mendonça França2013-07-019-17/+117
|\ | | | | | | | | | | | | | | | | neerajdotname/delete_all_should_not_call_callbacks Do not invoke callbacks when delete_all is called Conflicts: activerecord/CHANGELOG.md
| * Do not invoke callbacks when delete_all is calledNeeraj Singh2013-06-309-17/+117
| | | | | | | | | | | | | | | | | | | | | | Method `delete_all` should not be invoking callbacks and this feature was deprecated in Rails 4.0. This is being removed. `delete_all` will continue to honor the `:dependent` option. However if `:dependent` value is `:destroy` then the default deletion strategy for that collection will be applied. User can also force a deletion strategy by passing parameter to `delete_all`. For example you can do `@post.comments.delete_all(:nullify)`
* | calling default_scope without a proc will raise ArgumentErrorNeeraj Singh2013-07-023-6/+8
| | | | | | | | Calling default_scope without a proc will now raise `ArgumentError`.
* | Merge pull request #11230 from ↵Rafael Mendonça França2013-07-011-5/+0
|\ \ | | | | | | | | | | | | frodsan/remove_deprecated_clear_stale_cached_connections_method Remove AR::Connection#clear_stale_cached_connections! deprecated method
| * | Remove deprecated AR::Connection#clear_stale_cached_connections! methodFrancesco Rodriguez2013-07-011-5/+0
| | |
* | | Removed deprecated method type_cast_code from ColumnNeeraj Singh2013-07-022-24/+4
|/ /
* | avoid intermediate zipped arrayAaron Patterson2013-07-011-3/+2
| |
* | make the identity type a singleton to save on object creationAaron Patterson2013-07-012-3/+7
| |
* | only deal with strings internallyAaron Patterson2013-07-011-3/+3
| |
* | Merge pull request #11222 from neerajdotname/removed-deprecation-for-sqlRafael Mendonça França2013-07-015-41/+8
|\ \ | | | | | | Removed deprecated options for assocations
| * | Removed deprecated options for assocationsNeeraj Singh2013-07-025-41/+8
| | | | | | | | | | | | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted.
* | | build an AST rather than slapping strings togetherAaron Patterson2013-07-011-11/+7
|/ /
* | Remove deprecation messages about protected_attributes and rails-observersCarlos Antonio da Silva2013-07-011-39/+0
| |
* | stop exposing the underlying alias datastructureAaron Patterson2013-07-011-4/+4
| |
* | we don't need to to_s the columnAaron Patterson2013-07-011-1/+1
| |
* | the data structure used to store attribute aliases should not be exposedAaron Patterson2013-07-011-2/+2
| |
* | remove deprecated `ActiveRecord::Base#connection` method.Yves Senn2013-07-013-12/+5
| |
* | remove auto-explain-config deprecation warningYves Senn2013-07-012-11/+4
| |
* | Remove deprecated `:distinct` option from `Relation#count`.Yves Senn2013-07-013-15/+4
| |
* | Removed deprecated methods partial_updates and familyNeeraj Singh2013-07-023-25/+5
| | | | | | | | | | Removed deprecated methods `partial_updates`, `partial_updates?` and `partial_updates=`
* | Merge pull request #11213 from neerajdotname/scoped-deprecatedRafael Mendonça França2013-07-012-5/+4
|\ \ | | | | | | | | | | | | | | | | | | Removed deprecated scoped method Conflicts: activerecord/CHANGELOG.md
| * | Removed deprecated method scopedNeeraj Singh2013-07-012-5/+4
| | |
* | | Removed deprecated method default_scopes?Neeraj Singh2013-07-012-8/+4
|/ /
* / don't shadow `through_scope` method name with local var.Yves Senn2013-06-301-7/+7
|/
* remove deprecated implicit join references.Yves Senn2013-06-296-87/+25
|
* Merge pull request #11161 from dmitry/find_in_batches_works_without_loggerCarlos Antonio da Silva2013-06-282-2/+12
|\ | | | | | | | | ActiveRecord find_in_batches should work without logger When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway.
| * find_in_batches should work without loggerDmitry Polushkin2013-06-282-2/+12
| |
* | Remove order_values argument now that default_scope is simplifiedCarlos Antonio da Silva2013-06-281-5/+5
| | | | | | | | | | | | | | | | | | | | In 94924dc32baf78f13e289172534c2e71c9c8cade the internal default_scope implementation has changed making it simpler to follow, meaning that the old usage of with_default_scope has been removed. With that, order_values was the same argument for both calls to find_first_with_limit, so remove it and use the existent attribute for the sake of clarity/simplification.
* | Simplify/fix implementation of default scopesJon Leighton2013-06-2812-74/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation was necessary in order to support stuff like: class Post < ActiveRecord::Base default_scope where(published: true) scope :ordered, order("created_at") end If we didn't evaluate the default scope at the last possible moment before sending the SQL to the database, it would become impossible to do: Post.unscoped.ordered This is because the default scope would already be bound up in the "ordered" scope, and therefore wouldn't be removed by the "Post.unscoped" part. In 4.0, we have deprecated all "eager" forms of scopes. So now you must write: class Post < ActiveRecord::Base default_scope { where(published: true) } scope :ordered, -> { order("created_at") } end This prevents the default scope getting bound up inside the "ordered" scope, which means we can now have a simpler/better/more natural implementation of default scoping. A knock on effect is that some things that didn't work properly now do. For example it was previously impossible to use #except to remove a part of the default scope, since the default scope was evaluated after the call to #except.
* | Apply default scope when joining associations.Jon Leighton2013-06-283-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example: class Post < ActiveRecord::Base default_scope -> { where published: true } end class Comment belongs_to :post end When calling `Comment.join(:post)`, we expect to receive only comments on published posts, since that is the default scope for posts. Before this change, the default scope from `Post` was not applied, so we'd get comments on unpublished posts.
* | Fix testJon Leighton2013-06-281-1/+8
| | | | | | | | | | Oops. We need to estalish/remove the connection in the setup/teardown, else it messes with the fixtures.
* | Fix rake test_sqlite3_memJon Leighton2013-06-282-11/+7
| | | | | | | | Clearly nobody uses this except me. It's fast people!
* | Merge pull request #11153 from strzalek/remove-ar-deprecated-findersJon Leighton2013-06-287-637/+7
|\ \ | | | | | | Remove depreacted finders
| * | Remove depreacted findersŁukasz Strzałkowski2013-06-287-637/+7
| | | | | | | | | | | | They were deprecated in 4.0, planned to remove in 4.1
* | | Fix indentationAkira Matsuda2013-06-281-1/+1
| | |
* | | Remove deprecated attr_protected/accessibleŁukasz Strzałkowski2013-06-271-1/+0
|/ / | | | | | | Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters.
* | activerecord/examples/simple.rb use master branch activesupport gemtumayun2013-06-271-1/+1
| |
* | fix activerecord/examples/performance.rb#L101 syntax errortumayun2013-06-271-1/+1
| |
* | Moving the `pluck` and `ids` methods to their own delegate line.wangjohn2013-06-251-8/+9
| | | | | | | | | | | | | | | | These two methods aren't really statistical helper methods and don't really belong in any other group which is being delegated for querying, so I'm moving them to their own group of methods. I've also changed the `:to => :all` hash syntax to `to: :all`.
* | Fix @tenderlove's name in changelog :sparkles:Carlos Antonio da Silva2013-06-261-2/+2
| | | | | | | | [ci skip]
* | Merge pull request #10730 from ↵Carlos Antonio da Silva2013-06-251-8/+9
|\ \ | | | | | | | | | | | | tkhr/add_test_for_AR__CounterCache#update_counters Add test for AR::CounterCache.update_counters
| * | Refactor AR's counter_cache_test.rb testTakehiro Adachi2013-05-231-8/+3
| | |
| * | Add test for AR::CounterCache.update_countersTakehiro Adachi2013-05-231-0/+6
| | |
* | | Add changelog entry for database tasks removal #10853 [ci skip]Carlos Antonio da Silva2013-06-251-0/+4
| | |
* | | Merge pull request #10853 from kennyj/deprecated-database_tasksCarlos Antonio da Silva2013-06-257-433/+0
|\ \ \ | | | | | | | | Remove Oracle / Sqlserver / Firebird database tasks were deprecated since 4.0.
| * | | Remove FirebirdDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-053-158/+0
| | | | | | | | | | | | | | | | 3rd-party.
| * | | Remove SqlseverDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-053-136/+0
| | | | | | | | | | | | | | | | 3rd-party.
| * | | Remove OracleDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-053-139/+0
| | | | | | | | | | | | | | | | 3rd-party.
* | | | Merge pull request #10992 from Empact/find-each-enumeratorCarlos Antonio da Silva2013-06-253-2/+36
|\ \ \ \ | | | | | | | | | | | | | | | When .find_each is called without a block, return an Enumerator.
| * | | | When .find_each is called without a block, return an Enumerator.Ben Woosley2013-06-193-2/+36
| | | | | | | | | | | | | | | | | | | | This lets us do things like call: .find_each.with_index