Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Demodulize ActiveRecord::MigratorTest | Akira Matsuda | 2014-08-29 | 1 | -284/+282 |
| | |||||
* | Avoid using heredoc for user warnings | Godfrey Chan | 2014-08-28 | 10 | -61/+51 |
| | | | | | | | | | | Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long. | ||||
* | No transaction for a test that creates fixtures in the test body | Akira Matsuda | 2014-08-29 | 1 | -0/+1 |
| | |||||
* | make it easy to copy & paste the config from deprecation warning. | Yves Senn | 2014-08-28 | 1 | -2/+3 |
| | | | | [ci skip] | ||||
* | User Model#last to certainly get lastly created data | Akira Matsuda | 2014-08-28 | 1 | -1/+1 |
| | | | | This test would fail when executed after any test that calls fixtures(:binaries) | ||||
* | Move association definition to the model file | Akira Matsuda | 2014-08-28 | 2 | -2/+1 |
| | |||||
* | Be sure that test fixtures satisfy referential integrity before calculating | Akira Matsuda | 2014-08-28 | 1 | -1/+1 |
| | | | | | | | There exists some other test files that load :minivans fixtures but don't load :speedometers. Loading :speedometers here prevents the following error when this test was run after such test: CalculationsTest#test_should_group_by_association_with_non_numeric_foreign_key: ActiveRecord::RecordNotFound: Couldn't find all Speedometers with 'speedometer_id': (ABC, s1) (found 1 results, but was looking for 2) | ||||
* | No need to sort tests | Akira Matsuda | 2014-08-28 | 1 | -1/+1 |
| | | | | Dir.glob result must be already sorted anyway | ||||
* | Ignore SCHEMA queries when asserting no queries | Akira Matsuda | 2014-08-28 | 5 | -22/+22 |
| | |||||
* | Reset schema properly after schema changing test | Akira Matsuda | 2014-08-28 | 1 | -0/+2 |
| | |||||
* | Merge pull request #16702 from sgrif/sg-binary-serialized | Rafael Mendonça França | 2014-08-27 | 3 | -0/+31 |
|\ | | | | | Correctly detect mutation on serialized columns mapping to binary | ||||
| * | Correctly detect mutation on serialized columns mapping to binary | Sean Griffin | 2014-08-27 | 3 | -0/+31 |
| | | | | | | | | Fixes #16701 | ||||
* | | minor changelog formatting changes. | Yves Senn | 2014-08-27 | 1 | -2/+3 |
| | | |||||
* | | [ci skip] Updated documentation syntax of other parameter for rdoc | Tom Kadwill | 2014-08-27 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #16705 from tomkadwill/documented_many_block_param | Zachary Scott | 2014-08-26 | 1 | -1/+1 |
|\ \ | | | | | | | [ci skip] Updated documentation syntax of block parameter for rdoc | ||||
| * | | [ci skip] Updated documentation syntax of block parameter for rdoc | Tom Kadwill | 2014-08-26 | 1 | -1/+1 |
| | | | |||||
* | | | [ci skip] Updated include to reference record parameter for rdoc | Tom Kadwill | 2014-08-26 | 1 | -1/+1 |
|/ / | |||||
* / | [ci skip] Updated documentation syntax of block parameter for rdoc | Tom Kadwill | 2014-08-26 | 1 | -1/+1 |
|/ | |||||
* | [ci skip] Added documentation for has_and_belongs_to_many extension parameter | Tom Kadwill | 2014-08-26 | 1 | -0/+15 |
| | |||||
* | Merge pull request #16646 from sgrif/sg-perf-regression | Jeremy Kemper | 2014-08-25 | 1 | -1/+20 |
|\ | | | | | Cache the value of `changed_attributes` when calling `changes_applied` | ||||
| * | Cache the value of `changed_attributes` when calling `changes_applied` | Sean Griffin | 2014-08-22 | 1 | -1/+20 |
| | | | | | | | | | | | | | | `changes_applied` calles `changes`, which will call `changed_attributes` multiple times in a loop. This method actually performs work now, so we should cache the results while looping over it when we know it cannot change. | ||||
* | | Override #find_by! in core to enable AST caching | Godfrey Chan | 2014-08-25 | 2 | -0/+26 |
| | | |||||
* | | Fixed find_by("sql fragment without bindings") on master | Godfrey Chan | 2014-08-25 | 4 | -17/+23 |
| | | | | | | | | | | | | | | | | | | | | | | * Also duplicated find_by tests from relations_test.rb to finder_test.rb now that we have a completely different implementation on the class (in core.rb with AST caching stuff). * Also removed a (failing) test that used mocks. Now that we have tests for the behavior, there's no point having another test that tests the implementation (that it delegates). Further, what the test was implying is nolonger true with the current implementation, because Class.find_by is a real method now. | ||||
* | | pg, `default_sequence_name` needs to return a string. | Yves Senn | 2014-08-25 | 3 | -8/+12 |
| | | | | | | | | | | | | | | | | | | This is a reacon to https://github.com/rails/rails/commit/d6c1205584b1ba597db4071b168681678b1e9875#commitcomment-7502487 This backwards incompatibility was introduced with d6c12055 to fix #7516. However both `connection.default_sequence_name` and `model.sequence_name` are public API. The PostgreSQL adapter should honor the interface and return strings. /cc @matthewd @chancancode | ||||
* | | Fix a few typos [ci skip] | Robin Dupret | 2014-08-24 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #16675 from tomkadwill/has_many_documenting_extension_param | Santiago Pastorino | 2014-08-24 | 1 | -0/+14 |
|\ \ | | | | | | | [ci skip] Added documentation for has_many extension parameter | ||||
| * | | [ci skip] Added documentation for has_many extension parameter | Tom Kadwill | 2014-08-24 | 1 | -0/+14 |
| | | | |||||
* | | | CHANGELOG & improvements to #16649 | Godfrey Chan | 2014-08-23 | 2 | -2/+9 |
| | | | | | | | | | | | | | | | * Require either FIRST or LAST qualifier for "NULLS ..." * Require whitespace before "NULLS ..." | ||||
* | | | Don't trim excess whitespace in pg #columns_for_distinct | Agis- | 2014-08-24 | 2 | -1/+10 |
| |/ |/| | | | | | Fixes #16623 introduced by https://github.com/rails/rails/commit/3d5a2019bcccc6fb01bee4811ca669f4383edb51 | ||||
* | | Merge pull request #15932 from joseluistorres/issue-11957-uuids | Rafael Mendonça França | 2014-08-22 | 3 | -1/+17 |
|\ \ | | | | | | | adding the exception RecordNotFound to UUID find #11957 | ||||
| * | | adding the exception RecordNotFound to UUID find | JoseLuis Torres | 2014-08-21 | 3 | -1/+17 |
| | | | |||||
* | | | Don't calculate in-place changes twice | Sean Griffin | 2014-08-22 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | Now that `changed_attributes` includes in place changes, we don't need to override these methods in Active Record. Partially fixes the performance regression caused by #16189 | ||||
* | | | [ci skip] Running AR tests guide [Fixes GH-15891] | Zachary Scott | 2014-08-22 | 1 | -2/+2 |
| |/ |/| | | | | | Patch by @bcjordan | ||||
* | | [ci skip] Added documentation for has_and_belongs_to_many scope parameter | Tom Kadwill | 2014-08-22 | 1 | -0/+12 |
| | | |||||
* | | Merge pull request #16204 from jonatack/patch-7 | Vijay Dev | 2014-08-21 | 1 | -12/+14 |
|\ \ | | | | | | | Fix minor typos and improve grammar and code formatting | ||||
| * | | Grammar pass | Jon Atack | 2014-08-19 | 1 | -12/+14 |
| | | | | | | | | | | | | | | | | | | [ci skip] Add improvements from @eileencodes [skip ci] | ||||
* | | | [ci skip] Added documentation for has_one scope parameter | Tom Kadwill | 2014-08-21 | 1 | -0/+11 |
| |/ |/| | |||||
* | | "warning: assigned but unused variable" | Akira Matsuda | 2014-08-21 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #16593 from aditya-kapoor/add-doc-for-step | Zachary Scott | 2014-08-20 | 1 | -3/+6 |
|\ \ | | | | | | | [ci skip] add doc for STEP in migration | ||||
| * | | [ci skip] add doc for STEP in migration | Aditya Kapoor | 2014-08-21 | 1 | -3/+6 |
| | | | |||||
* | | | Merge pull request #16575 from tomkadwill/added_has_many_scope_documentation | Zachary Scott | 2014-08-20 | 1 | -0/+11 |
|\ \ \ | |/ / |/| | | [ci skip] Added documentation for has_many scope parameter | ||||
| * | | [ci skip] Added documentation for has_many scope parameter | Tom Kadwill | 2014-08-20 | 1 | -0/+11 |
| | | | |||||
* | | | [ci skip] correct docs about the migration generation | Aditya Kapoor | 2014-08-21 | 1 | -9/+2 |
| | | | |||||
* | | | Merge pull request #16172 from Agis-/hmt_scope_arity | Rafael Mendonça França | 2014-08-20 | 6 | -1/+29 |
|\ \ \ | | | | | | | | | has_many :through with dynamic condition merging | ||||
| * | | | Only merge scopes with zero arity in has_many through | Agis- | 2014-08-20 | 6 | -1/+29 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with dynamic conditions. Fixes #16128 This bug was introduced in https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d so it's present from 4.1.2-rc1 and after. https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d merges any relation scopes passed as proc objects to the relation, but does *not* take into account the arity of the lambda. To reproduce: https://gist.github.com/Agis-/5f1f0d664d2cd08dfb9b | ||||
* | | | | Merge pull request #16145 from phoet/patch-2 | Rafael Mendonça França | 2014-08-20 | 2 | -10/+15 |
|\ \ \ \ | | | | | | | | | | | don't log errors when all is fine | ||||
| * | | | | don't log errors when all is fine | Peter Schröder | 2014-07-17 | 2 | -10/+15 |
| | | | | | |||||
* | | | | | Ignore Postgresql "SELECT tablename FROM pg_tables" when counting queries | Akira Matsuda | 2014-08-20 | 1 | -1/+1 |
| |_|/ / |/| | | | |||||
* | | | | [ci skip] "..enables interrorgating of [thing].." would be correct | Zachary Scott | 2014-08-19 | 1 | -1/+1 |
| | | | | |||||
* | | | | Drop schema_migrations table only when exists | Akira Matsuda | 2014-08-20 | 1 | -1/+1 |
| |/ / |/| | |