aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2014-08-22 10:01:10 -0700
committerSean Griffin <sean@thoughtbot.com>2014-08-22 10:25:36 -0700
commit35bbf0923b038464bb0334e9f75181ea0847d15a (patch)
tree75069c4a95d9750d0a2172b60d114207dfdf131b /activerecord
parent2602a49a8600ab52f807599bbd5b1f9c0be4214f (diff)
downloadrails-35bbf0923b038464bb0334e9f75181ea0847d15a.tar.gz
rails-35bbf0923b038464bb0334e9f75181ea0847d15a.tar.bz2
rails-35bbf0923b038464bb0334e9f75181ea0847d15a.zip
Don't calculate in-place changes twice
Now that `changed_attributes` includes in place changes, we don't need to override these methods in Active Record. Partially fixes the performance regression caused by #16189
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/lib/active_record/attribute_methods/dirty.rb8
1 files changed, 0 insertions, 8 deletions
diff --git a/activerecord/lib/active_record/attribute_methods/dirty.rb b/activerecord/lib/active_record/attribute_methods/dirty.rb
index d3f4e51c33..01f126f1b3 100644
--- a/activerecord/lib/active_record/attribute_methods/dirty.rb
+++ b/activerecord/lib/active_record/attribute_methods/dirty.rb
@@ -43,14 +43,6 @@ module ActiveRecord
calculate_changes_from_defaults
end
- def changed?
- super || changed_in_place.any?
- end
-
- def changed
- super | changed_in_place
- end
-
def changes_applied
super
store_original_raw_attributes