aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Fix interactions between :before_add callbacks and nested attributes assignmentDr.(USA) Joerg Schray2013-08-123-11/+168
| | | | | Issue #1: :before_add callback is called when nested attributes assignment assigns to existing record if the association is not yet loaded Issue #2: Nested Attributes assignment does not affect the record in the association target when callback triggers loading of the association
* chmod -xAkira Matsuda2013-08-124-0/+0
|
* only reconnect if there was already an active connectionAaron Patterson2013-08-111-1/+4
| | | | | If you're using an in-memory database for the test database, reconnecting will lose all information that schema:load did for us.
* Make 'enable_extension' revertibleEric Tipton2013-08-103-1/+16
| | | | | If 'enable_extension' is used in a migration's 'change' method, use 'disable_extension' on down migration (and vice-versa).
* Remove redundant `string_to_binary` from type-castingVipul A M2013-08-096-37/+4
|
* Merge pull request #11802 from ko1/fix_field_encoding_for_mysqlAaron Patterson2013-08-074-3/+14
|\ | | | | Set field encoding to client_encoding for mysql adapter.
| * Set field encoding to client_encoding for mysql adapter.Koichi Sasada2013-08-084-3/+14
| |
* | cast hstore values on write to be consistent with reading from the db.Yves Senn2013-08-084-4/+34
|/
* Merge pull request #11331 from vipulnsward/remove_conditionalAaron Patterson2013-08-071-8/+1
|\ | | | | Remove conditional, results are always an instance of `ActiveRecord::Result`
| * Remove conditional, since results are always an instance of ↵Vipul A M2013-07-061-8/+1
| | | | | | | | `ActiveRecord::Result`
* | use `skip` so we can see what tests are not runAaron Patterson2013-08-081-6/+5
| |
* | Fix multidimensional PG arrays containing non-string itemsYves Senn2013-08-073-15/+32
| |
* | skip `test_unicode_column_name` for `MysqlAdapter`.Yves Senn2013-08-071-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes the build but we need to further investigate the root cause, to see if it can be fixed. The test fails under `MysqlAdapter` with: ``` ActiveRecord::UnknownAttributeError: unknown attribute: なまえ ``` The root cause is that the returned column names from the adapter have the wrong encoding: ```ruby columns = Weird.columns_hash.keys columns # => ["id", "a$b", "\xE3\x81\xAA\xE3\x81\xBE\xE3\x81\x88", "from"] columns.map(&:encoding) # => [#<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>] columns.map {|c| c.dup.force_encoding "utf-8"} # => ["id", "a$b", "なまえ", "from"] ``` From what I can tell the MySQL variables are fine: ``` ActiveRecord::Base.connection.execute("show variables") ... character_set_client utf8 character_set_connection utf8 character_set_database utf8 character_set_filesystem binary character_set_results utf8 character_set_server utf8 character_set_system utf8 character_sets_dir /usr/local/Cellar/mysql/5.5.29/share/mysql/charsets/ collation_connection utf8_general_ci collation_database utf8_unicode_ci collation_server utf8_general_ci ... ```
* | test to express that we can't turn non-array columns to array columns.Yves Senn2013-08-061-0/+9
| | | | | | | | Closes #11062
* | Use the proper encoding comment on the fileRafael Mendonça França2013-08-061-0/+2
| |
* | Fix indentationRafael Mendonça França2013-08-061-3/+2
| |
* | asakusa.rb hack night!Aaron Patterson + Akira Matsuda2013-08-062-0/+5
| | | | | | | | Fix in-memory tests
* | Add CHANGELOG entry for #11767Rafael Mendonça França2013-08-061-0/+4
| | | | | | | | [ci skip]
* | adding a weird test caseAaron Patterson2013-08-062-0/+8
| |
* | config[:database] should be a stringRafael Mendonça França2013-08-051-3/+3
| | | | | | | | | | This change was breaking the Railties tests. See https://travis-ci.org/rails/rails/jobs/9865969
* | Remove deprecated branch on the scope method.Rafael Mendonça França2013-08-051-6/+2
| | | | | | | | The deprecation message was removed on 50cbc03d18c5984347965a94027879623fc44cce but the code was not.
* | Merge pull request #11767 from kassio/master-load-fixtures-from-linked-folderRafael Mendonça França2013-08-055-4/+17
|\ \ | | | | | | Load fixtures from linked folders[master]
| * | load fixtures from linked foldersKassio Borges2013-08-055-4/+17
| | |
* | | Merge pull request #11762 from peterkovacs/patch-2Carlos Antonio da Silva2013-08-051-1/+1
|\ \ \ | | | | | | | | Free result_metadata directly instead of freeing 2nd, redundant call.
| * | | Free result_metadata directly instead of freeing 2nd, redundant call.Peter Kovacs2013-08-051-1/+1
| | | | | | | | | | | | `result_metadata` returns a new object each time it is called, so calling `result_metadata.free` is essentially a noop. Instead call `free` directly on the metadata when we're done with it.
* | | | Create sqlite3 directory if not presentschneems2013-08-053-3/+30
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim
* | | Merge pull request #11693 from egilburg/minor_relation_refactorRafael Mendonça França2013-08-041-38/+45
|\ \ \ | | | | | | | | Minor optimization and code cleanup in query_methods.rb
| * | | Minor optimization and code cleanup in query_methods.Eugene Gilburg2013-07-311-38/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Use symbols rather than strings where possible to avoid extra object construction - Use destructive methods where possible to avoid extra object construction - Use array union rather than concat followed by uniq - Use shorthand block syntax where possible - Use consistent multiline block styles, method names, method parenteses style, and spacing
* | | | Merge pull request #11740 from Karunakar/self_tableRafael Mendonça França2013-08-031-2/+2
|\ \ \ \ | | | | | | | | | | Changing the def self.table_name to self.table_name in the column_name.r...
| * | | | Changing the def self.table_name to self.table_name in the column_name.rbKarunakar (Ruby)2013-08-031-2/+2
| | | | |
* | | | | Merge pull request #11741 from Karunakar/failing_test_in_localRafael Mendonça França2013-08-031-1/+1
|\ \ \ \ \ | | | | | | | | | | | | fix for postgresql failing test in local
| * | | | | fix for postgresql failing test in localKarunakar (Ruby)2013-08-041-1/+1
| |/ / / /
* / / / / use flat_mapNeeraj Singh2013-08-031-1/+1
|/ / / /
* | / / add a test for concat on hm:t associationsAaron Patterson2013-08-021-0/+7
| |/ / |/| |
* | | Merge pull request #11455 from antonio/fix_enable_extension_not_being_definedRafael Mendonça França2013-08-023-0/+32
|\ \ \ | | | | | | | | Define enable_extension method to prevent undefined method error
| * | | Define enable_extension method to prevent undefined method errorAntonio Santos2013-08-023-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When mixing postgresql and another adapter like sqlite3 (for dev and test respectively), the task `db:test:prepare` will fail due to the `enable_extension` method not being defined in the abstract adapter. This patch simply adds an empty definition to prevent it.
* | | | Use assert_nil instead of testing for equalityCarlos Antonio da Silva2013-08-022-3/+2
| | | |
* | | | Merge pull request #11714 from jetthoughts/11706_remove_bad_override_of_xmlRafael Mendonça França2013-08-023-7/+47
|\ \ \ \ | | | | | | | | | | Removed redundant xml override from pg adapter
| * | | | Removed redundant xml override from pg adapterPaul Nikitochkin2013-08-023-7/+47
| | | | | | | | | | | | | | | | | | | | Closes: #11706
* | | | | Use map! to avoid an extra object creationCarlos Antonio da Silva2013-08-021-1/+1
| | | | |
* | | | | Remove useless begin..endCarlos Antonio da Silva2013-08-021-2/+1
| | | | |
* | | | | fix the changelog typo[ci skip]Rajarshi Das2013-08-021-1/+1
|/ / / /
* | | | extract habtm handling to a methodAaron Patterson2013-08-011-8/+12
| | | |
* | | | use drop and avoid a range objectAaron Patterson2013-08-011-1/+1
| | | |
* | | | Change test_registering_new_handlers and test_count_on_invalid_columns_raisesYasuo Honda2013-08-022-2/+2
| | | | | | | | | | | | | | | | | | | | tesetcases assertion to case insensitive because Oracle database adapter handles table name in uppercase.
* | | | remove intermediate assignmentsAaron Patterson2013-08-012-7/+4
| | | |
* | | | push option handling "chrome" outside `initialize`Aaron Patterson2013-08-011-8/+7
| | | |
* | | | remove `valid_options` class methodAaron Patterson2013-08-011-4/+3
| | | |
* | | | association builder classes no longer need the modelAaron Patterson2013-08-013-8/+7
| | | | | | | | | | | | | | | | | | | | decouple the builder classes from the model. Builder objects should be easier to reuse now.
* | | | remove more mutations from the `build` methodAaron Patterson2013-08-011-7/+2
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-13 10:17:19 +0000