aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorKoichi Sasada <ko1@atdot.net>2013-08-08 14:44:39 +0900
committerKoichi Sasada <ko1@atdot.net>2013-08-08 14:44:39 +0900
commit0d435cc24bbf7241df63fcd15724ce2a21d4f9dd (patch)
tree524aa2d065421e9633f1a827b1ec26f15eb791e1 /activerecord
parent765b8aa05c2176ec8d12b623ffc3df330f4ea383 (diff)
downloadrails-0d435cc24bbf7241df63fcd15724ce2a21d4f9dd.tar.gz
rails-0d435cc24bbf7241df63fcd15724ce2a21d4f9dd.tar.bz2
rails-0d435cc24bbf7241df63fcd15724ce2a21d4f9dd.zip
Set field encoding to client_encoding for mysql adapter.
Diffstat (limited to 'activerecord')
-rwxr-xr-x[-rw-r--r--]activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb3
-rwxr-xr-x[-rw-r--r--]activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb4
-rwxr-xr-x[-rw-r--r--]activerecord/lib/active_record/connection_adapters/mysql_adapter.rb8
-rwxr-xr-x[-rw-r--r--]activerecord/test/cases/base_test.rb2
4 files changed, 14 insertions, 3 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
index 5b25b26164..daa9d902fe 100644..100755
--- a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
@@ -469,7 +469,8 @@ module ActiveRecord
sql = "SHOW FULL FIELDS FROM #{quote_table_name(table_name)}"
execute_and_free(sql, 'SCHEMA') do |result|
each_hash(result).map do |field|
- new_column(field[:Field], field[:Default], field[:Type], field[:Null] == "YES", field[:Collation], field[:Extra])
+ field_name = set_field_encoding(field[:Field])
+ new_column(field_name, field[:Default], field[:Type], field[:Null] == "YES", field[:Collation], field[:Extra])
end
end
end
diff --git a/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb b/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
index 28c7cff1cc..92796c996e 100644..100755
--- a/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
@@ -269,6 +269,10 @@ module ActiveRecord
def version
@version ||= @connection.info[:version].scan(/^(\d+)\.(\d+)\.(\d+)/).flatten.map { |v| v.to_i }
end
+
+ def set_field_encoding field_name
+ field_name
+ end
end
end
end
diff --git a/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
index fbe6ecf5f1..15b5452850 100644..100755
--- a/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
@@ -559,6 +559,14 @@ module ActiveRecord
def version
@version ||= @connection.server_info.scan(/^(\d+)\.(\d+)\.(\d+)/).flatten.map { |v| v.to_i }
end
+
+ def set_field_encoding field_name
+ field_name.force_encoding(client_encoding)
+ if internal_enc = Encoding.default_internal
+ field_name = field_name.encoding(internal_enc)
+ end
+ field_name
+ end
end
end
end
diff --git a/activerecord/test/cases/base_test.rb b/activerecord/test/cases/base_test.rb
index e50e32900e..c91cf89f6d 100644..100755
--- a/activerecord/test/cases/base_test.rb
+++ b/activerecord/test/cases/base_test.rb
@@ -585,8 +585,6 @@ class BasicsTest < ActiveRecord::TestCase
end
def test_unicode_column_name
- skip "not on mysql" if current_adapter?(:MysqlAdapter)
- columns = Weird.columns_hash.keys
weird = Weird.create(:なまえ => 'たこ焼き仮面')
assert_equal 'たこ焼き仮面', weird.なまえ
end