Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | added one test case and example for ActiveRecord::Base.to_param method | Kuldeep Aggarwal | 2013-11-15 | 1 | -0/+6 |
| | |||||
* | Fix test name [ci skip] | Carlos Antonio da Silva | 2013-11-14 | 1 | -1/+1 |
| | |||||
* | Revert "Used Yield instead of block.call" -- this causes all of ↵ | David Heinemeier Hansson | 2013-11-14 | 1 | -3/+3 |
| | | | | | | atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd. | ||||
* | Fix that eager loading of polymorphic associations did not work with ↵ | David Heinemeier Hansson | 2013-11-14 | 2 | -3/+1 |
| | | | | association empty?/any? predicates any more (there is still a problem when select is applied to a relation, or if you try association#exists? -- but its easier to work around) | ||||
* | Addendum to #12891 | Javan Makhmali | 2013-11-14 | 1 | -2/+18 |
| | | | | | | * Fix incorrectly named tests * Restore Object#to_param behavior * Ensure param is derived from a squished and truncated string | ||||
* | Merge pull request #12889 from kuldeepaggarwal/speed_ups | Rafael Mendonça França | 2013-11-14 | 1 | -3/+3 |
|\ | | | | | Used Yield instead of block.call | ||||
| * | Used Yield instead of block.call | Kuldeep Aggarwal | 2013-11-15 | 1 | -3/+3 |
| | | |||||
* | | Add AR::Base.to_param for convenient "pretty" URLs derived from a model's ↵ | Javan Makhmali | 2013-11-14 | 2 | -0/+20 |
| | | | | | | | | attribute or method. | ||||
* | | Merge pull request #12772 from dmathieu/no_touching | Rafael Mendonça França | 2013-11-13 | 1 | -0/+48 |
|\ \ | | | | | | | Add No Touching | ||||
| * | | add #no_touching on ActiveRecord models | Damien Mathieu | 2013-11-13 | 1 | -0/+48 |
| | | | |||||
* | | | fix weird Emacs auto indentation. [ci skip] | Yves Senn | 2013-11-13 | 1 | -8/+8 |
| | | | |||||
* | | | tests for merging Relations of different classes. | Yves Senn | 2013-11-13 | 1 | -0/+19 |
| | | | |||||
* | | | move Relation#merge tests into separate file. | Yves Senn | 2013-11-13 | 2 | -121/+131 |
| | | | |||||
* | | | Ensure that a column added in a test is being removed after all | Akira Matsuda | 2013-11-13 | 1 | -0/+7 |
|/ / | |||||
* | | Prevent the counter cache from being decremented twice | dm1try | 2013-11-11 | 1 | -0/+9 |
| | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks. | ||||
* | | Unifies mysql and mysql2 casting of booleans. | Yves Senn | 2013-11-11 | 1 | -3/+3 |
| | | |||||
* | | test cases to describe the MySQL boolean behavior. | Yves Senn | 2013-11-11 | 1 | -0/+91 |
| | | |||||
* | | Do not count "SHOW CREATE TABLE" queries when testing against mysql | Akira Matsuda | 2013-11-11 | 1 | -1/+1 |
| | | |||||
* | | Avoid sorting an Array including objects from different Classes | Akira Matsuda | 2013-11-11 | 1 | -1/+1 |
| | | | | | | | | addresses "ArgumentError: comparison of VerySpecialComment with SpecialComment failed" in ActiveRecord::DelegationRelationTest#test_#sort!_delegation_is_deprecated | ||||
* | | Load test fixtures where data are needed | Akira Matsuda | 2013-11-11 | 1 | -0/+2 |
| | | | | | | | | Without this, some tests here were not actually testing anything. | ||||
* | | Merge pull request #12834 from dredozubov/has_one_association_replacement | Yves Senn | 2013-11-11 | 1 | -2/+16 |
|\ \ | | | | | | | Fixes problem with replacing has_one association record with itself | ||||
| * | | Fixes problem with replacing has_one association record with itself | Denis Redozubov | 2013-11-11 | 1 | -2/+16 |
| |/ | |||||
* | | A tiny grammatical fix | Akira Matsuda | 2013-11-11 | 1 | -1/+1 |
| | | | | | | | | [ci skip] | ||||
* | | Merge pull request #12749 from iantropov/issue_5303 | Rafael Mendonça França | 2013-11-10 | 1 | -0/+4 |
|\ \ | |/ |/| | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue | ||||
| * | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue | Ivan Antropov | 2013-11-03 | 1 | -0/+4 |
| | | |||||
* | | use complete Relation API and not only `Model.all.merge!`. | Yves Senn | 2013-11-09 | 1 | -88/+83 |
| | | |||||
* | | Changed message for Model.inspect | Arun Agrawal | 2013-11-09 | 1 | -1/+1 |
| | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804 | ||||
* | | log bind variables after they were type casted. | Yves Senn | 2013-11-09 | 1 | -0/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]] | ||||
* | | Mark broken test as pending | Rafael Mendonça França | 2013-11-08 | 2 | -0/+4 |
| | | | | | | | | This will avoid the broken window effect in our test suite | ||||
* | | Remove more skip | Rafael Mendonça França | 2013-11-08 | 4 | -13/+7 |
| | | |||||
* | | Don't skip tests if we don't need to. | Rafael Mendonça França | 2013-11-08 | 30 | -1023/+966 |
| | | | | | | | | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed. | ||||
* | | Warning removed for ruby-head | Rashmi Yadav | 2013-11-07 | 1 | -1/+1 |
| | | |||||
* | | bring back constant to expose the enum mapping as HWIA. | Yves Senn | 2013-11-06 | 1 | -0/+6 |
| | | |||||
* | | store enum mapping using `Strings` instead of `Symbols`. | Yves Senn | 2013-11-05 | 1 | -2/+7 |
| | | | | | | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem. | ||||
* | | direct enum assignment rasies ArgumentError for unknown values. | Yves Senn | 2013-11-05 | 1 | -0/+12 |
| | | |||||
* | | define enum methods inside a `Module` to make them overwritable. | Yves Senn | 2013-11-05 | 2 | -0/+10 |
| | | |||||
* | | Remove private API test | Rafael Mendonça França | 2013-11-05 | 1 | -10/+0 |
| | | |||||
* | | Use 1.9 Hash syntax consistently | Pablo Torres | 2013-11-05 | 1 | -1/+1 |
| | | |||||
* | | The enum value constant isn't used, so rm it for now. | Aaron Patterson | 2013-11-04 | 1 | -10/+0 |
| | | |||||
* | | fix copy & paste test-case naming. [ci skip] | Yves Senn | 2013-11-04 | 1 | -1/+1 |
| | | |||||
* | | Convert schema file to ruby 1.9 style hash | Carlos Antonio da Silva | 2013-11-04 | 1 | -214/+214 |
| | | |||||
* | | Style fixes on test schema file | Carlos Antonio da Silva | 2013-11-04 | 1 | -6/+6 |
| | | |||||
* | | Respect cache timestamp format when giving timestamps to #cache_key | Carlos Antonio da Silva | 2013-11-04 | 1 | -2/+2 |
| | | |||||
* | | Add test verifying that you can only sort ARs of the same type | David Heinemeier Hansson | 2013-11-02 | 1 | -1/+7 |
| | | |||||
* | | Revert "ActiveRecord::Base#<=> has been removed. Primary keys may not be in ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | order," -- will be replaced with a check to ensure that the keys used for comparison are integers, and only fail if they are not. This reverts commit 6256734e2d0bdd89f4b5d11da259d40afa0c95c7. Conflicts: activerecord/CHANGELOG.md | ||||
* | | Delegate #rewhere to all on the class like all other relation methods | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+4 |
| | | |||||
* | | Merge pull request #12747 from yury/explicit-enum-values | David Heinemeier Hansson | 2013-11-02 | 3 | -0/+10 |
|\ \ | | | | | | | Explicit mapping for enum | ||||
| * | | Explicit mapping for enum | Yury Korolev | 2013-11-02 | 3 | -0/+10 |
| | | | |||||
* | | | Added ActiveRecord::QueryMethods#rewhere which will overwrite an existing, ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+30 |
| | | | | | | | | | | | | named where condition. | ||||
* | | | unscope now works on default_scope after ↵ | Rafael Mendonça França | 2013-11-02 | 1 | -1/+1 |
|/ / | | | | | | | 94924dc32baf78f13e289172534c2e71c9c8cade |