diff options
author | Yves Senn <yves.senn@gmail.com> | 2013-11-09 11:09:20 +0100 |
---|---|---|
committer | Yves Senn <yves.senn@gmail.com> | 2013-11-09 11:23:34 +0100 |
commit | 97f0d9a0dd12e7ad634815eecfeff866f64aad92 (patch) | |
tree | 4460993ee3f45d113496d27dbc4f7f516bbbd9df /activerecord/test | |
parent | 3cc64df92eef6f1aec240851474f041b27d80ff6 (diff) | |
download | rails-97f0d9a0dd12e7ad634815eecfeff866f64aad92.tar.gz rails-97f0d9a0dd12e7ad634815eecfeff866f64aad92.tar.bz2 rails-97f0d9a0dd12e7ad634815eecfeff866f64aad92.zip |
log bind variables after they were type casted.
The log output used to be confusing in situation where type casting has
"unexpected" effects. For example when finding records with a `String`.
BEFORE:
irb(main):002:0> Event.find("im-no-integer")
D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]]
AFTER:
irb(main):002:0> Event.find("im-no-integer")
D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]]
Diffstat (limited to 'activerecord/test')
-rw-r--r-- | activerecord/test/cases/bind_parameter_test.rb | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/activerecord/test/cases/bind_parameter_test.rb b/activerecord/test/cases/bind_parameter_test.rb index bc00364e85..291751c435 100644 --- a/activerecord/test/cases/bind_parameter_test.rb +++ b/activerecord/test/cases/bind_parameter_test.rb @@ -41,6 +41,17 @@ module ActiveRecord assert_equal binds, message[4][:binds] end + def test_binds_are_logged_after_type_cast + sub = @connection.substitute_at(@pk, 0) + binds = [[@pk, "3"]] + sql = "select * from topics where id = #{sub}" + + @connection.exec_query(sql, 'SQL', binds) + + message = @listener.calls.find { |args| args[4][:sql] == sql } + assert_equal [[@pk, 3]], message[4][:binds] + end + def test_find_one_uses_binds Topic.find(1) binds = [[@pk, 1]] |