aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Remove :timestamp column typeSean Griffin2014-05-195-21/+30
| | | | | | | | | | | | The `:timestamp` type for columns is unused. All database adapters treat them as the same database type. All code in `ActiveRecord` which changes its behavior based on the column's type acts the same in both cases. However, when the type is passed to code that checks for the `:datetime` type, but not `:timestamp` (such as XML serialization), the result is unexpected behavior. Existing schema definitions will continue to work, and the `timestamp` type is transparently aliased to `datetime`.
* Fixing test order issuesRafael Mendonça França2014-05-191-2/+8
|
* Merge pull request #10798 from ↵Rafael Mendonça França2014-05-191-0/+59
|\ | | | | | | | | | | | | | | | | | | jcxplorer/fix-enable_extension-with-table_name_prefix Fix migrations that use enable_extension with table_name_prefix/suffix Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/migration.rb
| * Fix migrations with enable_extensionJoao Carlos2013-05-291-0/+59
| | | | | | | | | | | | | | When using ActiveRecord::Base.table_name_prefix and/or table_name_suffix, extension names got the same treatment as table names when running migrations. This led to migrations that tried to call, for example, enable_extension("prefix_hstore") on the connection.
* | Delegate `Column#type` to the injected type objectSean Griffin2014-05-198-46/+312
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The decision to wrap type registrations in a proc was made for two reasons. 1. Some cases need to make an additional decision based on the type (e.g. a `Decimal` with a 0 scale) 2. Aliased types are automatically updated if they type they point to is updated later. If a user or another adapter decides to change the object used for `decimal` columns, `numeric`, and `number` will automatically point to the new type, without having to track what types are aliased explicitly. Everything else here should be pretty straightforward. PostgreSQL ranges had to change slightly, since the `simplified_type` method is gone.
* | test, inline `DeveloperWithAggregate`, which is used by a single test.Yves Senn2014-05-192-7/+7
| |
* | Merge pull request #14126 from schuetzm/index_option_for_columnRafael Mendonça França2014-05-191-0/+10
|\ \ | | | | | | Make `:index` in migrations work with all column types
| * | Make `:index` in migrations work with all column typesMarc Schütz2014-05-181-0/+10
| | |
* | | pg, re-introduce `PostgreSQL::Utils` to unify schema/table extraction.Yves Senn2014-05-192-15/+20
|/ / | | | | | | Partial revert of c0bfc3f412834ffe8327a15ae3a46602cc28e425
* | Add a type object to Column constructorSean Griffin2014-05-175-45/+46
| | | | | | | | | | | | Part of #15134. In order to perform typecasting polymorphically, we need to add another argument to the constructor. The order was chosen to match the `oid_type` on `PostgreSQLColumn`.
* | Remove dead test code for unsupported adaptersSean Griffin2014-05-1716-172/+80
| |
* | Merge pull request #14428 from jnormore/reset_counters_aliasRafael Mendonça França2014-05-171-3/+13
|\ \ | | | | | | Updates reset_counters to allow counter name in params
| * | Updates reset_counters to allow counter name in paramsJason Normore2014-05-161-3/+13
| | | | | | | | | | | | | | | | | | | | | Add support for counter name to be passed as parameter on `CounterCache::ClassMethods#reset_counters`. This is to be consistent with the other methods in the module that all accept counter name.
* | | Add missing tests for column type cast behaviorSean Griffin2014-05-171-0/+36
|/ /
* | Merge pull request #15071 from leafac/issues/11985Rafael Mendonça França2014-05-161-1/+5
|\ \ | | | | | | Fix `Relation#delete_all` inconsistency
| * | Fix `Relation#delete_all` inconsistencyLeandro Facchinetti2014-05-161-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | When relation scopes include one of `uniq`, `group`, `having` or `offset`, the generated query ignores them and that causes unintended records to be deleted. This solves the issue by restricting the deletion when those scopes are present. rails/rails#11985
* | | Merge pull request #15125 from arthurnn/small_refactoring_transaction_clearGodfrey Chan2014-05-161-0/+13
|\ \ \ | | | | | | | | Small refactoring on clear_transaction_record_state
| * | | Clear transaction state if callback raise rollbackArthur Neves2014-05-151-0/+13
| | | |
* | | | Remove code related to adapter which are no longer in repoArun Agrawal2014-05-161-30/+0
|/ / / | | | | | | | | | As we have remove code for these adapters so no need to have tasks
* | | Changed extract_limit in class Column to return correct mysql float and ↵Aaron Nelson2014-05-161-0/+38
| | | | | | | | | | | | double limits
* | | Merge pull request #15088 from kares/shareable-modulesRafael Mendonça França2014-05-142-20/+15
|\ \ \ | | | | | | | | | | | | [postgres] remove (outer) sub-class declarations with nested modules/classes
| * | | PostgreSQLAdapter::Utils seems to be only used from a single spot - quite ↵kares2014-05-142-20/+15
| | | | | | | | | | | | | | | | redundant
* | | | Merge pull request #14871 from kassio/kb-fixes-namespaced-habtmRafael Mendonça França2014-05-145-0/+31
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix how to compute class name on habtm namespaced. Conflicts: activerecord/CHANGELOG.md
| * | | | Fix how to compute class name on habtm namespaced.Kassio Borges2014-05-135-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thank's for @laurocaetano for the help with tests. :smiley: Fixes #14709
* | | | | Merge pull request #15078 from nbudin/fix_merger_filter_binds_comparison_masterRafael Mendonça França2014-05-143-0/+22
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make filter_binds filter out symbols that are equal to strings Conflicts: activerecord/CHANGELOG.md
| * | | | | Make filter_binds filter out symbols that are equal to stringsNat Budin2014-05-143-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Relation::Merger's filter_binds method does not filter out bind variables when one of the attribute nodes has a string name, but the other has a symbol name, even when those names are actually equal. This can result in there being more bind variables than placeholders in the generated SQL. This is particularly an issue for PostgreSQL, where this is treated as an error. This patch changes the filter_binds method to make it convert both attribute names to strings before comparing.
* | | | | | remove warning `ambiguous first argument; put parentheses or even spaces`Kuldeep Aggarwal2014-05-151-1/+1
| | | | | |
* | | | | | Fix inheritance of stored_attributes (fixes #14672)Jessica Yao2014-05-141-0/+16
| |_|/ / / |/| | | | | | | | | | | | | | [Brad Bennett, Jessica Yao, & Lakshmi Parthasarathy]
* | | | | pg, clarify default behavior for composite types.Yves Senn2014-05-131-7/+94
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * by default composite types are mapped as `OID::Identity` and issue a warning * the user is advised to register his own `OID::Type` to make use of composite types Registering a new `OID::Type` does currently not allow to specify the type casting behavior when writing to the database. In order for it to work we need to use the values within `@attributes`. They are already being type casted and are ready to be written to the DB. See https://github.com/rails/rails/blob/57643c961feb24b662620d330e71103a830003e8/activerecord/lib/active_record/attribute_methods.rb#L460-L462
* | | | test, move all pg array tests into `postgresql/array_test.rb`.Yves Senn2014-05-132-51/+29
|/ / /
* | | test, use `columns_hash[]` in place of `columns.find {}`.Yves Senn2014-05-128-12/+12
| | |
* | | pg, `change_column_default` accepts `[]`. Closes #11586.Yves Senn2014-05-121-1/+9
| | |
* | | pg, map `char` and `name` types as string. [dark-panda & Yves Senn]Yves Senn2014-05-121-0/+23
| | | | | | | | | | | | Closes #10802.
* | | pg, fix Infinity and NaN values conversion.Innokenty Mihailov2014-05-121-0/+7
|/ / | | | | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
* | Handle other pk types in PostgreSQL gracefully.Patrick Robertson2014-05-121-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
* | Merge pull request #14999 from yahonda/modify_bind_variable_nameYves Senn2014-05-121-2/+3
|\ \ | | | | | | | | | | | | | | | | | | Modify assert conditions not to be affected by each database bind variable naming conventions Closes #14999.
| * | Modify assert conditions not to be affectedYasuo Honda2014-05-121-2/+3
| | | | | | | | | | | | by each database bind variable naming conventions
* | | Merge pull request #10662 from ↵Carlos Antonio da Silva2014-05-111-9/+9
|\ \ \ | | | | | | | | | | | | | | | | take/change-test-name-for-ActiveRecord--Validations#valid- Refactor AR's validations_test.rb
| * | | Refactor AR's validations_test.rbTakehiro Adachi2013-12-031-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `:context` switch feature is implemented in ActiveRecord::Validations#valid? method, so we should rename the test names, and execute `valid?` in the test. Change test name in AR's validations_test.rb This test is testing save method's code
* | | | deprecate, join, preload, eager load of instance dependent associations.Yves Senn2014-05-101-4/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
* | | | Fix broken proc syntax for 1.9.3Arthur Neves2014-05-091-1/+1
| | | |
* | | | test, regression test for has_many with instance dependent scope.Yves Senn2014-05-092-0/+12
| | | |
* | | | Reverts "Fix bugs with changed attributes tracking when transaction gets ↵Arthur Neves2014-05-091-42/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rollback" We are reverting these commits, because there are other caveats related to dirty attributes not being restored when a transaction is rollback. For instance, nested transactions cannot proper restore the dirty attributes state after a rollback. At the moment, the dirty attributes are scoped by the transaction. When we call `.save` on a record, the dirty attributes will be reset even if the transaction gets rollback. [related #13166] [related #15018] [related #15016] [closes #15019] This reverts commits * bab48f0a3d53a08bc23ea0887219e8deb963c3d9 * b0fa7cf3ff8432cc2eef3682b34763b7f8c93cc8. * 73fb39b6faa9de593ae75ad4e3b8e065ea0e53af * 37c238927fbed059de3f26a90d8923fb377568a5. * 8d8d4f1560264cd1c74364d67fa0501f6dd2c4fa Revert "Merge pull request #13166 from bogdan/transaction-magic"
* | | | set a constant for the "anonymous" habtm model fixes #15022Aaron Patterson2014-05-081-0/+6
| | | | | | | | | | | | | | | | | | | | I wanted the middle model to be anonymous, but we have to give it a name for marshal support. :'(
* | | | test, regression test for unparsable PostgreSQL defaults.Yves Senn2014-05-081-0/+17
| | | | | | | | | | | | | | | | | | | | This test was inspired by #14866. That PR would break this functionality and we should make sure we notice that in the future.
* | | | Merge pull request #14992 from fredwu/habtm_relation_size_calculation_fixCarlos Antonio da Silva2014-05-082-0/+20
|\ \ \ \ | | | | | | | | | | Habtm relation size calculation fix. Fixes #14913, Fixes #14914.
| * | | | Fixed HABTM's CollectionAssociation sizeFred Wu2014-05-082-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | HABTM should fall back to using the normal CollectionAssociation's size calculation if the collection is not cached or loaded. This addresses both #14913 and #14914 for master.
* | | | | test, reset changed state in PG's uuid tests.Yves Senn2014-05-081-2/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This resulted in some unrelated errors on Traivs: 1) Error: PostgresqlUUIDTest#test_treat_blank_uuid_as_nil: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "thingy" of relation "uuid_data_type" does not exist LINE 1: INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNIN... ^ : INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNING "id" /cc @zuhao
* | | | Keep track of dirty attrs after after rollback.Arthur Neves2014-05-071-18/+4
| | | | | | | | | | | | | | | | [related #13166]
* | | | Merge pull request #13166 from bogdan/transaction-magicRafael Mendonça França2014-05-071-0/+56
|\ \ \ \ | | | | | | | | | | | | | | | [Regression 3.2 -> 4.0] Fix bugs with changed attributes tracking when transaction gets rollback
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 14:44:06 +0000