Merge pull request #10798 from jcxplorer/fix-enable_extension-with-table_name_prefix

Fix migrations that use enable_extension with table_name_prefix/suffix

Conflicts:
	activerecord/CHANGELOG.md
	activerecord/lib/active_record/migration.rb

1 files changed, 59 insertions, 0 deletions

diff --git a/activerecord/test/cases/adapters/postgresql/extension_migration_test.rb b/activerecord/test/cases/adapters/postgresql/extension_migration_test.rb
new file mode 100644
index 0000000000..9387ca73e1
--- /dev/null
+++ b/activerecord/test/cases/adapters/postgresql/extension_migration_test.rb
@@ -0,0 +1,59 @@
+require "cases/helper"
+require "active_record/base"
+require "active_record/connection_adapters/postgresql_adapter"
+
+class PostgresqlExtensionMigrationTest < ActiveRecord::TestCase
+  self.use_transactional_fixtures = false
+
+  class EnableHstore < ActiveRecord::Migration
+    def change
+      enable_extension "hstore"
+    end
+  end
+
+  class DisableHstore < ActiveRecord::Migration
+    def change
+      disable_extension "hstore"
+    end
+  end
+
+  def setup
+    super
+
+    @connection = ActiveRecord::Base.connection
+
+    unless @connection.supports_extensions?
+      return skip("no extension support")
+    end
+
+    ActiveRecord::Base.table_name_prefix = "p_"
+    ActiveRecord::Base.table_name_suffix = "_s"
+    ActiveRecord::SchemaMigration.delete_all rescue nil
+    ActiveRecord::Migration.verbose = false
+  end
+
+  def teardown
+    ActiveRecord::Base.table_name_prefix = ""
+    ActiveRecord::Base.table_name_suffix = ""
+    ActiveRecord::SchemaMigration.delete_all rescue nil
+    ActiveRecord::Migration.verbose = true
+
+    super
+  end
+
+  def test_enable_extension_migration_ignores_prefix_and_suffix
+    @connection.disable_extension("hstore")
+
+    migrations = [EnableHstore.new(nil, 1)]
+    ActiveRecord::Migrator.new(:up, migrations).migrate
+    assert @connection.extension_enabled?("hstore"), "extension hstore should be enabled"
+  end
+
+  def test_disable_extension_migration_ignores_prefix_and_suffix
+    @connection.enable_extension("hstore")
+
+    migrations = [DisableHstore.new(nil, 1)]
+    ActiveRecord::Migrator.new(:up, migrations).migrate
+    assert_not @connection.extension_enabled?("hstore"), "extension hstore should not be enabled"
+  end
+end