rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
*	Use frozen-string-literal in ActiveRecord	Kir Shatrov	2017-07-19	1	-0/+2
\|
*	Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"	Matthew Draper	2017-07-02	1	-1/+0
\| \| \| \| \|	This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
*	Enforce frozen string in Rubocop	Kir Shatrov	2017-07-01	1	-0/+1
\|
*	Deprecate eager-evaluated scopes.	Jon Leighton	2012-03-21	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions
*	Deprecate set_primary_key in favour of self.primary_key=	Jon Leighton	2011-11-29	1	-1/+1
\|
*	The join_nodes must be passed to the JoinDependency initializer and ↵	Jon Leighton	2011-08-29	1	-0/+2
\| \| \| \|	therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556.
*	Ensure has_many :through works with changed primary keys [#736 state:resolved]	Jim Remsik and Tim Pope	2009-03-09	1	-0/+4
	Signed-off-by: Pratik Naik <pratiknaik@gmail.com>