diff options
author | Jon Leighton <j@jonathanleighton.com> | 2012-03-21 22:18:18 +0000 |
---|---|---|
committer | Jon Leighton <j@jonathanleighton.com> | 2012-03-21 22:18:18 +0000 |
commit | 0a12a5f8169685915cbb7bf4d0a7bb482f7f2fd2 (patch) | |
tree | 77ac1032a9ff780fbf3ac92549b0a9de84fbdcba /activerecord/test/models/toy.rb | |
parent | fd68bd23b602ef2a7b038b66e787604df9192c6d (diff) | |
download | rails-0a12a5f8169685915cbb7bf4d0a7bb482f7f2fd2.tar.gz rails-0a12a5f8169685915cbb7bf4d0a7bb482f7f2fd2.tar.bz2 rails-0a12a5f8169685915cbb7bf4d0a7bb482f7f2fd2.zip |
Deprecate eager-evaluated scopes.
Don't use this:
scope :red, where(color: 'red')
default_scope where(color: 'red')
Use this:
scope :red, -> { where(color: 'red') }
default_scope { where(color: 'red') }
The former has numerous issues. It is a common newbie gotcha to do
the following:
scope :recent, where(published_at: Time.now - 2.weeks)
Or a more subtle variant:
scope :recent, -> { where(published_at: Time.now - 2.weeks) }
scope :recent_red, recent.where(color: 'red')
Eager scopes are also very complex to implement within Active
Record, and there are still bugs. For example, the following does
not do what you expect:
scope :remove_conditions, except(:where)
where(...).remove_conditions # => still has conditions
Diffstat (limited to 'activerecord/test/models/toy.rb')
-rw-r--r-- | activerecord/test/models/toy.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/test/models/toy.rb b/activerecord/test/models/toy.rb index 0377e50011..ddc7048a56 100644 --- a/activerecord/test/models/toy.rb +++ b/activerecord/test/models/toy.rb @@ -2,5 +2,5 @@ class Toy < ActiveRecord::Base self.primary_key = :toy_id belongs_to :pet - scope :with_pet, joins(:pet) + scope :with_pet, -> { joins(:pet) } end |