aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #24773 from ralinc/fix-silent-fail-on-psql-commandArthur Nogueira Neves2016-06-161-2/+2
|\ | | | | PostgreSQL: Fix db:structure:load silent failure on SQL error
| * PostgreSQL: Fix db:structure:load silent failure on SQL errorRalin Chimev2016-05-101-2/+2
| | | | | | | | | | | | | | | | The command line flag "-v ON_ERROR_STOP=1" should be used when invoking psql to make sure errors are not suppressed. Example: psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db Fixes #23818.
* | Merge pull request #25271 from kamipo/prevent_range_error_for_existsSean Griffin2016-06-151-4/+2
|\ \ | | | | | | Prevent `RangeError` for `FinderMethods#exists?`
| * | Prevent `RangeError` for `FinderMethods#exists?`Ryuta Kamizono2016-06-161-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `FinderMethods#exists?` should return a boolean rather than raising an exception. `UniquenessValidator#build_relation` catches a `RangeError` because it includes type casting due to a string value truncation. But a string value truncation was removed at #23523 then type casting in `build_relation` is no longer necessary. aa06231 removes type casting in `build_relation` then a `RangeError` moves to `relation.exists?`. This change will remove the catching a `RangeError`.
* | | Fix postgresql query_cache testArthur Neves2016-06-141-0/+1
| | |
* | | Respect the current `connected?` method when calling `cache`Arthur Neves2016-06-141-0/+15
| | | | | | | | | | | | | | | | | | Before we enable query caching we check if the connection is connected. Before this fix we were always checking against the main connection, and not the model connection.
* | | Remove not needed line on testArthur Neves2016-06-141-1/+0
| | |
* | | Merge pull request #25374 from ↵Sean Griffin2016-06-131-0/+4
|\ \ \ | | | | | | | | | | | | | | | | kamipo/fix_calculate_with_string_in_from_and_eager_loading Fix `calculate` with a string value in `from` and eager loading
| * | | Fix `calculate` with a string value in `from` and eager loadingRyuta Kamizono2016-06-131-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `construct_relation_for_association_calculations` pass a string value to `construct_join_dependency` when setting a string value in `from`. It should not pass a string value, but always `joins_values`. Related #14834, #19452. Fixes #24193.
* | | | Merge pull request #25372 from kamipo/remove_assert_date_from_dbSean Griffin2016-06-132-5/+1
|\ \ \ \ | |/ / / |/| | | Remove unnecessary `assert_date_from_db`
| * | | Remove unnecessary `assert_date_from_db`Ryuta Kamizono2016-06-122-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | `assert_date_from_db` was added at 6a2104d for SQL Server. But latest sqlserver adapter work to pass expected behavior since 8e4624b.
* | | | Merge pull request #25362 from maclover7/jm-rm-ar-requireEileen M. Uchitelle2016-06-121-2/+0
|\ \ \ \ | | | | | | | | | | Remove unnecessary model requires
| * | | | Remove unnecessary model requiresJon Moss2016-06-101-2/+0
| |/ / /
* / / / Remove outdated comments [ci skip]Ryuta Kamizono2016-06-121-12/+0
|/ / / | | | | | | | | | | | | These comments were added at dd257a3ccb30ab181cd48d3d81bc7f23bb45f36f but outdated since #2086.
* | | Remove dead code from testsSean Griffin2016-06-091-17/+0
| | | | | | | | | | | | | | | This code was added in 81286f858770e0b95e15af37f19156b044ec6a95, but was not used by that commit and does not appear to have ever been used.
* | | Merge pull request #25329 from ↵Sean Griffin2016-06-091-1/+1
|\ \ \ | | | | | | | | | | | | | | | | yahonda/allow_oracle_bind_value_syntax_in_loj_test Allow Oracle bind parameter syntax `:a1` in test_join_conditions_added_to_join_clause
| * | | Allow Oracle bind parameter syntax `:a1`Yasuo Honda2016-06-081-1/+1
| |/ /
* / / Fix typoAbhishek Jain2016-06-091-2/+2
|/ /
* | Fix sqlite3 test failureRyuta Kamizono2016-06-042-3/+3
| | | | | | | | Sqlite3 test failure is due to 66ebbc4952f6cfb37d719f63036441ef98149418.
* | Dont re-define class SQLite3Adapter on testArthur Neves2016-06-032-108/+98
| | | | | | | | | | | | | | We were declaring in a few tests, which depending of the order load will cause an error, as the super class could change. see https://github.com/rails/rails/commit/ac1c4e141b20c1067af2c2703db6e1b463b985da#commitcomment-17731383
* | Merge pull request #25243 from sukesan1984/add_i18n_validation_testYves Senn2016-06-031-4/+2
|\ \ | | | | | | Add i18n_validation_test
| * | Add i18n_validation_testsukesan19842016-06-021-4/+2
| | | | | | | | | | | | add active record uniqueness validation test for { on: [:create, :update] } condition.
* | | Ensure that records with unselected fields can be updatedSean Griffin2016-06-021-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of refactoring mutation detection to be more performant, we introduced the concept of `original_value` to `Attribute`. This was not overridden in `Attribute::Uninitialized` however, so assigning ot an uninitialized value and calling `.changed?` would raise `NotImplementedError`. We are using a sentinel value rather than checking the result of `original_attribute.initialized?` in `changed?` because `original_value` might go through more than one node in the tree. Fixes #25228
* | | Fix failing testsSean Griffin2016-06-021-0/+7
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently CI is broken due to 56a61e0 and c4cb686. This occurred because the failures are not present on SQLite which is what I normally run locally before pushing. The optimizations to our YAML size were dropping mutations, as `with_type` didn't set the previous value if it'd already been read (that method was never really designed to be used with values on individual objects, it was previously only used for defaults). I'm questioning whether there's a better place to be handling the exclusion of the type, but this will fix the failing build. Additionally, there was a bug in `remove_foreign_key` if you passed it an options hash containing `to_table`. This now occurs whenever removing a reference, as we always normalize to a hash. [Sean Griffin & Ryuta Kamizono]
* | Make Active Record emit significantly smaller YAMLSean Griffin2016-05-311-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reduces the size of a YAML encoded Active Record object by ~80% depending on the number of columns. There were a number of wasteful things that occurred when we encoded the objects before that have resulted in numerous wins - We were emitting the result of `attributes_before_type_cast` as a hack to work around some laziness issues - The name of an attribute was emitted multiple times, since the attribute objects were in a hash keyed by the name. We now store them in an array instead, and reconstruct the hash using the name - The types were included for every attribute. This would use backrefs if multiple objects were encoded, but really we don't need to include it at all unless it differs from the type at the class level. (The only time that will occur is if the field is the result of a custom select clause) - `original_attribute:` was included over and over and over again since the ivar is almost always `nil`. We've added a custom implementation of `encode_with` on the attribute objects to ensure we don't write the key when the field is `nil`. This isn't without a cost though. Since we're no longer including the types, an object can find itself in an invalid state if the type changes on the class after serialization. This is the same as 4.1 and earlier, but I think it's worth noting. I was worried that I'd introduce some new state bugs as a result of doing this, so I've added an additional test that asserts mutation not being lost as the result of YAML round tripping. Fixes #25145
* | Respect options passed to `foreign_key` when reverting `add_reference`Sean Griffin2016-05-311-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | The code incorrectly assumes that the option was written as `foreign_key: true`, but that is not always the case. This now mirrors the behavior of reverting `add_foreign_key`. The code was changed to use kwargs while I was touching it, as well. This could really use a refactoring to go through the same code paths as `add_refernce` in the future, so we don't duplicate default values. Fixes #25169
* | Merge pull request #25213 from kamipo/do_not_include_default_column_limitSean Griffin2016-05-312-8/+13
|\ \ | | | | | | Do not include default column limit in schema.rb
| * | Do not include default column limit in schema.rbRyuta Kamizono2016-05-312-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #20815. ```ruby class CreatePeople < ActiveRecord::Migration[5.0] def change create_table :people do |t| t.integer :int t.bigint :bint t.text :txt t.binary :bin end end end ``` Result. In postgresql and sqlite3 adapters: ```ruby ActiveRecord::Schema.define(version: 20160531141018) do create_table "people", force: :cascade do |t| t.integer "int" t.bigint "bint" t.text "txt" t.binary "bin" end end ``` In mysql2 adapter: ```ruby ActiveRecord::Schema.define(version: 20160531141018) do create_table "people", force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8mb4" do |t| t.integer "int" t.bigint "bint" t.text "txt", limit: 65535 t.binary "bin", limit: 65535 end end ``` After this patch: ```ruby ActiveRecord::Schema.define(version: 20160531141018) do create_table "people", force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8mb4" do |t| t.integer "int" t.bigint "bint" t.text "txt" t.binary "bin" end end ```
* | | `ActiveRecord::Base#hash` should differ between classesSean Griffin2016-05-311-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | Prior to this change, we would get collisions if Active Record objects of different classes with the same ID were used as keys of the same hash. It bothers me slightly that we have to allocate inside of this method, but Ruby doesn't provide any way to hash multiple values without allocation
* | | Ensure hashes can be passed to attributes using `composed_of`Sean Griffin2016-05-311-0/+5
|/ / | | | | | | | | | | | | | | | | | | | | This behavior was broken by 36e9be85. When the value is assigned directly, either through mass assignment or directly assigning a hash, the hash gets passed through to this writer method directly. While this is intended to handle certain cases, when an explicit converter has been provided, we should continue to use that instead. The positioning of the added guard caused the new behavior to override that case. Fixes #25210
* | Exists shouldn't error when used with `includes`Sean Griffin2016-05-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `exists?` does some hackery where it assumes that we can join onto anything that we passed to `eager_load` or `includes`, which doesn't work if we are joining onto a polymorphic association. Actually figuring out if we want to include something would require knowledge deep within the join dependency module, which is hard to pull up. The simplest solution is just to pass a flag down that says we're not actually going to try to eager load any of the data. It's not the solution I'd like, but that code really needs to be untangled before we can do much with it. This is another attempt at 6d5b1fd which should address the concerns that led to reverting it in 4ecabed.
* | Merge pull request #24965 from arthurnn/arthurnn/conn_apiArthur Nogueira Neves2016-05-293-12/+15
|\ \ | | | | | | Change some establish_connection logic
| * | Add to_hash to specificationArthur Neves2016-05-251-1/+1
| | |
| * | Remove `name` from `establish_connection`Arthur Neves2016-05-243-12/+15
| | | | | | | | | | | | | | | Instead of passing a separete name variable, we can make the resolver merge a name on the config, and use that before creating the Specification.
* | | Fix `has_one` `enum` `where` queriesJon Moss2016-05-261-0/+18
|/ / | | | | | | Fixes #25128
* | Merge pull request #25093 from Erol/activerecord-transaction-serialization-errorRafael França2016-05-212-0/+134
|\ \ | | | | | | Introduce AR::TransactionSerializationError for transaction serialization failures or deadlocks
| * | Add AR::TransactionSerializationError for transaction serialization failures ↵Erol Fornoles2016-05-212-0/+134
| | | | | | | | | | | | or deadlocks
* | | Merge pull request #24732 from y-yagi/update_record_specified_in_the_keyRafael França2016-05-211-0/+17
|\ \ \ | |/ / |/| | update record specified in key
| * | update record specified in keyyuuji.yaginuma2016-04-271-0/+17
| | | | | | | | | | | | | | | | | | `#first_or_initialize` does not use attributes to data acquisition. Therefore, there is a possibility of updating the different record than the one specified in the key, I think this is not expected behavior.
* | | Merge pull request #24958 from maclover7/fix-24955Rafael França2016-05-201-0/+6
|\ \ \ | | | | | | | | Fix ActiveRecord::LogSubscriber edge case
| * | | Fix ActiveRecord::LogSubscriber edge caseJon Moss2016-05-101-0/+6
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an attribute was of the binary type, and also was a Hash, it would previously not be logged, and instead raise an error saying that `bytesize` was not defined for the `attribute.value` (a `Hash`). Now, as is done on 4-2-stable, the attribute's database value is `bytesize`d, and then logged out to the terminal. Reproduction script: ```ruby require 'active_record' require 'minitest/autorun' require 'logger' ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:') ActiveRecord::Base.logger = Logger.new(STDOUT) ActiveRecord::Schema.define do create_table :posts, force: true do |t| t.binary :preferences end end class Post < ActiveRecord::Base serialize :preferences end class BugTest < Minitest::Test def test_24955 Post.create!(preferences: {a: 1}) assert_equal 1, Post.count end end ```
* | | Merge pull request #24984 from kamipo/remove_magic_comment_in_schema.rbRafael França2016-05-201-4/+0
|\ \ \ | | | | | | | | Remove magic comment in generated `schema.rb`
| * | | Remove magic comment in generated `schema.rb`Ryuta Kamizono2016-05-121-4/+0
| | | | | | | | | | | | | | | | | | | | Rails 5.0 has been dropped Ruby 1.9 support. I think no need magic comment anymore.
* | | | Support for unified Integer class in Ruby 2.4+Jeremy Daer2016-05-189-16/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer.
* | | | Merge pull request #24203 from sferik/count_with_blockKasper Timm Hansen2016-05-162-0/+9
|\ \ \ \ | | | | | | | | | | Forward ActiveRecord::Relation#count to Enumerable#count if block given
| * | | | Forward ActiveRecord::Relation#count to Enumerable#count if block givenErik Michaels-Ober2016-03-192-0/+9
| | | | |
* | | | | Merge pull request #25009 from jahfer/suppressor-keep-stateSean Griffin2016-05-161-0/+12
|\ \ \ \ \ | | | | | | | | | | | | Keep previous state around for nested calls to #suppress
| * | | | | Keep state around for nested calls to #suppressJahfer Husain2016-05-161-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a call to #suppress from the same class occurred inside another #suppress block, the suppression state would be set to false before the outer block completes. This change keeps the previous state around in memory and unwinds it as the blocks exit.
* | | | | | Merge pull request #23810 from xijo/fix_json_coder_when_mysql_strict_is_disabledSean Griffin2016-05-161-0/+15
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Fix bug in JSON deserialization when column default is an empty string
| * | | | | | Fix bug in JSON deserialization when column default is an empty stringJohannes Opper2016-02-221-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `ActiveRecord::Coders::JSON` serialization is used and the default of the column returns `''` it raises the following error: ``` JSON::ParserError: A JSON text must at least contain two octets! ``` If MySQL is running in non-strict mode, it returns an empty string as column default for a text column: ```ruby def extract_default if blob_or_text_column? @default = null || strict ? nil : '' end end ``` Since `''` is invalid JSON, there shouldn't be an attempt to parse it, it should be treated like nil. ActiveRecord::Coders::JSON should behave consistently for all possible non-user-set column default values.