diff options
| author | Sean Griffin <sean@seantheprogrammer.com> | 2016-06-15 18:22:34 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-06-15 18:22:34 -0400 |
| commit | 7980b31bc6dd123a0635f470998362a602b66e25 (patch) | |
| tree | 84c36d7b70ca3aabb66e2957b54d311ebc57eeae /activerecord/test/cases | |
| parent | 61a7239e405982e78de15bd86583514248e6f525 (diff) | |
| parent | 1cf467b7a31749ccb3fc2a8ac89c5218c95e7d70 (diff) | |
| download | rails-7980b31bc6dd123a0635f470998362a602b66e25.tar.gz rails-7980b31bc6dd123a0635f470998362a602b66e25.tar.bz2 rails-7980b31bc6dd123a0635f470998362a602b66e25.zip | |
Merge pull request #25271 from kamipo/prevent_range_error_for_exists
Prevent `RangeError` for `FinderMethods#exists?`
Diffstat (limited to 'activerecord/test/cases')
| -rw-r--r-- | activerecord/test/cases/finder_test.rb | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/activerecord/test/cases/finder_test.rb b/activerecord/test/cases/finder_test.rb index 374a8ba199..6eaaa30cd0 100644 --- a/activerecord/test/cases/finder_test.rb +++ b/activerecord/test/cases/finder_test.rb @@ -173,11 +173,9 @@ class FinderTest < ActiveRecord::TestCase end end - def test_exists_fails_when_parameter_has_invalid_type - assert_raises(ActiveModel::RangeError) do - assert_equal false, Topic.exists?(("9"*53).to_i) # number that's bigger than int - end + def test_exists_returns_false_when_parameter_has_invalid_type assert_equal false, Topic.exists?("foo") + assert_equal false, Topic.exists?(("9"*53).to_i) # number that's bigger than int end def test_exists_does_not_select_columns_without_alias |