Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Raise when a through association has an ambiguous reflection name | Rafael Mendonça França | 2016-12-29 | 1 | -1/+1 |
| | |||||
* | Raises when `ActiveRecord::Migration` is inherited directly. | Rafael Mendonça França | 2016-12-29 | 1 | -12/+6 |
| | |||||
* | `#tables` and `#table_exists?` and returns only tables and not views | Rafael Mendonça França | 2016-12-29 | 10 | -84/+61 |
| | |||||
* | Remove deprecated `name` argument from `#tables` | Rafael Mendonça França | 2016-12-29 | 3 | -8/+2 |
| | |||||
* | Remove deprecated support to passing a column to #quote | Rafael Mendonça França | 2016-12-29 | 1 | -12/+12 |
| | |||||
* | Set time as a timezone aware type and remove related deprecation | Rafael Mendonça França | 2016-12-29 | 1 | -3/+0 |
| | |||||
* | Remove deprecated force reload argument in association readers | Rafael Mendonça França | 2016-12-29 | 6 | -47/+4 |
| | |||||
* | Remove deprecated i18n scopes in Active Record | Rafael Mendonça França | 2016-12-29 | 2 | -39/+0 |
| | |||||
* | Merge pull request #27437 from kirs/structure-load-dump-flags | Kasper Timm Hansen | 2016-12-29 | 3 | -4/+81 |
|\ | | | | | Make ActiveRecord structure load/dump configurable | ||||
| * | Make ActiveRecord structure load/dump configurable | Kir Shatrov | 2016-12-22 | 3 | -4/+81 |
| | | | | | | | | | | | | | | | | Without this patch it's impossible to pass extra flags to mysqldump/pg_dump when running `rake db:structure:dump` or `load` The following config variables (`structure_load_flags` and `structure_dump_flags`) make it better configurable. | ||||
* | | Should not update children when the parent creation with no reason | Ryuta Kamizono | 2016-12-29 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | This issue was introduced with d849f42 to solve #19782. However, we can solve #19782 without causing the issue. It is enough to save only when necessary. Fixes #27338. | ||||
* | | Fix Rubocop violations and fix documentation visibility | Rafael Mendonça França | 2016-12-28 | 2 | -6/+6 |
| | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API. | ||||
* | | Merge pull request #27442 from kamipo/fix_27434 | Eileen M. Uchitelle | 2016-12-27 | 1 | -1/+1 |
|\ \ | | | | | | | Add a record to target before any callbacks loads the record | ||||
| * | | Add a record to target before any callbacks loads the record | Ryuta Kamizono | 2016-12-23 | 1 | -1/+1 |
| |/ | | | | | | | | | | | | | | | | | `append_record` was added at 15ddd51 for not double adding the record. But adding `append_record` (checking `@target.include?(record)`) caused performance regression #27434. Instead of checking not double adding the record, add a record to target before any callbacks loads the record. Fixes #27434. | ||||
* | | assert_equal takes expectation first | Akira Matsuda | 2016-12-26 | 8 | -19/+19 |
| | | |||||
* | | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6." | Akira Matsuda | 2016-12-25 | 4 | -10/+10 |
| | | |||||
* | | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 22 | -77/+77 |
| | | |||||
* | | Privatize unneededly protected methods in Active Record tests | Akira Matsuda | 2016-12-24 | 8 | -8/+8 |
|/ | |||||
* | fix #create_fixtures when equal table names in different databases | Julia Lopez | 2016-12-21 | 1 | -0/+15 |
| | |||||
* | Merge pull request #27400 from kamipo/remove_useless_test_supports_primary_key | Eileen M. Uchitelle | 2016-12-19 | 1 | -6/+0 |
|\ | | | | | Remove useless `test_supports_primary_key` | ||||
| * | Remove useless `test_supports_primary_key` | Ryuta Kamizono | 2016-12-19 | 1 | -6/+0 |
| | | | | | | | | | | `supports_primary_key?` method is defined in `AbstractAdapter` so does not raise any errors. | ||||
* | | Consolidate duplicated elsif branch | Ryuta Kamizono | 2016-12-19 | 1 | -6/+1 |
|/ | |||||
* | Merge pull request #27329 from kamipo/simplify_unsigned_regex | Eileen M. Uchitelle | 2016-12-17 | 1 | -1/+1 |
|\ | | | | | Simplify the regex for `unsigned?` method | ||||
| * | Simplify the regex for `unsigned?` method | Ryuta Kamizono | 2016-12-11 | 1 | -1/+1 |
| | | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`. | ||||
* | | Merge pull request #27375 from kirs/fixture-error-message | Rafael França | 2016-12-16 | 1 | -2/+12 |
|\ \ | | | | | | | Throw friendly error message when fixture is not a hash | ||||
| * | | Throw friendly error message when fixture is not a hash | Kir Shatrov | 2016-12-15 | 1 | -2/+12 |
| | | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid. | ||||
* | | | fix QueryCache nil dup | Richard Monette | 2016-12-15 | 2 | -2/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog | ||||
* | | | fix new warning in ruby 2.4 | yuuji.yaginuma | 2016-12-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning. ``` test/caching_test.rb:986: warning: parentheses after method name is interpreted as test/caching_test.rb:986: warning: an argument list, not a decomposed argument test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: parentheses after method name is interpreted as test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: an argument list, not a decomposed argument ``` Ref: https://github.com/ruby/ruby/commit/65e27c8b138d6959608658ffce2fa761842b8d24 | ||||
* | | | Merge pull request #27042 from kirs/yaml-schema-cache | Rafael França | 2016-12-13 | 1 | -4/+39 |
|\ \ \ | | | | | | | | | Schema cache in YAML | ||||
| * | | | Use YAML to serialize schema cache | Kir Shatrov | 2016-11-27 | 1 | -4/+39 |
| | | | | |||||
* | | | | Remove duplicated line | Ryuta Kamizono | 2016-12-11 | 1 | -1/+0 |
| |_|/ |/| | | |||||
* | | | Fix CI failure caused by #25227 and #25280 were merged at the same time | Ryuta Kamizono | 2016-12-10 | 1 | -1/+1 |
| |/ |/| | |||||
* | | Merge pull request #25280 from ↵ | Sean Griffin | 2016-12-10 | 1 | -0/+14 |
|\ \ | | | | | | | | | | | | | kamipo/prevent_range_error_for_belongs_to_associations Prevent `RangeError` for `belongs_to` associations | ||||
| * | | Prevent `RangeError` for `belongs_to` associations | Ryuta Kamizono | 2016-10-10 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes #20140. | ||||
* | | | Merge pull request #25227 from kamipo/numeric_value_out_of_range | Sean Griffin | 2016-12-10 | 2 | -2/+10 |
|\ \ \ | | | | | | | | | Translate numeric value out of range to the specific exception | ||||
| * | | | Translate numeric value out of range to the specific exception | Ryuta Kamizono | 2016-12-06 | 2 | -2/+10 |
| | | | | | | | | | | | | | | | | Raise `ActiveRecord::RangeError` when values that executed are out of range. | ||||
* | | | | Emulate db trigger behaviour for after_commit :destroy, :update | Stefan Budeanu | 2016-12-09 | 1 | -0/+45 |
| | | | | | | | | | | | | | | | | | | | | | | | | Race conditions can occur when an ActiveRecord is destroyed twice or destroyed and updated. The callbacks should only be triggered once, similar to a SQL database trigger. | ||||
* | | | | Resolve association class correctly when assigning ids on a through association | Matthew Draper | 2016-12-09 | 1 | -0/+7 |
| | | | | |||||
* | | | | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodel | Sean Griffin | 2016-12-08 | 1 | -0/+17 |
|\ \ \ \ | | | | | | | | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord | ||||
| * | | | | Moved database-specific ActiveModel types into ActiveRecord | Iain Beeston | 2016-10-14 | 1 | -0/+17 |
| | | | | | | | | | | | | | | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger | ||||
* | | | | | Check whether the current attribute being write is aliased or not before writing | Prathamesh Sonpatki | 2016-12-09 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. | ||||
* | | | | | Check whether the current attribute being read is aliased or not before reading | Prathamesh Sonpatki | 2016-12-08 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. - Fixes #26417. | ||||
* | | | | | Merge pull request #27251 from ebeigarts/fix-autosave | Sean Griffin | 2016-12-06 | 1 | -0/+24 |
|\ \ \ \ \ | |_|/ / / |/| | | | | Fix association scope inside autosaved association callbacks | ||||
| * | | | | Improve test without using anonymous classes | Edgars Beigarts | 2016-12-06 | 1 | -27/+24 |
| | | | | | |||||
| * | | | | Reload association scope inside autosaved associations | Edgars Beigarts | 2016-12-02 | 1 | -0/+27 |
| | | | | | |||||
* | | | | | Translate NOT NULL violation to the specific exception | Ryuta Kamizono | 2016-12-06 | 3 | -8/+20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::NotNullViolation` when a record cannot be inserted or updated because it would violate a not null constraint. | ||||
* | | | | | Merge pull request #26687 from kamipo/fix_add_index_to_normalize_options | Matthew Draper | 2016-12-06 | 2 | -0/+7 |
|\ \ \ \ \ | | | | | | | | | | | | | Fix `add_index` to normalize column names and options | ||||
| * | | | | | Fix `add_index` to normalize column names and options | Ryuta Kamizono | 2016-10-03 | 2 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently does not work the following code. ```ruby add_index(:people, ["last_name", "first_name"], order: { last_name: :desc, first_name: :asc }) ``` Normalize column names and options to fix the issue. | ||||
* | | | | | | Merge pull request #27274 from kamipo/primary_key_with_auto_increment_and_bigint | Matthew Draper | 2016-12-06 | 1 | -8/+18 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Make `:auto_increment` option works on `:bigint` | ||||
| * | | | | | | Make `:auto_increment` option works on `:bigint` | Ryuta Kamizono | 2016-12-06 | 1 | -8/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #27272. |