aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2016-12-29 16:17:01 +0900
committerRyuta Kamizono <kamipo@gmail.com>2016-12-29 16:24:57 +0900
commit9abf606a79729833fd90f624ed580ad85f3ebadc (patch)
tree2ae13816024dd83168aadee998ace0505734dc65 /activerecord/test/cases
parent366f094598305074c4430fab581ddfd599c1cf96 (diff)
downloadrails-9abf606a79729833fd90f624ed580ad85f3ebadc.tar.gz
rails-9abf606a79729833fd90f624ed580ad85f3ebadc.tar.bz2
rails-9abf606a79729833fd90f624ed580ad85f3ebadc.zip
Should not update children when the parent creation with no reason
This issue was introduced with d849f42 to solve #19782. However, we can solve #19782 without causing the issue. It is enough to save only when necessary. Fixes #27338.
Diffstat (limited to 'activerecord/test/cases')
-rw-r--r--activerecord/test/cases/autosave_association_test.rb8
1 files changed, 8 insertions, 0 deletions
diff --git a/activerecord/test/cases/autosave_association_test.rb b/activerecord/test/cases/autosave_association_test.rb
index eb80ae4f7c..6d31b7a091 100644
--- a/activerecord/test/cases/autosave_association_test.rb
+++ b/activerecord/test/cases/autosave_association_test.rb
@@ -1391,6 +1391,14 @@ module AutosaveAssociationOnACollectionAssociationTests
assert_equal "Squawky", parrot.reload.name
end
+ def test_should_not_update_children_when_parent_creation_with_no_reason
+ parrot = Parrot.create!(name: "Polly")
+ assert_equal 0, parrot.updated_count
+
+ Pirate.create!(parrot_ids: [parrot.id], catchphrase: "Arrrr")
+ assert_equal 0, parrot.reload.updated_count
+ end
+
def test_should_automatically_validate_the_associated_models
@pirate.send(@association_name).each { |child| child.name = "" }