aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/migration/command_recorder_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* make change_column_comment and change_table_comment invertibleYoshiyuki Kinjo2019-04-151-0/+34
| | | | | | | | | We can revert migrations using `change_column_comment` or `change_table_comment` at current master. However, results are not what we expect: comments are remained in new status. This change tells previous comment to these methods in a way like `change_column_default`.
* Fix `transaction` reverting for migrationsfatkodima2018-09-261-0/+10
| | | | [fatkodima & David Verhasselt]
* Change the empty block style to have space inside of the blockRafael Mendonça França2018-09-251-3/+3
|
* Follow up #33530bogdanvlviv2018-08-151-0/+5
| | | | | | | | | - Move changelog entry of #33530 up in order to preserve the chronology since we always add new entries on the top of a changelog file. - Clarify the changelog entry - Clarify the docs of remove_foreign_key - Ensure reversible of `remove_foreign_key` with `:primary_key` and `:to_table` options.
* Allow `to_table` in `invert_remove_foreign_key`Rich2018-08-141-0/+8
| | | | | | | | | | | | remove_foreign_key supports - remove_foreign_key :accounts, :branches - remove_foreign_key :accounts, to_table: :branches but the second one is not reversible. This branch is to fix and allow second one to be reversible. [Nikolay Epifanov, Rich Chen]
* Use respond_to test helpersDaniel Colson2018-01-251-2/+2
|
* Use algorithm while removing index with db:rollbackMehmet Emin İNAÇ2017-09-211-0/+5
| | | | Closes #24190
* Use frozen-string-literal in ActiveRecordKir Shatrov2017-07-191-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Remove a redundant test case of command_recorder_testKoichi ITO2017-05-291-5/+0
|
* Add three new rubocop rulesRafael Mendonça França2016-08-161-13/+13
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* applies new string literal convention in activerecord/testXavier Noria2016-08-061-10/+10
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Removed mocha from Active Record Part 2Ronak Jangir2015-09-161-1/+2
|
* Add reversible syntax for change_column_defaultPrem Sichanugrist2015-06-261-0/+10
| | | | | | | | | | | | | Passing `:from` and `:to` to `change_column_default` makes this command reversible as user has defined its previous state. So, instead of having the migration command as: change_column_default(:posts, :state, "draft") They can write it as: change_column_default(:posts, :state, from: nil, to: "draft")
* make `remove_index :table, :column` reversible.Yves Senn2015-06-151-0/+5
| | | | | | | | | This used to raise a `IrreversibleMigration` error (since #10437). However since `remove_index :table, :column` is probably the most basic use-case we should make it reversible again. Conflicts: activerecord/CHANGELOG.md
* Add an invert method for remove_foreign_keyAster Ryan2015-06-111-1/+30
|
* add test to ensure `remove_reference` with index and fk is invertable.Yves Senn2015-02-111-0/+5
|
* Failure to rollback t.timestamps when within a change_table migrationnoam2014-12-031-2/+2
| | | | | | | | | | | | | When running the following migration: change_table(:table_name) { |t| t/timestamps } The following error was produced: wrong number of arguments (2 for 1) .... /connection_adapters/abstract/schema_statements.rb:851:in `remove_timestamps' This is due to `arguments` containing an empty hash as its second argument.
* fk: infere column name from table names.Yves Senn2014-06-261-0/+5
| | | | This allows to create and remove foreign keys without specifying a column.
* fk: make `add_foreign_key` reversible.Yves Senn2014-06-261-0/+20
|
* Add test cases for Migration#inverse_ofAditya Kapoor2014-06-171-0/+17
|
* Drop the correct index after reverting a migrationHubert Dąbrowski2014-02-131-3/+3
| | | | | | Previously when reverting a migration which added a named index it would instead drop a corresponding index with matching columns but without a name.
* Make change_table use object of current database adapterNishant Modak2014-01-071-1/+2
| | | | | | | | | - Earlier, change_table was creating database-agnostic object. - After this change, it will create correct object based on current database adapter. - This will ensure that create_table and change_table will get same objects. - This makes update_table_definition method public and nodoc. - Fixes #13577 and #13503
* Make 'enable_extension' revertibleEric Tipton2013-08-101-0/+10
| | | | | If 'enable_extension' is used in a migration's 'change' method, use 'disable_extension' on down migration (and vice-versa).
* Make execute, change_column and remove_columns methods actually irreversibleMarc-Andre Lafortune2012-12-211-1/+7
| | | | [#8267]
* Make change_table reversible when possible [#8267]Marc-Andre Lafortune2012-12-211-0/+20
|
* Factorize methods that are easily reversible [#8267]Marc-Andre Lafortune2012-12-211-8/+8
|
* Make remove_index reversible [#8267]Marc-Andre Lafortune2012-12-211-3/+24
|
* Differentiate between remove_column and remove_columns. Make remove_column ↵Marc-Andre Lafortune2012-12-211-1/+12
| | | | | | reversible. [#8267]
* Make drop_table reversible [#8267]Marc-Andre Lafortune2012-12-211-11/+24
|
* Add drop_join_table [#8267]Marc-Andre Lafortune2012-12-211-4/+10
|
* Allow reverting of migration commands with Migration#revert [#8267]Marc-Andre Lafortune2012-12-211-48/+51
|
* Make references statements reversibleAleksey Magusev2012-07-031-3/+27
|
* Add `create_join_table` migration helper to create HABTM join tablesRafael Mendonça França2012-01-271-0/+12
|
* Fix GH #4285. Remove options when we record calling creat_tablekennyj2012-01-041-0/+6
|
* Fixed bad options order in ↵jbbarth2011-08-281-2/+2
| | | | ActiveRecord::Migration::CommandRecorder#invert_rename_index
* Reversing the changes done in c278a2c while still resolving #1857.Vijay Dev2011-07-021-5/+3
| | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before.
* CommandRecorder should delegate in method_missing where possible. Fixes some ↵Jon Leighton2011-06-301-1/+6
| | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce.
* record unsupported methods in CommandRecorder instead of letting the ↵Vijay Dev2011-06-251-3/+5
| | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations
* please use ruby -I lib:test path/to/test.rb, or export RUBY_OPTAaron Patterson2011-06-061-1/+1
|
* Refactor Active Record test connection setup. Please see the ↵Jon Leighton2011-06-041-1/+1
| | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
* Added a test to check for correct behaviour with no options in add_index ↵David Workman2011-05-241-0/+6
| | | | command recorder
* Simple fix for correctly inverting an add_index migration when a name has ↵David Workman2011-05-231-0/+6
| | | | been provided
* Add :bulk => true option to change_tablePratik Naik2011-01-311-1/+1
|
* command recorder will record commands sent to a delegate objectAaron Patterson2010-11-191-0/+22
|
* IrreversibleMigration is raised if we cannot invert the commandAaron Patterson2010-11-191-0/+7
|
* commands are reversedAaron Patterson2010-11-191-0/+7
|
* partial implementation of the command recorderAaron Patterson2010-11-191-0/+72